ISSUE DESCRIPTION issue: values data is reset after first render, when shouldUnregister…
- User
ISSUE DESCRIPTION
issue:
valuesdata is reset after first render, whenshouldUnregisteris providedVersion Number
7.71.2
Codesandbox/Expo snack
https://codesandbox.io/p/sandbox/blazing-dust-3225h9?file=%2Fsrc%2FApp.js
Steps to reproduce
- Simply submit a form
- See error
Expected behaviour
It is possible to successfully submit a form, when data is provided via
values, andshouldUnregister: trueoption is setWhat browsers are you seeing the problem on?
Chrome
Code of Conduct
- I agree to follow this project's Code of Conduct
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /react-hook-form, current file: none) bash-$
- Assistant
I'll start by exploring the repository structure and reproducing the issue described.
- Assistant
Let me examine the source code related to
valuesandshouldUnregister. - Assistant
Let me look at the issue more carefully. The codesandbox is about values being reset when shouldUnregister is true. Let me search for related tests and code.
- Assistant
rg not found, use grep instead.
- Assistant
Let me look at how
valuesinteracts withshouldUnregisterin the form control and related tests. - Assistant
Let me read the useForm and createFormControl related to values.
- Assistant
Let me examine useForm.ts and the values/reset flow more carefully.
- Assistant
Let me read the rest of useForm.ts
- Assistant
Let me examine createFormControl's initialization and reset handling for shouldUnregister.
- Assistant
Let me examine the reset function and related tests for values with shouldUnregister.
- Assistant
I found a suspicious piece of code. Let me continue reading the reset function and check related tests/history.
- Assistant
Let me check how keepFieldsRef interacts with mount names and search for related issues/fixes.
- Assistant
Let me look at tests related to the
valuesprop and how handleSubmit gathers form data. - Assistant
Let me try to write a minimal reproduction based on the issue description.
- Assistant
Let me look at the values-related tests around line 2255 in useForm.test.tsx
- Assistant
Let me write a temporary reproduction script to confirm the bug.
- Assistant
Need to fix the import path.
- Assistant
Confirmed the bug. Let me dig into register and handleSubmit to find the right fix.
- Assistant
Let me inspect
_getWatchand how submit collects values. - Assistant
Let me look at handleSubmit more carefully.
- Assistant
Let me check when this shouldUnregister logic in reset was introduced and look at related PR history.
- Assistant
Let me look at the CHANGELOG and any related GitHub issues or recent similar bugs.
- Assistant
There's a recent related fix. Let me inspect it.
- Assistant
That was a useController fix. Let me look at it.
- Assistant
Let me check the types for keepFieldsRef and existing reset tests.
- Assistant
I'll implement the fix in
_resetto preserve form values and mount names whenkeepFieldsRefis set. - Assistant
Let me apply the fix.
- Assistant
Let me run the reproduction test to verify the fix.
- Assistant
The fix works. Let me expand tests for edge cases and run existing related tests.
- Assistant
All edge cases pass. Now I'll run the related existing tests.
- Assistant
Related tests passed. Running more shouldUnregister-related tests.
- Assistant
All tests passed. Cleaning up the temporary test and reviewing the final diff.
- Assistant
I'll simplify the comment to match the codebase style.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →