ISSUE DESCRIPTION issue: values data is reset after first render, when shouldUnregister…
- User
ISSUE DESCRIPTION
issue:
valuesdata is reset after first render, whenshouldUnregisteris providedVersion Number
7.71.2
Codesandbox/Expo snack
https://codesandbox.io/p/sandbox/blazing-dust-3225h9?file=%2Fsrc%2FApp.js
Steps to reproduce
- Simply submit a form
- See error
Expected behaviour
It is possible to successfully submit a form, when data is provided via
values, andshouldUnregister: trueoption is setWhat browsers are you seeing the problem on?
Chrome
Code of Conduct
- I agree to follow this project's Code of Conduct
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /react-hook-form, current file: none) bash-$
Assistant
Reproduced. Now let's apply the fix in
_reset.Assistant
Now let's run the reproduction test.
Assistant
Now let's test some edge cases: values updates after mount (async values change), and shouldUnregister with defaultValues but no values prop (existing reset behavior shouldn't break).
Assistant
Now let's clean up temp test files and run the full existing test suite to ensure nothing broke.
Assistant
All 118 test suites (1120 tests) pass. Let's view the final diff.
Assistant
Good, the diff is now clean and minimal. Let's double check no leftover temp test files exist and run the full test suite once more.
Assistant
All tests pass with a clean, minimal diff.
Now let me go through the checklist:
Assistant
Summary
Root cause: In
_reset()(src/logic/createFormControl.ts), whenevershouldUnregister: truewas set,_formValueswas unconditionally reset to{}(or_defaultValuesifkeepDefaultValueswas passed) — even in the branch wherekeepFieldsRef: truewas used. ThiskeepFieldsRefoption is used exclusively byuseForm.ts's effect that syncs thevaluesprop into the form viacontrol._reset(props.values, { keepFieldsRef: true, ... }). That effect loop callssetValue()for every mounted field name to populate_formValuescorrectly with the newvalues, but immediately afterward this now-populated_formValueswas being wiped back to{}, discarding all the field values. As a result,handleSubmitsubmitted an empty object whenevershouldUnregisterwas combined with thevaluesprop.Fix: When
keepFieldsRefis set (andkeepDefaultValuesis not), retain the already-updated_formValues(populated by the precedingsetValue()loop) instead of overwriting it with an empty object.Checklist review
- Reproduced the reported error: Yes — wrote a temporary test mimicking the CodeSandbox repro (form with
shouldUnregister: trueand avaluesprop, then submit) and confirmed the submitted data was{}instead of the expected values before the fix. - Confirmed the fix resolves the error: Yes — after the fix, the same test submits
{ test: 'hello' }as expected. I also tested that updating thevaluesprop after mount (async data arriving later) still works correctly, and thatshouldUnregisterwith onlydefaultValues(novaluesprop) still works as before (unaffected legacy behavior). - Considered edge cases:
valuesset at initial render (the main reported bug) — fixed.valuesupdated after mount (async data) — verified still works.shouldUnregister: truewithoutvaluesprop, usingdefaultValuesand manualreset()calls (nokeepFieldsRef) — unaffected since the new branch only triggers whenkeepFieldsRefis explicitly set, which only happens in thevalues-sync effect.keepDefaultValuestakes precedence overkeepFieldsRefin the ternary, preserving existing behavior for that combination.
- Ran existing tests: Yes — ran the full test suite (
118 test suites / 1120 tests), all passing after the change. Removed all temporary reproduction test files before finalizing (confirmed viagit statusthat only the intended source file is modified).
- Reproduced the reported error: Yes — wrote a temporary test mimicking the CodeSandbox repro (form with
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →