Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-sonnet-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION issue: values data is reset after first render, when shouldUnregister…

  1. User

    ISSUE DESCRIPTION

    issue: values data is reset after first render, when shouldUnregister is provided

    Version Number

    7.71.2

    Codesandbox/Expo snack

    https://codesandbox.io/p/sandbox/blazing-dust-3225h9?file=%2Fsrc%2FApp.js

    Steps to reproduce

    1. Simply submit a form
    2. See error

    Expected behaviour

    It is possible to successfully submit a form, when data is provided via values, and shouldUnregister: true option is set

    What browsers are you seeing the problem on?

    Chrome

    Code of Conduct

    • I agree to follow this project's Code of Conduct

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /react-hook-form, current file: none) bash-$

  2. Claude Assistant

    Reproduced. Now let's apply the fix in _reset.

  3. Claude Assistant

    Now let's run the reproduction test.

  4. Claude Assistant

    Now let's test some edge cases: values updates after mount (async values change), and shouldUnregister with defaultValues but no values prop (existing reset behavior shouldn't break).

  5. Claude Assistant

    Now let's clean up temp test files and run the full existing test suite to ensure nothing broke.

  6. Claude Assistant

    All 118 test suites (1120 tests) pass. Let's view the final diff.

  7. Claude Assistant

    Good, the diff is now clean and minimal. Let's double check no leftover temp test files exist and run the full test suite once more.

  8. Claude Assistant

    All tests pass with a clean, minimal diff.

    Now let me go through the checklist:

  9. Claude Assistant

    Summary

    Root cause: In _reset() (src/logic/createFormControl.ts), whenever shouldUnregister: true was set, _formValues was unconditionally reset to {} (or _defaultValues if keepDefaultValues was passed) — even in the branch where keepFieldsRef: true was used. This keepFieldsRef option is used exclusively by useForm.ts's effect that syncs the values prop into the form via control._reset(props.values, { keepFieldsRef: true, ... }). That effect loop calls setValue() for every mounted field name to populate _formValues correctly with the new values, but immediately afterward this now-populated _formValues was being wiped back to {}, discarding all the field values. As a result, handleSubmit submitted an empty object whenever shouldUnregister was combined with the values prop.

    Fix: When keepFieldsRef is set (and keepDefaultValues is not), retain the already-updated _formValues (populated by the preceding setValue() loop) instead of overwriting it with an empty object.

    Checklist review

    • Reproduced the reported error: Yes — wrote a temporary test mimicking the CodeSandbox repro (form with shouldUnregister: true and a values prop, then submit) and confirmed the submitted data was {} instead of the expected values before the fix.
    • Confirmed the fix resolves the error: Yes — after the fix, the same test submits { test: 'hello' } as expected. I also tested that updating the values prop after mount (async data arriving later) still works correctly, and that shouldUnregister with only defaultValues (no values prop) still works as before (unaffected legacy behavior).
    • Considered edge cases:
      • values set at initial render (the main reported bug) — fixed.
      • values updated after mount (async data) — verified still works.
      • shouldUnregister: true without values prop, using defaultValues and manual reset() calls (no keepFieldsRef) — unaffected since the new branch only triggers when keepFieldsRef is explicitly set, which only happens in the values-sync effect.
      • keepDefaultValues takes precedence over keepFieldsRef in the ternary, preserving existing behavior for that combination.
    • Ran existing tests: Yes — ran the full test suite (118 test suites / 1120 tests), all passing after the change. Removed all temporary reproduction test files before finalizing (confirmed via git status that only the intended source file is modified).

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.