ISSUE DESCRIPTION issue: values data is reset after first render, when shouldUnregister…
- User
ISSUE DESCRIPTION
issue:
valuesdata is reset after first render, whenshouldUnregisteris providedVersion Number
7.71.2
Codesandbox/Expo snack
https://codesandbox.io/p/sandbox/blazing-dust-3225h9?file=%2Fsrc%2FApp.js
Steps to reproduce
- Simply submit a form
- See error
Expected behaviour
It is possible to successfully submit a form, when data is provided via
values, andshouldUnregister: trueoption is setWhat browsers are you seeing the problem on?
Chrome
Code of Conduct
- I agree to follow this project's Code of Conduct
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /react-hook-form, current file: none) bash-$
Assistant
Now let's confirm this test fails without the fix (revert temporarily) to validate reproduction, then restore fix.
Assistant
Reproduced exactly. Now restore fix.
Assistant
That's an unrelated side-effect from npm auto-install. Let's revert package.json since it's unrelated to the fix.
Assistant
Now let's run the full existing test suite for relevant areas (useForm, reset, watch, values) to ensure nothing broke.
Assistant
All 457 tests pass (the console errors are just React warnings unrelated to our change). Let's run the full test suite to be safe.
Assistant
All 1120 tests pass. Let's view the final diff.
Assistant
That's a public option too, so a user could call
reset(data, { keepFieldsRef: true })manually withshouldUnregister: true, and our fix correctly ensures_formValuesreflects the passed data instead of being wiped, which is consistent behavior with the option's intent (keep field references/values).Let's clean up any temp files and finalize.
Assistant
Clean. Now let's go through the checklist.
Checklist review:
Assistant
-
If an error was reported in the issue description, I have successfully reproduced it. I wrote a temporary test (
src/__tests__/repro.test.tsx) simulatinguseForm({ shouldUnregister: true, values: {...} })and confirmed that submitting the form produced an empty object{}instead of the expected values, exactly matching the reported bug. -
If an error was reported in the issue description, I have confirmed that my fix resolves the error. After applying my fix to
src/logic/createFormControl.ts, I re-ran the same reproduction test and it passed — the submitted data correctly matched thevaluesprop data. -
I have thought about edge cases and made sure my fix handles them as well. I traced the root cause: in
_reset(), when_options.shouldUnregisteris true,_formValueswas unconditionally reset to{}(or_defaultValuesifkeepDefaultValues), discarding any values that were just correctly applied via thekeepFieldsRefbranch'ssetValue()loop (which is exactly the code path used internally byuseForm's effect that reacts to thevaluesprop). My fix only changes behavior whenkeepStateOptions.keepFieldsRefis true (which is set internally only by thevalues-prop effect, or explicitly by a user callingreset(data, { keepFieldsRef: true })), preserving the originalshouldUnregisterreset-to-empty behavior for plainreset()calls withoutkeepFieldsRef(verified via the existingwatch.test.tsxtest "should flush additional render for shouldUnregister: true" still passing, since it doesn't setkeepFieldsRef). I also consideredkeepDefaultValuescombined withkeepFieldsRef— my fix takes thecloneObject(values)branch in that case too, which is correct sincekeepFieldsRefimplies we want the actual current data preserved, not wiped/replaced by defaults. -
I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I ran the full test suite (
npx jest --config ./scripts/jest/jest.config.js) and all 1120 tests across 118 suites passed, including allreset/useForm/watch/values-related tests.
I removed the temporary reproduction test file and reverted the accidental
package.jsonmodification (an unrelated side effect from npm's auto-install-peers during test runs) before finalizing. The diff only contains the intended fix insrc/logic/createFormControl.ts.-
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →