Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-sonnet-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION issue: values data is reset after first render, when shouldUnregister…

  1. User

    ISSUE DESCRIPTION

    issue: values data is reset after first render, when shouldUnregister is provided

    Version Number

    7.71.2

    Codesandbox/Expo snack

    https://codesandbox.io/p/sandbox/blazing-dust-3225h9?file=%2Fsrc%2FApp.js

    Steps to reproduce

    1. Simply submit a form
    2. See error

    Expected behaviour

    It is possible to successfully submit a form, when data is provided via values, and shouldUnregister: true option is set

    What browsers are you seeing the problem on?

    Chrome

    Code of Conduct

    • I agree to follow this project's Code of Conduct

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /react-hook-form, current file: none) bash-$

  2. Claude Assistant

    Now let's confirm this test fails without the fix (revert temporarily) to validate reproduction, then restore fix.

  3. Claude Assistant

    Reproduced exactly. Now restore fix.

  4. Claude Assistant

    That's an unrelated side-effect from npm auto-install. Let's revert package.json since it's unrelated to the fix.

  5. Claude Assistant

    Now let's run the full existing test suite for relevant areas (useForm, reset, watch, values) to ensure nothing broke.

  6. Claude Assistant

    All 457 tests pass (the console errors are just React warnings unrelated to our change). Let's run the full test suite to be safe.

  7. Claude Assistant

    All 1120 tests pass. Let's view the final diff.

  8. Claude Assistant

    That's a public option too, so a user could call reset(data, { keepFieldsRef: true }) manually with shouldUnregister: true, and our fix correctly ensures _formValues reflects the passed data instead of being wiped, which is consistent behavior with the option's intent (keep field references/values).

    Let's clean up any temp files and finalize.

  9. Claude Assistant

    Clean. Now let's go through the checklist.

    Checklist review:

  10. Claude Assistant
    • If an error was reported in the issue description, I have successfully reproduced it. I wrote a temporary test (src/__tests__/repro.test.tsx) simulating useForm({ shouldUnregister: true, values: {...} }) and confirmed that submitting the form produced an empty object {} instead of the expected values, exactly matching the reported bug.

    • If an error was reported in the issue description, I have confirmed that my fix resolves the error. After applying my fix to src/logic/createFormControl.ts, I re-ran the same reproduction test and it passed — the submitted data correctly matched the values prop data.

    • I have thought about edge cases and made sure my fix handles them as well. I traced the root cause: in _reset(), when _options.shouldUnregister is true, _formValues was unconditionally reset to {} (or _defaultValues if keepDefaultValues), discarding any values that were just correctly applied via the keepFieldsRef branch's setValue() loop (which is exactly the code path used internally by useForm's effect that reacts to the values prop). My fix only changes behavior when keepStateOptions.keepFieldsRef is true (which is set internally only by the values-prop effect, or explicitly by a user calling reset(data, { keepFieldsRef: true })), preserving the original shouldUnregister reset-to-empty behavior for plain reset() calls without keepFieldsRef (verified via the existing watch.test.tsx test "should flush additional render for shouldUnregister: true" still passing, since it doesn't set keepFieldsRef). I also considered keepDefaultValues combined with keepFieldsRef — my fix takes the cloneObject(values) branch in that case too, which is correct since keepFieldsRef implies we want the actual current data preserved, not wiped/replaced by defaults.

    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I ran the full test suite (npx jest --config ./scripts/jest/jest.config.js) and all 1120 tests across 118 suites passed, including all reset/useForm/watch/values-related tests.

    I removed the temporary reproduction test file and reverted the accidental package.json modification (an unrelated side effect from npm's auto-install-peers during test runs) before finalizing. The diff only contains the intended fix in src/logic/createFormControl.ts.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.

ISSUE DESCRIPTION issue: values data is reset after first… · The Chat Archive