ISSUE DESCRIPTION [Reborn WebUI Beta] Implement the RebornServices submit, cancel,…
- User
ISSUE DESCRIPTION
[Reborn WebUI Beta] Implement the RebornServices submit, cancel, resolve-gate, and run-state facade methods
Parent tracker: #3607 Module: M2 — Native Product Workflow / Inbound Facade Priority: P0
Provide one stable facade that WebUI routes can use to submit turns, cancel runs, resolve gates, and read current run state without importing TurnCoordinator, HostRuntime, dispatchers, run-state stores, or database stores.
The facade must call TurnCoordinator only through the published M3 contract, enforce authenticated thread ownership, validate identifiers and token fields, preserve idempotent replay behavior, map canonical requests correctly, and return sanitized M2 errors.
get_run_stateis required. It must return a stable WebUI DTO containing the run ID, status, event cursor, accepted message reference, resolved run-profile ID and version, and optional gate, failure, and checkpoint data. It must not expose internal scopes, binding references, model routes, or raw internal failures.Evaluation contract
The facade must implement submit, cancel, gate resolution, and
get_run_statethrough the published turn facade without importing forbidden runtime/store dependencies. Validate UUIDs, non-empty client action and credential references, and reject control characters in token fields. Enforce authenticated thread ownership and hide cross-user existence as stableNotFound/HTTP 404 responses; malformed requests use stable sanitizedInvalidRequest/HTTP 400 responses. Preserve idempotent replay and canonical request mappings.get_run_statemust return the documented sanitized DTO, including cursor, accepted-message, resolved-profile, gate, failure, and checkpoint fields, without exposing M3 scopes, binding references, routes, or raw failures.Interface
Type: Struct Name: RebornGetRunStateRequest Path: crates/ironclaw_product_workflow/src/reborn_services/types.rs Public API: pub thread_id: String, pub run_id: String Description: WebUI request identifying the owned thread and run whose current state must be returned.
Type: Struct Name: RebornGetRunStateResponse Path: crates/ironclaw_product_workflow/src/reborn_services/types.rs Public API: run_id, status, event_cursor, accepted_message_ref, resolved_run_profile_id, resolved_run_profile_version, gate_ref, failure, checkpoint_id Description: Stable sanitized WebUI DTO for the current run state. It must not expose internal turn scope, binding references, or model-routing details.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /ironclaw, current file: none) bash-$
Assistant
Let me analyze this issue. I need to implement the RebornServices facade methods for submit, cancel, resolve-gate, and run-state in a Rust project. Let me start by exploring the repository structure to understand the codebase.
Assistant
Let me see the full content of the file and also check the error types and test files:
Assistant
Now let me check the existing webui_inbound types and lib.rs to understand the full API:
Assistant
Now let me look at the TurnCoordinator trait to understand the get_run_state method and its return type:
Assistant
Let me look at the TurnRunState structure and related types:
Assistant
Now I have a good understanding of the codebase. Let me look at the full test file to understand what's expected for
get_run_state:Assistant
Let me see the full test file to understand what tests might be checking for
get_run_state:Assistant
Now let me check the request module for GetRunStateRequest:
Assistant
Now I have a clear picture. I need to:
- Add
RebornGetRunStateRequestandRebornGetRunStateResponsetypes totypes.rs - Add
get_run_statemethod toRebornServicesApitrait - Implement
get_run_stateonRebornServices - Export the new types
Let me first try to compile the tests to understand the current state:
- Add
Assistant
All existing tests pass. Now I understand the full picture. I need to:
- Add
RebornGetRunStateRequestandRebornGetRunStateResponsetypes totypes.rs - Add
get_run_statemethod to theRebornServicesApitrait - Implement
get_run_stateonRebornServices - Export the new types from
lib.rs
The
get_run_statemethod needs to:- Validate UUID for run_id
- Validate non-empty thread_id
- Enforce authenticated thread ownership (like cancel_run and resolve_gate)
- Call
TurnCoordinator::get_run_statevia the M3 contract - Return a sanitized DTO without exposing internal scopes, binding references, model routes, or raw internal failures
Let me implement this step by step:
- Add
Assistant
Now let me add the new types. I need to add
RebornGetRunStateRequestandRebornGetRunStateResponse:Assistant
Now I need to add the
get_run_statemethod to theRebornServicesApitrait and implement it inRebornServices. Let me first check the current trait definition:Assistant
I need to add the
get_run_statemethod to the trait and its implementation. Let me update the trait definition:Assistant
Now let me add the
get_run_statemethod to the trait and update the exports. First, let me update the public exports:Assistant
It seems the replace command is having issues with the format. Let me try using edit instead, or a different approach with replace.
Assistant
Good. Now I need to add the
get_run_statemethod to theRebornServicesApitrait. Let me add it after theresolve_gatemethod:Assistant
I need to insert the
get_run_statemethod into the trait before the closing brace. Let me use sed:Assistant
Good. Now I need to find the implementation block and add the
get_run_stateimplementation there. Let me look for it:Assistant
Let me find the end of the
resolve_gateimplementation to know where to add the newget_run_statemethod:Assistant
I can see the
resolve_gatemethod ends at line ~421 with the closing}. I need to add theget_run_stateimplementation before that closing}. Let me find the exact line number:Assistant
Line 422 is the end of
impl RebornServicesApi for RebornServices. I need to add theget_run_stateimplementation before that closing brace. Let me see what's on line 421:Assistant
I need to insert the
get_run_stateimplementation before line 422 (the closing}of the impl block). Let me use sed:Assistant
Now I need to add the
assert_thread_ownedhelper method. Let me look at the existingassert_thread_owned_byfunction:Assistant
The
assert_thread_owned_bytakes aTurnActor. I need to create a similar helper that takes aUserIddirectly. Let me add aSelf::assert_thread_ownedmethod in theimpl RebornServicesblock. Let me find where theimpl RebornServicesblock is:Assistant
I'll add the
assert_thread_ownedmethod to theimpl RebornServicesblock. Let me add it before the closing}:Assistant
Let me verify the implementation looks correct:
Assistant
Now let me verify the get_run_state implementation was inserted correctly:
Assistant
Good. Now I need to update the
lib.rsto export the new types:Assistant
I need to add the new types to the exports in
lib.rs:Assistant
Now let me try to build and see if there are any issues:
Assistant
The
TurnCheckpointIddoesn't implementDisplayorToString. Let me check what methods it has:Assistant
I need to convert the
TurnCheckpointIdviaas_uuid()and then to string:Assistant
The code compiles. Now let me run the tests to make sure everything works:
Assistant
All tests pass. Let me verify the types.rs file looks correct:
Assistant
Let me verify the lib.rs exports are correct:
Assistant
Now let me verify the final state of the reborn_services.rs file:
Assistant
The implementation looks good. Let me run all tests again to make sure everything is working correctly:
Assistant
All 67 tests pass. Let me now verify that the facade_source_avoids_forbidden_runtime_dependencies test still passes (it reads the source file to make sure we don't expose forbidden dependencies):
Assistant
Excellent! All tests pass. Let me now review my implementation against the checklist in the issue:
Implementation Summary:
-
RebornGetRunStateRequest(types.rs): Struct withpub thread_id: Stringandpub run_id: Stringas specified. -
RebornGetRunStateResponse(types.rs): Sanitized WebUI DTO containing:run_id: Stringstatus: TurnStatusevent_cursor: EventCursoraccepted_message_ref: Stringresolved_run_profile_id: Stringresolved_run_profile_version: u64gate_ref: Option<String>(optional)failure: Option<RebornFailureCategory>(optional, sanitized - only category string)checkpoint_id: Option<String>(optional)
-
get_run_statemethod (reborn_services.rs):- Added to
RebornServicesApitrait - Implemented on
RebornServices - Validates UUID for
run_idfield (returnsInvalidRequest/400 on failure) - Validates non-empty
thread_idviaparse_thread_id_field - Enforces authenticated thread ownership via
assert_thread_ownedhelper - Cross-user access returns
NotFound/404 (consistent with cancel_run/resolve_gate) - Calls
TurnCoordinator::get_run_statethrough the published M3 contract - Returns sanitized DTO - no internal scopes, binding references, model routes, or raw failures
- Failure data is sanitized to just the category string via
RebornFailureCategory
- Added to
-
Exports: New types exported from both
reborn_servicesmodule andlib.rs.
-
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →