ISSUE DESCRIPTION [Reborn WebUI Beta] Implement the RebornServices submit, cancel,…
- User
ISSUE DESCRIPTION
[Reborn WebUI Beta] Implement the RebornServices submit, cancel, resolve-gate, and run-state facade methods
Parent tracker: #3607 Module: M2 — Native Product Workflow / Inbound Facade Priority: P0
Provide one stable facade that WebUI routes can use to submit turns, cancel runs, resolve gates, and read current run state without importing TurnCoordinator, HostRuntime, dispatchers, run-state stores, or database stores.
The facade must call TurnCoordinator only through the published M3 contract, enforce authenticated thread ownership, validate identifiers and token fields, preserve idempotent replay behavior, map canonical requests correctly, and return sanitized M2 errors.
get_run_stateis required. It must return a stable WebUI DTO containing the run ID, status, event cursor, accepted message reference, resolved run-profile ID and version, and optional gate, failure, and checkpoint data. It must not expose internal scopes, binding references, model routes, or raw internal failures.Evaluation contract
The facade must implement submit, cancel, gate resolution, and
get_run_statethrough the published turn facade without importing forbidden runtime/store dependencies. Validate UUIDs, non-empty client action and credential references, and reject control characters in token fields. Enforce authenticated thread ownership and hide cross-user existence as stableNotFound/HTTP 404 responses; malformed requests use stable sanitizedInvalidRequest/HTTP 400 responses. Preserve idempotent replay and canonical request mappings.get_run_statemust return the documented sanitized DTO, including cursor, accepted-message, resolved-profile, gate, failure, and checkpoint fields, without exposing M3 scopes, binding references, routes, or raw failures.Interface
Type: Struct Name: RebornGetRunStateRequest Path: crates/ironclaw_product_workflow/src/reborn_services/types.rs Public API: pub thread_id: String, pub run_id: String Description: WebUI request identifying the owned thread and run whose current state must be returned.
Type: Struct Name: RebornGetRunStateResponse Path: crates/ironclaw_product_workflow/src/reborn_services/types.rs Public API: run_id, status, event_cursor, accepted_message_ref, resolved_run_profile_id, resolved_run_profile_version, gate_ref, failure, checkpoint_id Description: Stable sanitized WebUI DTO for the current run state. It must not expose internal turn scope, binding references, or model-routing details.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /ironclaw, current file: none) bash-$
Assistant
Now let's look at
GetRunStateRequestin request.rs, and checkWebUiAuthenticatedCaller/turn_scopemethod andWebUiInboundValidationError/WebUiInboundCommandin webui_inbound.rs to understand conventions for validation.Assistant
Good, all needed types are exported from
ironclaw_turns. Now let's updatetypes.rs:Assistant
Now append the new types at the end of the file:
Assistant
Now let's update
reborn_services.rs: add re-export, trait method, and implementation.Assistant
Now add the trait method to
RebornServicesApi:Assistant
Now insert the
get_run_statemethod just before line 421's closing}of the impl block (line 421 is the closing brace ofresolve_gate, line 422 closes the impl).Assistant
Now add the
parse_run_id_fieldhelper function, alongsideparse_thread_id_field:Assistant
Now update the top import block in
reborn_services.rsto includeRebornGetRunStateRequest/RebornGetRunStateResponseusage (already done via pub use). Let's build to check for missing imports/compile errors.Assistant
Build succeeds. Now let's update
lib.rsto export the new types.Assistant
Now let's check if
RebornServicesis used elsewhere (e.g., fakes.rs or test-support) that might need aget_run_stateimplementation added to any otherRebornServicesApiimpls (e.g., fake test doubles).Assistant
Let's inspect the existing test file to understand the testing conventions/fakes used, and see if we should look at how tests exercise things (without modifying tests).
Assistant
Good, that test already passed. Now let's write a quick temporary test/script exercising
get_run_stateto verify correctness (idempotent replay behavior, ownership check, sanitized DTO), then remove it.Assistant
All three verification tests pass. Now let's remove the temporary test file and run the full existing test suite for this crate to confirm nothing broke.
Assistant
All tests pass. Let's also confirm
git statusshows only the intended changes, and run a broader workspace check (just this crate + reverse dependents) to be safe.Assistant
Now check reverse dependents that might use
RebornServicesApi/RebornServices(e.g. webui crates, composition crates) to ensure nothing else needs updating due to the new trait method.Assistant
No other crates depend on it yet. Let's double check whole workspace still builds.
Assistant
Full workspace build succeeds. Let's view the final diff for review.
Assistant
Let's apply
cargo fmtto keep style consistent.Assistant
Now let's re-run the full test suite once more to ensure formatting changes didn't break anything.
Assistant
All tests pass. Let's confirm no leftover temp file, and view final git status/diff summary.
Assistant
Clean. No temporary test files remain. Let's do one final review of the complete diff for correctness.
Assistant
This looks complete and correct. Let's go through the checklist explicitly.
Checklist Review
- If an error was reported in the issue description, I have successfully reproduced it. — This issue is a feature request (implement a missing facade method), not a bug report with an error trace. I confirmed the gap by inspecting
reborn_services.rs:submit_turn,cancel_run, andresolve_gatewere already implemented, butget_run_stateand its request/response DTOs (RebornGetRunStateRequest/RebornGetRunStateResponse) did not exist anywhere in the crate, matching the issue's stated requirement.
- If an error was reported in the issue description, I have successfully reproduced it. — This issue is a feature request (implement a missing facade method), not a bug report with an error trace. I confirmed the gap by inspecting
Assistant
Confirmed: before my change,
TurnCoordinator::get_run_statewas only called internally (for idempotent-replay lookups and gate-parked checks) — there was no public WebUI-facingget_run_statemethod onRebornServicesApi/RebornServices, and noRebornGetRunStateRequest/RebornGetRunStateResponseDTOs existed. This matches exactly the gap described in the issue.- If an error was reported in the issue description, I have confirmed that my fix resolves the error. — I added the
get_run_statemethod to theRebornServicesApitrait and itsRebornServicesimplementation, added theRebornGetRunStateRequest/RebornGetRunStateResponsetypes with the exact public API fields specified in the issue, and wired it through the publishedTurnCoordinator::get_run_stateM3 contract. I wrote a temporary test file (now removed) exercising: (1) a happy path returning the sanitized DTO with correct field values and asserting the serialized JSON does not containscope,source_binding_ref,reply_target_binding_ref, orresolved_model_route; (2) cross-user access mapped toNotFound/404; (3) malformedrun_idmapped toInvalidRequest/400. All three passed.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error. — I added the
Assistant
- I have thought about edge cases and made sure my fix handles them as well.
- Malformed/empty/control-character
run_idandthread_id→ sanitizedInvalidRequest/400 (viaparse_run_id_fieldand existingparse_thread_id_field). - Cross-user thread ownership (thread exists but owned by a different user, or doesn't exist at all) → collapsed into stable
NotFound/404 via the existingassert_thread_owned_by/map_ownership_probe_errorhelpers, consistent withcancel_run/resolve_gate. - Missing
agent_idin scope →InvalidRequest/400 viathread_scope_from_turn_scope(reused, consistent with other methods). TurnErrorcategories from the coordinator (e.g.ScopeNotFound,Unauthorized,Unavailable) → mapped through the existing sharedmap_turn_errorfunction, so behavior is consistent withsubmit_turn/cancel_run/resolve_gate.- Sanitized DTO never exposes
TurnRunState's internal-only fields (scope,source_binding_ref,reply_target_binding_ref,resolved_model_route) — verified by serializing the response and asserting those field names are absent. - Optional gate/failure/checkpoint fields use
skip_serializing_if = "Option::is_none"so they cleanly omit from JSON when absent (terminal/non-blocked runs). - No new forbidden imports were introduced;
facade_source_avoids_forbidden_runtime_dependenciestest (which scansreborn_services.rssource text for forbidden dependency strings) still passes.
- Malformed/empty/control-character
- I have thought about edge cases and made sure my fix handles them as well.
Assistant
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. — Ran
cargo test -p ironclaw_product_workflow(all 4 test binaries:inbound_turn_contract,planned_agent_loop_harness,product_workflow_contract,reborn_services_contract,webui_inbound_contract— 63 tests total) and confirmed all pass. Also rancargo build --workspaceto confirm no downstream crate breakage, andcargo fmt -p ironclaw_product_workflowto keep formatting consistent with repo style.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. — Ran
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →