Skip to content
TheChatArchiveThe Chat Archive
x-ai/grok-4.5· unknownHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION Treat OpenAPI path parameters as required in v4 import This tracks…

  1. User

    ISSUE DESCRIPTION

    Treat OpenAPI path parameters as required in v4 import This tracks unresolved feedback identified by cubic on PR #1149: https://github.com/withcoral/coral/pull/1149#discussion_r3347190640

    Context: This appears to be pre-existing DSL v4 behavior surfaced by the refactor review, not a regression from the module split.

    Problem: OpenAPI path parameters are imported as optional when required is omitted, even though path parameters are required by OpenAPI. This can misclassify required path inputs as optional SQL filters.

    Acceptance criteria: Import path parameters as required regardless of an omitted required field, preserve explicit behavior for non-path parameters, and add focused importer/projection coverage.

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /coral, current file: none) bash-$

  2. Assistant

    I'll start by exploring the repository structure and locating the OpenAPI importer logic related to path parameters.

  3. Assistant

    Let me search for OpenAPI import related code for path parameters.

  4. Assistant

    rg is not available, I'll use grep instead.

  5. Assistant

    There's a v4 openapi module. Let me look at the openapi importer code.

  6. Assistant

    Found the path-parameter import logic — I'll inspect operations.rs next.

  7. Assistant

    Let me read the rest of the import_parameters function.

  8. Assistant

    The default for required is the issue — I'll inspect tests and location handling next.

  9. Assistant

    I'll examine the openapi and projection test patterns so I can add coverage correctly.

  10. Assistant

    Checking PR context and how projections use required on path inputs.

  11. Assistant

    I'll fix the path-parameter required default, then add importer and projection tests.

  12. Assistant

    Updating the importer logic and adding focused tests.

  13. Assistant

    I need to navigate to the right place first.

  14. Assistant

    Now I can apply the replace.

  15. Assistant

    Adding importer and projection tests next.

  16. Assistant

    I need to open the openapi_tests file first.

  17. Assistant

    I'll add the test after the defaults test.

  18. Assistant

    Next I'll add a projection test covering path parameters without an explicit required field.

  19. Assistant

    I'll add a projection test at the end that:

  20. Assistant

    Checking whether OpenApiParameterLocation implements Copy/PartialEq and verifying test module wiring.

  21. Assistant

    Running the new importer and projection tests now.

  22. Assistant

    cargo test only accepts one filter. Let me use a broader filter.

  23. Assistant

    Both new tests passed. Running the broader OpenAPI and projection suites next.

  24. Assistant

    All v4 tests passed. Reviewing the final diff before submit.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.