ISSUE DESCRIPTION Treat OpenAPI path parameters as required in v4 import This tracks…
- User
ISSUE DESCRIPTION
Treat OpenAPI path parameters as required in v4 import This tracks unresolved feedback identified by cubic on PR #1149: https://github.com/withcoral/coral/pull/1149#discussion_r3347190640
Context: This appears to be pre-existing DSL v4 behavior surfaced by the refactor review, not a regression from the module split.
Problem: OpenAPI path parameters are imported as optional when
requiredis omitted, even though path parameters are required by OpenAPI. This can misclassify required path inputs as optional SQL filters.Acceptance criteria: Import path parameters as required regardless of an omitted
requiredfield, preserve explicit behavior for non-path parameters, and add focused importer/projection coverage.Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /coral, current file: none) bash-$
- Assistant
I'll start by exploring the repository structure and locating the OpenAPI importer logic related to path parameters.
- Assistant
Let me search for OpenAPI import related code for path parameters.
- Assistant
rg is not available, I'll use grep instead.
- Assistant
There's a v4 openapi module. Let me look at the openapi importer code.
- Assistant
Found the path-parameter import logic — I'll inspect
operations.rsnext. - Assistant
Let me read the rest of the import_parameters function.
- Assistant
The default for
requiredis the issue — I'll inspect tests and location handling next. - Assistant
I'll examine the openapi and projection test patterns so I can add coverage correctly.
- Assistant
Checking PR context and how projections use
requiredon path inputs. - Assistant
I'll fix the path-parameter required default, then add importer and projection tests.
- Assistant
Updating the importer logic and adding focused tests.
- Assistant
I need to navigate to the right place first.
- Assistant
Now I can apply the replace.
- Assistant
Adding importer and projection tests next.
- Assistant
I need to open the openapi_tests file first.
- Assistant
I'll add the test after the defaults test.
- Assistant
Next I'll add a projection test covering path parameters without an explicit
requiredfield. - Assistant
I'll add a projection test at the end that:
- Assistant
Checking whether
OpenApiParameterLocationimplementsCopy/PartialEqand verifying test module wiring. - Assistant
Running the new importer and projection tests now.
- Assistant
cargo test only accepts one filter. Let me use a broader filter.
- Assistant
Both new tests passed. Running the broader OpenAPI and projection suites next.
- Assistant
All v4 tests passed. Reviewing the final diff before submit.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →