ISSUE DESCRIPTION Treat OpenAPI path parameters as required in v4 import This tracks…
- User
ISSUE DESCRIPTION
Treat OpenAPI path parameters as required in v4 import This tracks unresolved feedback identified by cubic on PR #1149: https://github.com/withcoral/coral/pull/1149#discussion_r3347190640
Context: This appears to be pre-existing DSL v4 behavior surfaced by the refactor review, not a regression from the module split.
Problem: OpenAPI path parameters are imported as optional when
requiredis omitted, even though path parameters are required by OpenAPI. This can misclassify required path inputs as optional SQL filters.Acceptance criteria: Import path parameters as required regardless of an omitted
requiredfield, preserve explicit behavior for non-path parameters, and add focused importer/projection coverage.Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /coral, current file: none) bash-$
Assistant
Now let's update the required logic in operations.rs:
Assistant
Let me simplify this properly since the
|| truelogic was confusing/wrong:Assistant
Now let's check that OpenApiParameterLocation derives PartialEq (needed for
==).Assistant
Good, PartialEq is derived. Now let's build to check compile correctness.
Assistant
Compiles. Now let's check existing tests around this area (openapi_tests.rs, projection_tests.rs) to understand test conventions and add coverage.
Assistant
Let's look at how
IrOperationInput.requiredis checked in existing tests, and find projection_tests.rs conventions for filters (required -> filters).Assistant
Now let's write a test in openapi_tests.rs for the importer (path param with omitted required), and one in projection_tests.rs for projection coverage (table function with required filter).
Assistant
Now let's append a new test for path parameter required override.
Assistant
Now let's add projection coverage. Let's look at projection_tests.rs structure near line 191-236 for a similar test.
Assistant
Now let's write the projection test appended to projection_tests.rs.
Assistant
Now check if
SourceTableFunctionKindis imported in projection_tests.rs.Assistant
Let's just build the tests to see if compile passes.
Assistant
All new and existing tests pass. Now let's run the full test suite for coral-spec to make sure nothing else broke.
Assistant
All 221 tests pass. Now let's check the referenced PR discussion context to see if there's anything else related, like the CLI e2e test referencing openapi.
Assistant
Not directly related. Let's also check other places that might independently determine "required" for path parameters, e.g. in schema.rs or documents.rs, to ensure consistency (in case there's duplicate logic elsewhere, like for MCP surfaces don't apply since OpenAPI-specific).
Assistant
This confirms our fix is localized appropriately in the importer. Let's view the full diff for final review.
Assistant
The diff looks clean and focused. Let's also run clippy to make sure no lint issues introduced.
Assistant
No clippy warnings. Now let's format the code with rustfmt for consistency.
Assistant
Formatting didn't change anything unexpected. Let's finalize by re-running full test suite once more.
Assistant
All 221 tests pass. Let's review the checklist:
Assistant
Checklist review:
-
If an error was reported in the issue description, I have successfully reproduced it. — The issue described a behavioral misclassification (not a crash/error). I reproduced it by writing a test (
importer_treats_path_parameters_as_required_even_when_omitted) that failed prior to the fix (path parameter withoutrequiredwas imported asrequired: false), confirming the described bug existed inimport_parametersinoperations.rs. -
If an error was reported in the issue description, I have confirmed that my fix resolves the error. — After changing the
requiredcomputation inoperations.rsto forcetrueforOpenApiParameterLocation::Pathregardless of the OpenAPIrequiredfield, both the importer test and the projection test (verifying it correctly promotes a singleton GET operation into aTableFunctionwith a required filter) pass. -
I have thought about edge cases and made sure my fix handles them as well. — Handled: (1) path parameters with
required: falseexplicitly (spec-violating but still forced totrue, matching OpenAPI semantics that path params are always required); (2) non-path parameters (query) continue to default tofalsewhen omitted, explicittrue/falsepreserved — verified via theverbosequery parameter assertion in the importer test; (3) downstream projection generation (table vs. table-function classification, SQL filter requiredness) verified via the projection test, since that's the "misclassified as optional SQL filters" concern raised in the issue. -
I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. — Ran full
cargo test -p coral-spec(221 tests + doctests), all passing, pluscargo clippy -p coral-spec --all-targetswith no warnings, andcargo fmtto ensure style compliance.
-
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →