Skip to content
TheChatArchiveThe Chat Archive
x-ai/grok-4.5· unknownHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION [PRO]: unsetAllMarks deletes comments Affected Packages…

  1. User

    ISSUE DESCRIPTION

    [PRO]: unsetAllMarks deletes comments

    Affected Packages

    extension-comments

    Version(s)

    2.17.5

    Description of the Bug

    Our Tiptap editor has a "clear formatting" button that calls unsetAllMarks to remove formatting from the selection.

    We noticed, however, that if the selection includes content associated with a comment, the comment is also deleted (presumably because the <span> element wrapping the content is removed).

    Is this a bug? I can see how we might want unsetAllMarks to include comments, if we consider the comment tag a "mark," but at the same time I imagine users would generally not expect unsetAllMarks to delete comments.

    For now, as a workaround, we are calling unsetMark separately for all non-comment marks, e.g.

    editor.chain().focus().unsetMark('link').unsetMark('bold').unsetMark('strike') ...
    

    ... but would be nice to be able to use unsetAllMarks again for formatting-specific marks. Thanks!

    Browser Used

    Chrome

    Code Example (Preferred)

    No response

    Expected Behavior

    unsetAllMarks will remove formatting marks (listed here) but not remove comment tags or comments.

    Additional Context (Optional)

    No response

    Dependency Updates

    • Yes, I've updated all my dependencies.

    Evaluation contract

    Marks are clearable by default. A mark configured with clearable: false must survive unsetAllMarks(), while unsetAllMarks({ignoreClearable: true}) removes it. Calling can().unsetAllMarks() on a selection containing only non-clearable marks is a successful no-op and must return true; explicitly calling unsetMark may still remove a non-clearable mark.

    Interface

    Type: Mark configuration option Name: MarkConfig.clearable Path: packages/core/src/Mark.ts Type: boolean | (() => boolean) Default: true Description: Controls whether unsetAllMarks removes this mark. Set false for semantic marks such as comments that must survive clear-formatting operations.

    Type: Command Name: unsetAllMarks Path: packages/core/src/commands/unsetAllMarks.ts Input: options?: { ignoreClearable?: boolean } Output: ReturnType Description: Removes clearable marks from the current selection. Marks configured with clearable: false are preserved unless ignoreClearable is true. can().unsetAllMarks() returns true when the selection contains only non-clearable marks; this case is a successful no-op.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /tiptap, current file: none) bash-$

  2. Assistant

    I'll explore the repository structure and the relevant mark/unsetAllMarks code to implement the clearable option.

  3. Assistant

    Let me look at the Mark.ts, unsetAllMarks.ts, and comments extension.

  4. Assistant

    Let me continue reading Mark.ts and find comments extension, types, etc.

  5. Assistant

    Checking how other mark options like keepOnSplit are resolved, and looking for related tests or docs.

  6. Assistant

    I'll inspect how commands access the editor/extensions and how similar mark options are evaluated.

  7. Assistant

    Looking at how marks are filtered elsewhere and for comment extensions or recent related changes.

  8. Assistant

    Inspecting ExtensionManager and similar patterns for filtering marks.

  9. Assistant

    Searching for the comments extension and reviewing how related packages are structured.

  10. Assistant

    Implementing the clearable config and updating unsetAllMarks. Checking exports and nearby mark-option docs/style.

  11. Assistant

    Let me implement the changes. I'll also check how getExtensionField works with boolean fields - for keepOnSplit, they use: I understand the issue you're describing with unsetAllMarks and comments. The current behavior is indeed a bug, and your proposed workaround makes sense.

    Let me think through the implementation:

    1. We need to modify unsetAllMarks to respect the clearable option on marks
    2. Comments should have clearable: false by default (as per the evaluation contract)
    3. The ignoreClearable option should still allow clearing non-clearable marks when explicitly requested

    Here's the updated implementation:

    import { getExtensionField } from '../helpers/getExtensionField.
    
  12. Assistant

    Implementing clearable on Mark and updating unsetAllMarks.

  13. Assistant

    Fixing spacing and updating unsetAllMarks.

  14. Assistant

    I accidentally broke the Inclusive comment — fixing that now.

  15. Assistant

    Restoring Mark.ts from git and reapplying the change carefully.

  16. Assistant

    I'll use replace for better precision.

  17. Assistant

    Fixing the incomplete import in unsetAllMarks.ts.

  18. Assistant

    Checking test patterns and writing a verification script.

  19. Assistant

    Checking how packages resolve for local testing, and building a temporary verification script.

  20. Assistant

    Creating a temporary verification script outside the packages tree.

  21. Assistant

    Trying another way to run the verification script:

  22. Assistant

    Investigating the Node/glibc environment issue.

  23. Assistant

    Unsetting the bad LD_LIBRARY_PATH and re-running the test.

  24. Assistant

    Running the script via tsx/vite-node instead of Vitest.

  25. Assistant

    Placing a temporary Vitest file under packages and running it.

  26. Assistant

    All behavioral checks passed. Cleaning up the temp test and verifying formatting.

  27. Assistant

    Running unit tests and a quick lint check on the changed files.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.