Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-sonnet-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION [PRO]: unsetAllMarks deletes comments Affected Packages…

  1. User

    ISSUE DESCRIPTION

    [PRO]: unsetAllMarks deletes comments

    Affected Packages

    extension-comments

    Version(s)

    2.17.5

    Description of the Bug

    Our Tiptap editor has a "clear formatting" button that calls unsetAllMarks to remove formatting from the selection.

    We noticed, however, that if the selection includes content associated with a comment, the comment is also deleted (presumably because the <span> element wrapping the content is removed).

    Is this a bug? I can see how we might want unsetAllMarks to include comments, if we consider the comment tag a "mark," but at the same time I imagine users would generally not expect unsetAllMarks to delete comments.

    For now, as a workaround, we are calling unsetMark separately for all non-comment marks, e.g.

    editor.chain().focus().unsetMark('link').unsetMark('bold').unsetMark('strike') ...
    

    ... but would be nice to be able to use unsetAllMarks again for formatting-specific marks. Thanks!

    Browser Used

    Chrome

    Code Example (Preferred)

    No response

    Expected Behavior

    unsetAllMarks will remove formatting marks (listed here) but not remove comment tags or comments.

    Additional Context (Optional)

    No response

    Dependency Updates

    • Yes, I've updated all my dependencies.

    Evaluation contract

    Marks are clearable by default. A mark configured with clearable: false must survive unsetAllMarks(), while unsetAllMarks({ignoreClearable: true}) removes it. Calling can().unsetAllMarks() on a selection containing only non-clearable marks is a successful no-op and must return true; explicitly calling unsetMark may still remove a non-clearable mark.

    Interface

    Type: Mark configuration option Name: MarkConfig.clearable Path: packages/core/src/Mark.ts Type: boolean | (() => boolean) Default: true Description: Controls whether unsetAllMarks removes this mark. Set false for semantic marks such as comments that must survive clear-formatting operations.

    Type: Command Name: unsetAllMarks Path: packages/core/src/commands/unsetAllMarks.ts Input: options?: { ignoreClearable?: boolean } Output: ReturnType Description: Removes clearable marks from the current selection. Marks configured with clearable: false are preserved unless ignoreClearable is true. can().unsetAllMarks() returns true when the selection contains only non-clearable marks; this case is a successful no-op.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /tiptap, current file: none) bash-$

  2. Claude Assistant

    Good, commands have access to editor via CommandProps. Let's check CommandProps type.

  3. Claude Assistant

    Now add the clearableMarks property declaration next to splittableMarks.

  4. Claude Assistant

    Now let's add clearable field to MarkConfig type.

  5. Claude Assistant

    Now let's update the unsetAllMarks command to use clearableMarks from extensionManager.

  6. Claude Assistant

    Good, this derives from Commands<ReturnType> interface declared via module augmentation in unsetAllMarks.ts itself. Now let's rewrite the command file.

  7. Claude Assistant

    Now let's set clearable: false on the comment mark in extension-comments package.

  8. Claude Assistant

    Let's write a quick reproduce script to test with vitest environment set up already in repo.

  9. Claude Assistant

    Let's create a temp test file to validate our fix manually using vitest.

  10. Claude Assistant

    All 4 tests pass. Now let's remove temp test file and run existing tests for the core package plus related ones (can.spec.ts, unsetMark, etc.)

  11. Claude Assistant

    All 377 tests pass. Now let's run broader test suite quickly for related packages (extension-bold, marks) and check type checking compiles.

  12. Claude Assistant

    All 1064 tests pass across all packages. Now let's typecheck the core package to make sure our TS types compile fine.

  13. Claude Assistant

    No errors specific to packages/core/src. Let's also try building via tsup to be safe.

  14. Claude Assistant

    Build succeeds. Now let's double check git diff to review all changes cleanly.

  15. Claude Assistant

    Good, that's consistent with existing pattern. Now let's also add a changeset entry, following repo conventions.

  16. Claude Assistant

    Now let's run the full test suite once more to confirm nothing broke, plus lint check on the changed files.

  17. Claude Assistant

    All tests pass. Let's do a final review of the diff and finalize.

  18. Claude Assistant

    This looks complete. Let's go through the checklist:

  19. Claude Assistant

    The implementation is complete. Let me do one final check to make sure the working directory is clean of any leftover temp files.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.