Skip to content
TheChatArchiveThe Chat Archive
x-ai/grok-4.5· unknownHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION [PRO]: unsetAllMarks deletes comments Affected Packages…

  1. User

    ISSUE DESCRIPTION

    [PRO]: unsetAllMarks deletes comments

    Affected Packages

    extension-comments

    Version(s)

    2.17.5

    Description of the Bug

    Our Tiptap editor has a "clear formatting" button that calls unsetAllMarks to remove formatting from the selection.

    We noticed, however, that if the selection includes content associated with a comment, the comment is also deleted (presumably because the <span> element wrapping the content is removed).

    Is this a bug? I can see how we might want unsetAllMarks to include comments, if we consider the comment tag a "mark," but at the same time I imagine users would generally not expect unsetAllMarks to delete comments.

    For now, as a workaround, we are calling unsetMark separately for all non-comment marks, e.g.

    editor.chain().focus().unsetMark('link').unsetMark('bold').unsetMark('strike') ...
    

    ... but would be nice to be able to use unsetAllMarks again for formatting-specific marks. Thanks!

    Browser Used

    Chrome

    Code Example (Preferred)

    No response

    Expected Behavior

    unsetAllMarks will remove formatting marks (listed here) but not remove comment tags or comments.

    Additional Context (Optional)

    No response

    Dependency Updates

    • Yes, I've updated all my dependencies.

    Evaluation contract

    Marks are clearable by default. A mark configured with clearable: false must survive unsetAllMarks(), while unsetAllMarks({ignoreClearable: true}) removes it. Calling can().unsetAllMarks() on a selection containing only non-clearable marks is a successful no-op and must return true; explicitly calling unsetMark may still remove a non-clearable mark.

    Interface

    Type: Mark configuration option Name: MarkConfig.clearable Path: packages/core/src/Mark.ts Type: boolean | (() => boolean) Default: true Description: Controls whether unsetAllMarks removes this mark. Set false for semantic marks such as comments that must survive clear-formatting operations.

    Type: Command Name: unsetAllMarks Path: packages/core/src/commands/unsetAllMarks.ts Input: options?: { ignoreClearable?: boolean } Output: ReturnType Description: Removes clearable marks from the current selection. Marks configured with clearable: false are preserved unless ignoreClearable is true. can().unsetAllMarks() returns true when the selection contains only non-clearable marks; this case is a successful no-op.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /tiptap, current file: none) bash-$

  2. Assistant

    I'll explore the repository structure and the relevant files for marks and unsetAllMarks.

  3. Assistant

    Next I'll inspect unsetAllMarks, Mark.ts, and the comments package.

  4. Assistant

    I'll locate the comments extension and see how marks are registered in the schema.

  5. Assistant

    There's no extension-comments in the open source repo, maybe it's in a private package. Looking at the issue evaluation contract:

  6. Assistant

    I'll check how commands receive the editor and how other commands filter marks.

  7. Assistant

    Let me look at how extensions store config and how we accessible extension by mark name. Also check if there's any existing PR/diff or changelog mentioning this.

  8. Assistant

    I'll also check callOrReturn and look for any comments-related mark code.

  9. Assistant

    Checking how to run unit tests and any existing patterns for command tests.

  10. Assistant

    I'll look at existing command/mark tests and index.ts exports.

  11. Assistant

    I'll inspect ExtensionManager for how mark extensions are exposed.

  12. Assistant

    Checking recent history and whether dist artifacts need updating.

  13. Assistant

    There's prior "clearable" work on text style — I'll check that commit and related APIs.

  14. Assistant

    Checking mark setup and how exitable is stored for similar optional fields.

  15. Assistant

    Implementing clearable on Mark and updating unsetAllMarks.

  16. Assistant

    I'll add clearable after keepOnSplit or after exitable.

  17. Assistant

    I'll insert a blank line for consistency and update unsetAllMarks.

  18. Assistant

    I need to restore the Inclusive comment that was removed.

  19. Assistant

    Fixing the Inclusive JSDoc and writing unsetAllMarks.ts correctly.

  20. Assistant

    Confirming the extension has a storage field and cleaning up the implementation.

  21. Assistant

    I'll refine the implementation and run a quick verification test.

  22. Assistant

    Fixing the typo in the options assignment.

  23. Assistant

    I'll write a temporary script to verify the behavior end-to-end.

  24. Assistant

    I'll run the test via vitest from the packages directory.

  25. Assistant

    Retrying the unit test with a longer wait for vitest.

  26. Assistant

    Verification passed. Cleaning up the temp test and running related unit tests.

  27. Assistant

    I'll run the linter and formatter on the changed files.

  28. Assistant

    Confirming extension.storage exists and is initialized.

  29. Assistant

    I'll use editor.extensionStorage for consistency with the rest of the codebase.

  30. Assistant

    Running a final quick verification, then submitting.

  31. Assistant

    Removing the temporary test and submitting the fix.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.