ISSUE DESCRIPTION [Reborn WebUI Beta] Implement the RebornServices submit, cancel,…
- User
ISSUE DESCRIPTION
[Reborn WebUI Beta] Implement the RebornServices submit, cancel, resolve-gate, and run-state facade methods
Parent tracker: #3607 Module: M2 — Native Product Workflow / Inbound Facade Priority: P0
Provide one stable facade that WebUI routes can use to submit turns, cancel runs, resolve gates, and read current run state without importing TurnCoordinator, HostRuntime, dispatchers, run-state stores, or database stores.
The facade must call TurnCoordinator only through the published M3 contract, enforce authenticated thread ownership, validate identifiers and token fields, preserve idempotent replay behavior, map canonical requests correctly, and return sanitized M2 errors.
get_run_stateis required. It must return a stable WebUI DTO containing the run ID, status, event cursor, accepted message reference, resolved run-profile ID and version, and optional gate, failure, and checkpoint data. It must not expose internal scopes, binding references, model routes, or raw internal failures.Evaluation contract
The facade must implement submit, cancel, gate resolution, and
get_run_statethrough the published turn facade without importing forbidden runtime/store dependencies. Validate UUIDs, non-empty client action and credential references, and reject control characters in token fields. Enforce authenticated thread ownership and hide cross-user existence as stableNotFound/HTTP 404 responses; malformed requests use stable sanitizedInvalidRequest/HTTP 400 responses. Preserve idempotent replay and canonical request mappings.get_run_statemust return the documented sanitized DTO, including cursor, accepted-message, resolved-profile, gate, failure, and checkpoint fields, without exposing M3 scopes, binding references, routes, or raw failures.Interface
Type: Struct Name: RebornGetRunStateRequest Path: crates/ironclaw_product_workflow/src/reborn_services/types.rs Public API: pub thread_id: String, pub run_id: String Description: WebUI request identifying the owned thread and run whose current state must be returned.
Type: Struct Name: RebornGetRunStateResponse Path: crates/ironclaw_product_workflow/src/reborn_services/types.rs Public API: run_id, status, event_cursor, accepted_message_ref, resolved_run_profile_id, resolved_run_profile_version, gate_ref, failure, checkpoint_id Description: Stable sanitized WebUI DTO for the current run state. It must not expose internal turn scope, binding references, or model-routing details.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /ironclaw, current file: none) bash-$
- Assistant
I'll start by exploring the repository structure and the existing reborn_services module to understand what's already implemented and what needs to be added.
- Assistant
Next I'll inspect the reborn_services sources and contract tests to see the expected facade surface.
- Assistant
I'll read the full facade implementation and contract tests next.
- Assistant
I'll capture the rest of the facade and the full contract test contents.
- Assistant
I'll inspect turn run-state types and the rest of the helper functions next.
- Assistant
Let me search for GetRunState in ironclaw_turns
- Assistant
Let me look at TurnRunState and GetRunStateRequest definitions, and also look for any documentation or ISSUE specs about RebornGetRunState.
- Assistant
I'll read TurnRunState fully and the FakeTurnCoordinator setup in the contract tests.
- Assistant
I'll look for design docs and any existing stubs around get_run_state.
- Assistant
I'll hunt for ticket/plan notes about issue 3607 and the evaluation DTO contract.
- Assistant
I'll run the existing reborn_services contract tests to establish a baseline, then implement the missing get_run_state pieces.
- Assistant
Need to set up rustup
- Assistant
Good, now let me run the tests.
- Assistant
I'll check the related ID types and how similar responses are shaped before adding get_run_state.
- Assistant
I'll fix paths after realizing we're already under the product_workflow crate.
- Assistant
I'll inspect ThreadId validation and webui helper exports so I can mirror the same rules.
- Assistant
I'll add the get_run_state request/response types and wire the facade method through.
- Assistant
I'll clean up the duplicate import and add the new request/response types.
- Assistant
I'll rewrite types.rs cleanly with the full set of structs.
- Assistant
I'll fix the broken doc comment on the response type.
- Assistant
The last edit mangled the struct header;I'll rewrite it cleanly.
- Assistant
Next I'll wire get_run_state into the trait, exports, and implementation.
- Assistant
I'll open the facade source and apply the export patch from there.
- Assistant
I'll add the trait method and its implementation next.
- Assistant
I'll insert the get_run_state implementation right after resolve_gate.
- Assistant
I'll insert get_run_state before the impl block closes.
- Assistant
I'll add
parse_run_id_fieldnext to the existing ID parsers and update the ownership docs. - Assistant
I'll jump to the helper section and apply the parser update there.
- Assistant
Update ownership comment and lib.rs exports.
- Assistant
lib.rs was updated. Need to fix the comment in reborn_services.rs
- Assistant
I'll confirm RunProfileId exposes as_str, then compile to verify.
- Assistant
I'll add a temporary verification script to exercise get_run_state edge cases, run it, then remove it.
- Assistant
I'll fix the temporary test compile errors and re-run.
- Assistant
I'll rewrite the temporary test the same maze way to clear the derive mess.
- Assistant
Temp tests passed; I'll remove them and re-run the published contract suite.
- Assistant
I'll quickly confirm caller helpers are available and review the final implementation.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →