ISSUE DESCRIPTION [Reborn WebUI Beta] Implement the RebornServices submit, cancel,…
- User
ISSUE DESCRIPTION
[Reborn WebUI Beta] Implement the RebornServices submit, cancel, resolve-gate, and run-state facade methods
Parent tracker: #3607 Module: M2 — Native Product Workflow / Inbound Facade Priority: P0
Provide one stable facade that WebUI routes can use to submit turns, cancel runs, resolve gates, and read current run state without importing TurnCoordinator, HostRuntime, dispatchers, run-state stores, or database stores.
The facade must call TurnCoordinator only through the published M3 contract, enforce authenticated thread ownership, validate identifiers and token fields, preserve idempotent replay behavior, map canonical requests correctly, and return sanitized M2 errors.
get_run_stateis required. It must return a stable WebUI DTO containing the run ID, status, event cursor, accepted message reference, resolved run-profile ID and version, and optional gate, failure, and checkpoint data. It must not expose internal scopes, binding references, model routes, or raw internal failures.Evaluation contract
The facade must implement submit, cancel, gate resolution, and
get_run_statethrough the published turn facade without importing forbidden runtime/store dependencies. Validate UUIDs, non-empty client action and credential references, and reject control characters in token fields. Enforce authenticated thread ownership and hide cross-user existence as stableNotFound/HTTP 404 responses; malformed requests use stable sanitizedInvalidRequest/HTTP 400 responses. Preserve idempotent replay and canonical request mappings.get_run_statemust return the documented sanitized DTO, including cursor, accepted-message, resolved-profile, gate, failure, and checkpoint fields, without exposing M3 scopes, binding references, routes, or raw failures.Interface
Type: Struct Name: RebornGetRunStateRequest Path: crates/ironclaw_product_workflow/src/reborn_services/types.rs Public API: pub thread_id: String, pub run_id: String Description: WebUI request identifying the owned thread and run whose current state must be returned.
Type: Struct Name: RebornGetRunStateResponse Path: crates/ironclaw_product_workflow/src/reborn_services/types.rs Public API: run_id, status, event_cursor, accepted_message_ref, resolved_run_profile_id, resolved_run_profile_version, gate_ref, failure, checkpoint_id Description: Stable sanitized WebUI DTO for the current run state. It must not expose internal turn scope, binding references, or model-routing details.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /ironclaw, current file: none) bash-$
- Assistant
I’ll first map the crate structure and locate the existing RebornServices and published M3 facade contracts. Then I’ll compare current implementation/tests against the required validation, ownership, mapping, and sanitization behavior before making focused changes.
- Assistant
The facade already implements submit/cancel/gate operations and has ownership helpers, but
get_run_stateis absent from its public trait and DTOs. I’ll now inspect the exact existing request mappings and M3TurnRunStatefields so the new method follows the established security and error conventions without leaking internal data. - Assistant
I need the full implementations around cancellation/gate resolution and the canonical state definition. I’ll also inspect inbound request validation to determine whether UUID and token checks already cover all required fields or need strengthening for the new and existing methods.
- Assistant
The existing mutation DTO parsers already canonicalize IDs and token fields; the new read request is specified as concrete strings, so it will need equivalent field-specific validation before ownership probing. I’ll retrieve the canonical state and gate/failure types plus the exact ownership helper behavior to define a strictly sanitized response.
- Assistant
The canonical failure is already sanitized to a category, and blocked state exposes only a gate reference suitable for the WebUI DTO. I’ll inspect the complete state struct and identifier display/accessor APIs, then implement the response conversion explicitly field-by-field (rather than serializing or flattening M3 state), which guarantees scope/bindings/routes cannot leak.
- Assistant
The required field list does not prescribe primitive types, but existing stable DTO conventions use canonical opaque IDs for run/message/gate/checkpoint and strings/u64 for resolved profile metadata. To maximize API consistency and preserve type safety, I’ll use those canonical serializable identifier types while reducing
SanitizedFailureto its public category string. Before editing, I’ll check crate versions/docs for any already documented wire shape or downstream call sites. - Assistant
I’ll add the two public structs, expose them from the module/crate, add
get_run_stateto the facade trait, and implement it in this order: validate thread ID and UUID run ID, derive caller scope, verify thread ownership (collapsing mismatch/not-found to 404), invoke onlyTurnCoordinator::get_run_state, and explicitly map allowed fields. I’ll also improve the shared concrete-string thread parser to reject blank/oversized/control-character tokens consistently with mutation parsing. - Assistant
The code changes are in place; formatting could not run because rustup has no selected default toolchain. I’ll inspect installed toolchains and repository pinning, select an already-installed compatible toolchain if available, then compile the affected contract tests.
- Assistant
No Rust toolchain is installed, and the workspace explicitly requires Rust 1.92. I’ll install that pinned version, format, and run the product-workflow contract target. This is environment setup only and does not modify repository source/tests.
- Assistant
Rust 1.92 installed successfully, but the chained
cargoinvocation hit a wrapper/home mismatch (rustupis installed under a non-default location while Cargo looked under/root/.cargo). I’ll inspect the active paths/environment and invoke the installed binaries with the correct homes explicitly. - Assistant
The environment’s
HOMEis empty, causing the rustup proxy failure. SettingHOME=/rootshould resolve it. I’ll format and run the focused contract tests now. - Assistant
The minimal toolchain omitted
rustfmt; I’ll add that standard component, then rerun formatting and the focused tests. - Assistant
The existing 17 facade contract tests pass. Since the public trait changed, I’ll run the entire
ironclaw_product_workflowpackage test suite to catch any other implementations or downstream assumptions, then inspect the final diff for accidental changes and verify the facade still contains no forbidden runtime/store imports. - Assistant
All 67 package tests pass, formatting is clean, and the facade has no forbidden dependency imports. I’ll do a final API/diff review, paying particular attention to whether rustfmt touched unrelated exports and whether the serialized DTO contains exactly the nine documented fields.
- Assistant
The DTO review confirms only the documented fields are exposed. One adjacent security inconsistency is visible: ownership-sensitive
get_timelineand thread creation/submission calls still use the generic thread error mapper, which mapsThreadScopeMismatchto 409 instead of the required existence-hiding 404. I’ll inspect the in-memory thread service semantics and then apply the ownership-specific mapper wherever a caller-supplied owned thread is probed or established, without changing idempotent conflict handling. - Assistant
The thread backend explicitly emits
ThreadScopeMismatchwhen an existing ID belongs to another scope/owner. I’ll update only initial ownership-sensitive operations (ensure_thread, inbound acceptance, timeline lookup, explicit create) to collapse that error to 404; replay transition errors and post-submit bookkeeping retain their existing conflict semantics. - Assistant
I’ll make those four narrow mapper substitutions and update the ownership-helper comment to include reads. Then I’ll rerun formatting and the focused facade tests; existing tests should remain unchanged because normal and non-ownership conflict paths are unaffected.
- Assistant
The focused suite still passes after the ownership hardening. I’ll perform one final workspace-wide compile check for the public trait change (to catch external implementors), review status/diff summary, and then submit if clean.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →