ISSUE DESCRIPTION Teleport + Suspense: unmount crashes on pending teleport with…
- User
ISSUE DESCRIPTION
Teleport + Suspense: unmount crashes on pending teleport with component child (regression since 3.5.31)
Vue version
3.5.34
Link to minimal reproduction
https://github.com/pont1s/vue-teleport-unmount-crashes
Steps to reproduce
Option 1 — Browser (primary)
pnpm dev- Open the browser DevTools console.
- Click "Unmount Suspense".
- Observe
TypeError: Cannot read properties of null (reading 'type')in the console
Option 2 — Tests (additional)
pnpm testThe repo also contains three Vitest tests in
tests/teleport-unmount.test.jsWhat is expected?
When a inside a is unmounted before its mount can run, Vue should remove it cleanly. This worked correctly in 3.5.30.
What is actually happening?
In 3.5.31..3.5.34, unmounting such a teleport throws:
TypeError: Cannot read properties of null (reading 'type') at unmountComponent (runtime-core.cjs.js) at unmount at Object.remove (TeleportImpl.remove) at unmount at unmountChildren at unmount at unmountComponent at unmount at Object.resolve (Suspense)System Info
System: OS: macOS 26.3.1 CPU: (8) arm64 Apple M1 Memory: 102.19 MB / 16.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 24.15.0 - /Users/user/.local/state/fnm_multishells/14407_1779493498078/bin/node npm: 11.12.1 - /Users/user/.local/state/fnm_multishells/14407_1779493498078/bin/npm pnpm: 11.1.3 - /Users/user/.local/state/fnm_multishells/14407_1779493498078/bin/pnpm Browsers: Chrome: 148.0.7778.179 Safari: 26.3.1 npmPackages: vue: 3.5.34 => 3.5.34Any additional comments?
This is a continuation of the regression chain that started in 3.5.31:
- PR #8619 (3.5.31) introduced
pendingMountsso teleports defer their mount whenparentSuspense.pendingBranchis set. This is what created the situation where a teleport's children can havevnode.component === null. - Issue #14640 + PR #14642 (3.5.32) added the
pendingMountcheck shown above. That gates DOM removal of element children, not theunmountComponent(null, …)call on component children. - Issue #14699 (3.5.32) reported the same crash with the same stack as this issue. Closed by the author with a note about re-filing with a more accurate reproduction.
- Issue #14701 + PR #14702 (3.5.33) added
pendingMounts.has(vnode)guard, but only inmoveTeleport. TheTeleportImpl.removepath was not touched, so 3.5.33 and 3.5.34 still crash.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /core, current file: none) bash-$
Assistant
Let me start by understanding the repository structure and the issue. The issue is about a Teleport component inside a Suspense that crashes when unmounted before its mount can run. The error is:
TypeError: Cannot read properties of null (reading 'type') at unmountComponent (runtime-core.cjs.js) at unmount at Object.remove (TeleportImpl.remove) at unmount at unmountChildren at unmount at unmountComponent at unmount at Object.resolve (Suspense)The problem is that in
TeleportImpl.remove, when unmounting teleport children, some children might havevnode.component === null(because they were pending mounts that never got mounted), and the code tries to callunmountComponenton them without checking for null.Let me explore the repository structure and find the relevant code.
Assistant
This is the Vue.js core repository. Let me find the relevant file - the Teleport implementation.
Assistant
Let's look at the Teleport.ts file, which should contain the TeleportImpl implementation.
Assistant
Now let me look at the
unmountfunction in the renderer to understand the crashAssistant
Let me look at the unmount function and unmountComponent function to understand the crash.
Assistant
Let me use grep to view the relevant lines.
Assistant
Let me look at
unmountComponentto see how it accesses `component.typeAssistant
Now let me see the full
removemethod in Teleport.tsAssistant
Let me see the full remove function.
Assistant
Now I have a clear understanding of the issue. Let me first check if there are existing tests I can look at.
Assistant
Let me first try to run the existing Teleport tests and see if there are any failures.
Assistant
Let me create a reproduction script to confirm the issue
Assistant
Let me run the reproduction script using vitest.
Assistant
Let me create the test inside the proper test directory.
Assistant
Let me run this test to see if it reproduces the crash.
Assistant
The test needs jsdom. Let me look at how other tests handle this and adjust the test.
Assistant
Let me update the repro test with the proper environment directive and imports
Assistant
Now let's run the test again
Assistant
The test passes because Suspense resolves immediately. I need to create a test with an async component that keeps the Suspense in a pending state. Let me look at how Suspense's
pendingBranchAssistant
Let me look at the Suspense code around line 493
Assistant
Let me update the test to properly reproduce the crash with an
Assistant
Let me simplify - use the
deferprop on Teleport instead, which triggers the same codeAssistant
Let me run this test to see if it reproduces the crash
Assistant
Let me understand when the post-render effect runs. Let me check
queuePostRenderEffectAssistant
Let me check line 292 to understand
queuePostRenderEffect:Assistant
Let me check
queueEffectWithSuspenseAssistant
Let me check
queueEffectWithSuspensein scheduler.tsAssistant
Let me search for its definition more broadly
Assistant
Let me look at
queueEffectWithSuspensein Suspense.tsAssistant
Now I understand. Let me create a proper test that reproduces the crash:
Assistant
Let me run this test
Assistant
Let me understand the flow better by examining how
parentSuspenseflows to TeleportAssistant
Let me look at the patch function to understand how
parentSuspenseis determined:Assistant
Let me look at how
processComponentpassesparentSuspenseAssistant
Let me look at `processComponent
Assistant
Let me add some debug logging to understand the flow better
Assistant
I see - my test doesn't have an async component in the Suspense default slot. Let me fix:
Assistant
Let me run this test:
Assistant
Let me look at how the Suspense unmount works
Assistant
Let me look at the Suspense.unmount function at line 780
Assistant
Let me check if
mountChildrenpassesparentSuspensethroughAssistant
Let me find
mountChildrenAssistant
Let me look at
mountChildrenAssistant
Let me add temporary debug logging to verify the flow
Assistant
Let me add debug logging to Teleport.ts temporarily
Assistant
Let me temporarily add debug logs to understand the flow
Assistant
Let me run the test with debug output
Assistant
I see - the children are a slots object, not an array. Let me modify the test to use array children (like a compiled template would
Assistant
Let me run this test
Assistant
I've successfully reproduced the crash. Now let me implement the fix. The issue is in
TeleportImpl.remove- when apendingMountis found, it should skip unmounting children because they were never mounted.Assistant
Now let me look at the exact code to fix in
TeleportImpl.removeAssistant
Now I'll fix the code. The comment says "skip removing children" but the code doesn't actually skip. I need to add a check to skip children unmount when
pendingMountexistsAssistant
Let me open the file
Assistant
Let me try the open command with the proper syntax
Assistant
Now let me make the fix. I need to guard the children unmount loop with a
!pendingMountcheck:Assistant
Let me use the replace command instead
Assistant
Let me use the multi-line syntax for replace
Assistant
Now let me update the comment to reflect the new behavior
Assistant
Now let me run the reproduction test to verify the fix
Assistant
The fix works. Now let me run the existing Teleport tests to make sure nothing is
Assistant
All 51 Teleport tests pass. Let me also run the Suspense tests
Assistant
All tests pass. Let me clean up the temporary test file and verify the final diff
Assistant
Let me verify the final diff
Assistant
The diff is clean. Let me run the full runtime-core test suite to make sure nothing is
Assistant
All 1014 tests pass. Let me verify my checklist:
Checklist
-
✅ Reproducing the error: I successfully reproduced the exact crash from the issue -
TypeError: Cannot read properties of null (reading 'type')atunmountComponentcalled throughTeleportImpl.remove. -
✅ Fix resolves the error: After the fix, the reproduction test passes without any crash.
-
✅ Edge cases considered:
- Teleport with no children: handled by the existing
shapeFlag & ShapeFlags.ARRAY_CHILDRENcheck - Disabled teleport: the
shouldRemovelogic remains unchanged, only children unmount is guarded - Nested teleports: each teleport independently checks its own
pendingMountsentry deferprop without Suspense: the mount job is still stored inpendingMountsand the guard works the same way- The fix mirrors the exact same pattern already used in
moveTeleport(line 397:!pendingMounts.has(vnode)) from PR #14702
- Teleport with no children: handled by the existing
-
✅ Existing tests pass: All 1014 runtime-core tests pass, including all 51 Teleport tests and all 57 Suspense tests.
The fix is minimal and consistent with the existing codebase patterns.
-
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
- xiaomi/mimo-v2.5-proCompare side by side →
- xiaomi/mimo-v2.5-proCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-lunaCompare side by side →
- gpt-5.6-lunaCompare side by side →
- gpt-5.6-lunaCompare side by side →
- gpt-5.6-lunaCompare side by side →