Skip to content
TheChatArchiveThe Chat Archive
gpt-5.6-luna· openaiHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION Teleport + Suspense: unmount crashes on pending teleport with…

  1. User

    ISSUE DESCRIPTION

    Teleport + Suspense: unmount crashes on pending teleport with component child (regression since 3.5.31)

    Vue version

    3.5.34

    Link to minimal reproduction

    https://github.com/pont1s/vue-teleport-unmount-crashes

    Steps to reproduce

    Option 1 — Browser (primary)

    pnpm dev
    
    1. Open the browser DevTools console.
    2. Click "Unmount Suspense".
    3. Observe TypeError: Cannot read properties of null (reading 'type') in the console

    Option 2 — Tests (additional)

    pnpm test
    

    The repo also contains three Vitest tests in tests/teleport-unmount.test.js

    What is expected?

    When a inside a is unmounted before its mount can run, Vue should remove it cleanly. This worked correctly in 3.5.30.

    What is actually happening?

    In 3.5.31..3.5.34, unmounting such a teleport throws:

    TypeError: Cannot read properties of null (reading 'type')
        at unmountComponent       (runtime-core.cjs.js)
        at unmount
        at Object.remove          (TeleportImpl.remove)
        at unmount
        at unmountChildren
        at unmount
        at unmountComponent
        at unmount
        at Object.resolve         (Suspense)
    

    System Info

    System:
        OS: macOS 26.3.1
        CPU: (8) arm64 Apple M1
        Memory: 102.19 MB / 16.00 GB
        Shell: 5.9 - /bin/zsh
      Binaries:
        Node: 24.15.0 - /Users/user/.local/state/fnm_multishells/14407_1779493498078/bin/node
        npm: 11.12.1 - /Users/user/.local/state/fnm_multishells/14407_1779493498078/bin/npm
        pnpm: 11.1.3 - /Users/user/.local/state/fnm_multishells/14407_1779493498078/bin/pnpm
      Browsers:
        Chrome: 148.0.7778.179
        Safari: 26.3.1
      npmPackages:
        vue: 3.5.34 => 3.5.34
    

    Any additional comments?

    This is a continuation of the regression chain that started in 3.5.31:

    • PR #8619 (3.5.31) introduced pendingMounts so teleports defer their mount when parentSuspense.pendingBranch is set. This is what created the situation where a teleport's children can have vnode.component === null.
    • Issue #14640 + PR #14642 (3.5.32) added the pendingMount check shown above. That gates DOM removal of element children, not the unmountComponent(null, …) call on component children.
    • Issue #14699 (3.5.32) reported the same crash with the same stack as this issue. Closed by the author with a note about re-filing with a more accurate reproduction.
    • Issue #14701 + PR #14702 (3.5.33) added pendingMounts.has(vnode) guard, but only in moveTeleport. The TeleportImpl.remove path was not touched, so 3.5.33 and 3.5.34 still crash.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /core, current file: none) bash-$

  2. Assistant

    I’ll trace the Teleport unmount path and the pending-mount bookkeeping, compare nearby history/tests, then make the smallest guarded fix. I’ll reproduce with the repository’s tests (or a focused temporary script if needed), run affected tests, inspect the diff, and submit only after verification.

  3. Assistant

    The code already tracks deferred Teleport mounts and cancels them in both update and remove paths, while moveTeleport has a separate guard. I’m now inspecting the exact remove implementation and renderer unmount ordering, because the crash likely comes from traversing children that were never component-mounted.

  4. Assistant

    The defect is confirmed in source: TeleportImpl.remove detects and cancels a pending mount, but still iterates children. For component children, unmount() unconditionally calls unmountComponent(vnode.component!), and that component is null because the deferred mount never ran. The comment claims children are skipped, but the implementation only changes shouldRemove; I’ll correct that control flow while preserving anchor cleanup and normal unmount behavior.

  5. Assistant

    The first edit attempt was blocked because this environment has no python3; no repository files changed. I’ll apply the one-line condition with the available shell tools, then run the focused Teleport suite.

  6. Assistant

    The intended one-line fix is present and git diff --check is clean. The package-manager command timed out only at Corepack’s interactive download prompt, so I’ll invoke the locally installed Vitest binary directly and then use targeted type/lint checks as appropriate.

  7. Assistant

    The affected Teleport test file passes all 51 tests. The fix also preserves the existing behavior for non-pending Teleports: only the child traversal is skipped when a deferred mount was canceled, while Teleport anchors are still removed and the queued scheduler job is disposed. I’ll run repository checks on the changed file and a typecheck to catch style or typing issues.

  8. Assistant

    Lint, formatting, and the repository TypeScript check all pass. I’ll run the broader runtime-core unit tests once more, then review the final diff/status and submit.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.