ISSUE DESCRIPTION [Bug] Broker may accept duplicate messages after dedup recovery race…
- User
ISSUE DESCRIPTION
[Bug] Broker may accept duplicate messages after dedup recovery race
Issue Description
Message deduplication recovery can be started more than once for the same topic before the first recovery replay completes.
MessageDeduplicationdefines aRecoveringstatus to prevent overlapping transitions, but the enable path starts dedup cursor replay without first changing the status toRecovering.Because of that, another
checkStatus()call can still observeInitializedorDisabledand start a second replay for the same dedup cursor.One practical trigger path is topic load with existing topic-level policies:
Time Flow A: existing topic-level policy during load Flow B: normal topic load chain Dedup status / effect T1 initTopicPolicy()loads existing topic policiesdedup status is InitializedorDisabledT2 onUpdate()applies topic policies and callscheckDeduplicationStatus()first dedup recovery replay starts T3 first replay is still running asynchronously status is still InitializedorDisabledT4 topic load continues and BrokerServiceexplicitly callscheckDeduplicationStatus()T5 second check also enters the enable path second replay starts for the same dedup cursor T6 first replay rebuilds producer sequence state second replay also rebuilds producer sequence state overlapping replay can advance shared replay/cursor state Dedup recovery rebuilds producer sequence information from the dedup cursor. If overlapping replay leaves the recovered sequence state incomplete or inconsistent, the broker may fail to identify already-published messages as duplicates.
The impact is that duplicate messages can be accepted after topic load or policy refresh even though message deduplication is enabled.
There is also a retry gap after recovery failure. If enabling deduplication fails transiently, the status moves to
Failed, but later checks do not retry enabling even when the topic policy still requires deduplication.Error messages
There may be no error message. This is a race in the dedup recovery state machine.
Reproducing the issue
A deterministic unit-level reproduction can be built by delaying the first dedup recovery replay and invoking
checkStatus()again before the first replay completes:- Keep
MessageDeduplicationinInitializedorDisabled. - Call
checkStatus()once and delay async cursor open or replay completion. - Call
checkStatus()again before the first recovery finishes. - Observe that the second call enters the enable path again and starts another replay.
A production-like trigger path is:
- Enable message deduplication.
- Use a topic with existing topic-level policies.
- Load or reload the topic.
- During topic load,
initTopicPolicy()can invokeonUpdate(), which applies topic policies and callscheckDeduplicationStatus(). - The normal topic load chain later calls
checkDeduplicationStatus()again. - If the first recovery replay is still in progress, both checks can start overlapping dedup replay.
Expected behavior
- Deduplication should enter
Recoveringbefore starting recovery replay. - Concurrent status checks should not start another recovery while replay is in progress.
- If enable fails transiently, a later check should retry enabling when deduplication is still required by policy.
Actual behavior
- Enable starts replay while status remains
InitializedorDisabled. - Another
checkStatus()can start a second replay before the first completes. Failedstatus does not retry enable even when deduplication should still be enabled.
Additional information
A fix has been proposed in #25953.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /pulsar, current file: none) bash-$
- Keep
Assistant
Let me start by understanding the repository structure and the issue. The issue is about a race condition in
MessageDeduplicationwhere:- Deduplication enable path starts dedup cursor replay without first changing status to
Recovering - This allows another
checkStatus()call to start a second replay - There's also a gap where
Failedstatus doesn't retry enabling
Let me find the relevant files first.
- Deduplication enable path starts dedup cursor replay without first changing status to
Assistant
Let me look at the main MessageDeduplication.java file first.
Assistant
Let me see the rest of this file, especially the
checkStatus()method and the recovery logic.Assistant
Let me see the full
checkStatus()method and the surrounding logicAssistant
Now I can see the issues clearly. Let me see the rest of the file including `replayCursor
Assistant
Now I have a clear understanding of the issues. Let me also look at the test file for deduplication to understand the existing tests:
Assistant
Let me look at the full checkStatus method more carefully and understand the complete fix needed
Assistant
Now I have a clear understanding of the issues. Let me implement the fixes:
Issue 1: The enable path at line 227 doesn't set
status = Status.Recoveringbefore starting async operations, so anothercheckStatus()call can enter the same path.Issue 2: The
Failedstatus is not included in the enable condition, so transient failures are never retried.Let me make the changes
Assistant
The changes look correct. Let me verify the complete method now
Assistant
The changes look correct. Let me now run the existing tests to make sure the changes don't break anything
Assistant
Let me find the correct module structure
Assistant
Let me explore the repository structure more.
Assistant
It's a Gradle project. Let me try running the test with Gradle.
Assistant
Let me try running the test without the exclusion flags.
Assistant
The tests pass. Let me also run the broker-level deduplication test to make sure nothing is broken.
Assistant
Let me also run the TopicDuplicationTest.
Assistant
All tests pass. Let me verify my changes with
git diffto confirm exactly what was modified:Assistant
The changes look correct. Let me now verify the flow logic one more time by tracing through the complete
checkStatusmethod with my changes:Fix 1 - Race condition: By setting
status = Status.Recovering(line 230) before starting the asyncopenCursor/replayCursoroperations, the guard at line 162 (status == Status.Recovering || status == Status.Removing) will now properly block any concurrentcheckStatus()call from entering the enable path again.Fix 2 - Retry after failure: By adding
status == Status.Failedto the enable condition (line 227), a latercheckStatus()call will retry enabling deduplication when it's still required by policy, instead of staying in the dead-endFailedstate forever.Let me also check if the
replayCursorcorrectly handles settingstatus = Status.Enabledwithout a race:Assistant
The flow is correct. Let me verify the callers of
checkDeduplicationStatusto ensure the fix covers the described scenario:Assistant
The fix correctly addresses the described race condition. Both call sites are confirmed:
PersistentTopic.onUpdate()at line 3880 (Flow A in the issue)BrokerServiceat line 1967 (Flow B in the issue)
With my fix, the first call sets
status = Status.Recoveringunder thesynchronizedblock before starting async operations, so the second call will seeRecoveringand reschedule itself.Now let me submit the fix. But first, let me confirm all changes are correct by reviewing the final state
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
- xiaomi/mimo-v2.5-proCompare side by side →
- xiaomi/mimo-v2.5-proCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →