Skip to content
TheChatArchiveThe Chat Archive
DeepSeekdeepseek/deepseek-v4-pro· deepseekHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION [Bug] Broker may accept duplicate messages after dedup recovery race…

  1. User

    ISSUE DESCRIPTION

    [Bug] Broker may accept duplicate messages after dedup recovery race

    Issue Description

    Message deduplication recovery can be started more than once for the same topic before the first recovery replay completes.

    MessageDeduplication defines a Recovering status to prevent overlapping transitions, but the enable path starts dedup cursor replay without first changing the status to Recovering.

    Because of that, another checkStatus() call can still observe Initialized or Disabled and start a second replay for the same dedup cursor.

    One practical trigger path is topic load with existing topic-level policies:

    TimeFlow A: existing topic-level policy during loadFlow B: normal topic load chainDedup status / effect
    T1initTopicPolicy() loads existing topic policiesdedup status is Initialized or Disabled
    T2onUpdate() applies topic policies and calls checkDeduplicationStatus()first dedup recovery replay starts
    T3first replay is still running asynchronouslystatus is still Initialized or Disabled
    T4topic load continues and BrokerService explicitly calls checkDeduplicationStatus()
    T5second check also enters the enable pathsecond replay starts for the same dedup cursor
    T6first replay rebuilds producer sequence statesecond replay also rebuilds producer sequence stateoverlapping replay can advance shared replay/cursor state

    Dedup recovery rebuilds producer sequence information from the dedup cursor. If overlapping replay leaves the recovered sequence state incomplete or inconsistent, the broker may fail to identify already-published messages as duplicates.

    The impact is that duplicate messages can be accepted after topic load or policy refresh even though message deduplication is enabled.

    There is also a retry gap after recovery failure. If enabling deduplication fails transiently, the status moves to Failed, but later checks do not retry enabling even when the topic policy still requires deduplication.

    Error messages

    There may be no error message. This is a race in the dedup recovery state machine.

    Reproducing the issue

    A deterministic unit-level reproduction can be built by delaying the first dedup recovery replay and invoking checkStatus() again before the first replay completes:

    1. Keep MessageDeduplication in Initialized or Disabled.
    2. Call checkStatus() once and delay async cursor open or replay completion.
    3. Call checkStatus() again before the first recovery finishes.
    4. Observe that the second call enters the enable path again and starts another replay.

    A production-like trigger path is:

    1. Enable message deduplication.
    2. Use a topic with existing topic-level policies.
    3. Load or reload the topic.
    4. During topic load, initTopicPolicy() can invoke onUpdate(), which applies topic policies and calls checkDeduplicationStatus().
    5. The normal topic load chain later calls checkDeduplicationStatus() again.
    6. If the first recovery replay is still in progress, both checks can start overlapping dedup replay.

    Expected behavior

    • Deduplication should enter Recovering before starting recovery replay.
    • Concurrent status checks should not start another recovery while replay is in progress.
    • If enable fails transiently, a later check should retry enabling when deduplication is still required by policy.

    Actual behavior

    • Enable starts replay while status remains Initialized or Disabled.
    • Another checkStatus() can start a second replay before the first completes.
    • Failed status does not retry enable even when deduplication should still be enabled.

    Additional information

    A fix has been proposed in #25953.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /pulsar, current file: none) bash-$

  2. DeepSeek Assistant

    Let me start by understanding the repository structure and the issue. The issue is about a race condition in MessageDeduplication where:

    1. Deduplication enable path starts dedup cursor replay without first changing status to Recovering
    2. This allows another checkStatus() call to start a second replay
    3. There's also a gap where Failed status doesn't retry enabling

    Let me find the relevant files first.

  3. DeepSeek Assistant

    Let me look at the main MessageDeduplication.java file first.

  4. DeepSeek Assistant

    Let me see the rest of this file, especially the checkStatus() method and the recovery logic.

  5. DeepSeek Assistant

    Let me see the full checkStatus() method and the surrounding logic

  6. DeepSeek Assistant

    Now I can see the issues clearly. Let me see the rest of the file including `replayCursor

  7. DeepSeek Assistant

    Now I have a clear understanding of the issues. Let me also look at the test file for deduplication to understand the existing tests:

  8. DeepSeek Assistant

    Let me look at the full checkStatus method more carefully and understand the complete fix needed

  9. DeepSeek Assistant

    Now I have a clear understanding of the issues. Let me implement the fixes:

    Issue 1: The enable path at line 227 doesn't set status = Status.Recovering before starting async operations, so another checkStatus() call can enter the same path.

    Issue 2: The Failed status is not included in the enable condition, so transient failures are never retried.

    Let me make the changes

  10. DeepSeek Assistant

    The changes look correct. Let me verify the complete method now

  11. DeepSeek Assistant

    The changes look correct. Let me now run the existing tests to make sure the changes don't break anything

  12. DeepSeek Assistant

    Let me find the correct module structure

  13. DeepSeek Assistant

    Let me explore the repository structure more.

  14. DeepSeek Assistant

    It's a Gradle project. Let me try running the test with Gradle.

  15. DeepSeek Assistant

    Let me try running the test without the exclusion flags.

  16. DeepSeek Assistant

    The tests pass. Let me also run the broker-level deduplication test to make sure nothing is broken.

  17. DeepSeek Assistant

    Let me also run the TopicDuplicationTest.

  18. DeepSeek Assistant

    All tests pass. Let me verify my changes with git diff to confirm exactly what was modified:

  19. DeepSeek Assistant

    The changes look correct. Let me now verify the flow logic one more time by tracing through the complete checkStatus method with my changes:

    Fix 1 - Race condition: By setting status = Status.Recovering (line 230) before starting the async openCursor/replayCursor operations, the guard at line 162 (status == Status.Recovering || status == Status.Removing) will now properly block any concurrent checkStatus() call from entering the enable path again.

    Fix 2 - Retry after failure: By adding status == Status.Failed to the enable condition (line 227), a later checkStatus() call will retry enabling deduplication when it's still required by policy, instead of staying in the dead-end Failed state forever.

    Let me also check if the replayCursor correctly handles setting status = Status.Enabled without a race:

  20. DeepSeek Assistant

    The flow is correct. Let me verify the callers of checkDeduplicationStatus to ensure the fix covers the described scenario:

  21. DeepSeek Assistant

    The fix correctly addresses the described race condition. Both call sites are confirmed:

    • PersistentTopic.onUpdate() at line 3880 (Flow A in the issue)
    • BrokerService at line 1967 (Flow B in the issue)

    With my fix, the first call sets status = Status.Recovering under the synchronized block before starting async operations, so the second call will see Recovering and reschedule itself.

    Now let me submit the fix. But first, let me confirm all changes are correct by reviewing the final state

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.