ISSUE DESCRIPTION [Bug] Broker may accept duplicate messages after dedup recovery race…
- User
ISSUE DESCRIPTION
[Bug] Broker may accept duplicate messages after dedup recovery race
Issue Description
Message deduplication recovery can be started more than once for the same topic before the first recovery replay completes.
MessageDeduplicationdefines aRecoveringstatus to prevent overlapping transitions, but the enable path starts dedup cursor replay without first changing the status toRecovering.Because of that, another
checkStatus()call can still observeInitializedorDisabledand start a second replay for the same dedup cursor.One practical trigger path is topic load with existing topic-level policies:
Time Flow A: existing topic-level policy during load Flow B: normal topic load chain Dedup status / effect T1 initTopicPolicy()loads existing topic policiesdedup status is InitializedorDisabledT2 onUpdate()applies topic policies and callscheckDeduplicationStatus()first dedup recovery replay starts T3 first replay is still running asynchronously status is still InitializedorDisabledT4 topic load continues and BrokerServiceexplicitly callscheckDeduplicationStatus()T5 second check also enters the enable path second replay starts for the same dedup cursor T6 first replay rebuilds producer sequence state second replay also rebuilds producer sequence state overlapping replay can advance shared replay/cursor state Dedup recovery rebuilds producer sequence information from the dedup cursor. If overlapping replay leaves the recovered sequence state incomplete or inconsistent, the broker may fail to identify already-published messages as duplicates.
The impact is that duplicate messages can be accepted after topic load or policy refresh even though message deduplication is enabled.
There is also a retry gap after recovery failure. If enabling deduplication fails transiently, the status moves to
Failed, but later checks do not retry enabling even when the topic policy still requires deduplication.Error messages
There may be no error message. This is a race in the dedup recovery state machine.
Reproducing the issue
A deterministic unit-level reproduction can be built by delaying the first dedup recovery replay and invoking
checkStatus()again before the first replay completes:- Keep
MessageDeduplicationinInitializedorDisabled. - Call
checkStatus()once and delay async cursor open or replay completion. - Call
checkStatus()again before the first recovery finishes. - Observe that the second call enters the enable path again and starts another replay.
A production-like trigger path is:
- Enable message deduplication.
- Use a topic with existing topic-level policies.
- Load or reload the topic.
- During topic load,
initTopicPolicy()can invokeonUpdate(), which applies topic policies and callscheckDeduplicationStatus(). - The normal topic load chain later calls
checkDeduplicationStatus()again. - If the first recovery replay is still in progress, both checks can start overlapping dedup replay.
Expected behavior
- Deduplication should enter
Recoveringbefore starting recovery replay. - Concurrent status checks should not start another recovery while replay is in progress.
- If enable fails transiently, a later check should retry enabling when deduplication is still required by policy.
Actual behavior
- Enable starts replay while status remains
InitializedorDisabled. - Another
checkStatus()can start a second replay before the first completes. Failedstatus does not retry enable even when deduplication should still be enabled.
Additional information
A fix has been proposed in #25953.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /pulsar, current file: none) bash-$
- Keep
- Assistant
I'll start by exploring the repository to understand the codebase structure and locate the relevant files. Let's first get a high-level view.
- Assistant
Let me examine the main MessageDeduplication.java file to understand the current implementation and the issue.
- Assistant
The file is truncated. Let me read the full file to understand the complete
checkStatus()andreplayCursor()methods: - Assistant
Let me look at the complete file to understand the full checkStatus method and related code.
- Assistant
Let me scroll through the file to see the full checkStatus method and the rest of the code.
- Assistant
Let me see more of the file, especially the
checkStatus()andreplayCursor()methods: - Assistant
Let me look at the checkStatus and replayCursor methods more carefully.
- Assistant
Now I can see the issue clearly. Let me also look at the referenced PR #25953 to understand what fix was proposed:
- Assistant
Let me check if there's a reference to PR #25953 in the repository:
- Assistant
Now let me look at the existing tests for MessageDeduplication to understand the testing patterns:
- Assistant
Now I understand the issue clearly. Let me analyze the
checkStatus()method in detail:- When
status == Status.Disabled || status == Status.InitializedandshouldBeEnabledis true, the method starts the cursor replay but doesn't set status toRecoveringbefore starting the async operation. - If
checkStatus()is called again while the first replay is still running, the status is stillInitializedorDisabled, so it enters the enable path again and starts another replay. - If enabling fails, status becomes
Failed, but there's no retry logic forFailedstatus.
Let me fix the
MessageDeduplication.javafile: - When
- Assistant
Now I understand the issue clearly. Let me analyze the
checkStatus()method:- Race condition: When
status == Status.Disabled || status == Status.InitializedandshouldBeEnabledis true, the method starts the cursor replay but doesn't set status toRecoveringbefore starting the async operation. - No retry for Failed status: If enabling fails, status becomes
Failed, but there's no retry logic forFailedstatus.
Let me now implement the fix. I need to:
- Set
status = Status.Recoveringbefore starting the cursor open/replay - Add retry logic for
Failedstatus when deduplication should still be enabled
- Race condition: When
- Assistant
Now let me verify the full checkStatus method to make sure everything looks correct:
- Assistant
The fix looks correct. Let me verify the changes are complete by looking at the
git diff: - Assistant
Now let me run the existing tests related to deduplication to make sure the fix doesn't break anything. First, let me check which test files exist:
- Assistant
Let me look at the existing tests to understand what they're testing and if my changes might break them.
- Assistant
Let me look at the
BrokerMessageDeduplicationTestto see if it tests thecheckStatus()method: - Assistant
Let me look at the checkStatusFail test to understand what it's testing and if our changes affect it:
- Assistant
Let me also look at
TopicDuplicationTestwhich might be more relevant: - Assistant
Let me look at the entire
BrokerMessageDeduplicationTestclass to see if there are tests that check status transitions: - Assistant
Let me check if there are any references to
checkDeduplicationStatusin the persistent topic class: - Assistant
Now let me verify the fix is correct by running the existing tests. First, let me check if there are any build tools available:
- Assistant
Let me check the build system.
- Assistant
Let me look at the build system for this project.
- Assistant
Let me find the build files.
- Assistant
It seems like the project uses Gradle. Let me check for the main build file:
- Assistant
Let me check if there's a way to compile just the relevant file:
- Assistant
Let me run the existing unit test for the
BrokerMessageDeduplicationTestto see if thecheckStatusFailtest passes with our changes: - Assistant
The tests pass. Let me also run the
MessageDuplicationTestto make sure nothing is broken: - Assistant
Let me also run the
TopicDuplicationTestto make sure it passes: - Assistant
All existing tests pass. Let me review the final state of the fix one more time:
- Assistant
Let me verify the full logic of the fixed
checkStatus()method to make sure it handles all the cases correctly: - Assistant
The fix looks correct. Let me run all deduplication-related tests to make sure everything works:
- Assistant
All deduplication-related tests pass. Let me verify the fix one final time by looking at the complete change:
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
- xiaomi/mimo-v2.5-proCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →