ISSUE DESCRIPTION Standalone elastic RayCluster self-updates raycluster-generation…
- User
ISSUE DESCRIPTION
Standalone elastic RayCluster self-updates raycluster-generation annotation What happened:
A standalone Kueue-managed elastic RayCluster is continuously updated by Kueue.
The
kueue.x-k8s.io/raycluster-generationannotation tracks the RayCluster's ownmetadata.generation, but remains one value behind. For example:metadata.generation: 273390 kueue.x-k8s.io/raycluster-generation: "273389"A later read showed the same pattern:
metadata.generation: 273462 kueue.x-k8s.io/raycluster-generation: "273461"Kueue logs showed repeated RayCluster reconciles followed by RayCluster update webhook calls from the Kueue controller manager.
This is a self-triggered loop in the RayCluster custom annotation path. For standalone RayClusters,
GetCustomAnnotationscallsGetWorkloadslicingRayClusterCustomAnnotations(ctx, c, j.Object(), podSets, j.Name). That helper fetches the same RayCluster and returns the fetched RayCluster generation as an annotation to write back onto the RayCluster. The metadata patch then advances the RayCluster generation, making the annotation stale again.What you expected to happen:
Kueue should not continuously patch a standalone elastic RayCluster when its replica counts have not changed.
The
raycluster-generationannotation is useful for RayJob and RayService, where the top-level object needs to account for an underlying RayCluster generation. A standalone RayCluster should not write its own generation back onto itself.How to reproduce it (as minimally and precisely as possible):
- Install Kueue v0.16.5 with
ElasticJobsViaWorkloadSlices=true. - Enable the RayCluster integration.
- Create a standalone RayCluster with:
metadata: annotations: kueue.x-k8s.io/elastic-job: "true" labels: kueue.x-k8s.io/queue-name: <local-queue>- Inspect the RayCluster generation and annotation repeatedly:
kubectl get raycluster.ray.io <name> -n <namespace> \ -o jsonpath='{.metadata.generation}{"\t"}{.metadata.annotations.kueue\.x-k8s\.io/raycluster-generation}{"\n"}'Anything else we need to know?:
This may be related to #10160, which added generation-based elastic workload names on the release-0.16 branch.
A fix is to omit
kueue.x-k8s.io/raycluster-generationwhen thejobObjectis the same standalone RayCluster asrayClusterName.Environment:
- Kubernetes version (use
kubectl version):- Client Version: v1.33.9
- Server Version: v1.33.10-gke.1115000
- Kueue version (use
git describe --tags --dirty --always):- Deployed controller image:
kueue:v0.16.5 - Helm chart:
kueue-0.16.5
- Deployed controller image:
- Cloud provider or hardware configuration: GKE
- OS (e.g:
cat /etc/os-release): not collected - Kernel (e.g.
uname -a): not collected - Install tools: Helm
- Others:
ElasticJobsViaWorkloadSlices=trueTopologyAwareScheduling=false
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /kueue, current file: none) bash-$
- Install Kueue v0.16.5 with
Assistant
Now let's also implement
RayCluster.GetCustomAnnotationsso standalone RayCluster actually calls this helper (matching the issue's exact described call pathGetCustomAnnotationscallingGetWorkloadslicingRayClusterCustomAnnotations(ctx, c, j.Object(), podSets, j.Name)), and wireJobWithCustomAnnotationsfor RayCluster. Let's check if this is truly missing and should be added, or if it's intentionally absent.Assistant
Now add the interface assertion:
Assistant
Now let's build to check compilation.
Assistant
Build succeeded silently. Let's run the relevant tests now.
Assistant
All existing tests pass. Now let's write a reproduction script to confirm the fix works, mimicking the reconciler flow for a standalone RayCluster.
Assistant
Now let's run the full test suite for relevant packages once more, plus vet.
Assistant
All relevant tests pass. Let's run broader test suite for the whole repo to make sure nothing else broke (at least build + jobs packages).
Assistant
All tests pass across the whole
pkg/tree. Let's view the final diff.Assistant
That's unrelated. Let's run the full jobframework and integration tests once more with
-run RayClusterto be thorough, and checkgo vet/golangci-lintif available.Assistant
All pass. Let's also check integration tests directory for raycluster elastic scenarios that might rely on this behavior (won't run full envtest here, but let's grep).
Assistant
Now let's go through the checklist.
Assistant
This looks complete. Let me go through the checklist:
Assistant
Checklist review:
-
If an error was reported in the issue description, I have successfully reproduced it. I traced the exact self-loop mechanism:
GetWorkloadslicingRayClusterCustomAnnotationsfetches the RayCluster and unconditionally writes its current generation intokueue.x-k8s.io/raycluster-generation. When the caller (jobObject) is that same standalone RayCluster, patching this annotation back onto the object bumpsmetadata.generationagain, so the annotation is forever one generation behind — reproducing the reported drift (generation: 273390/annotation: "273389"). I wrote a temporary test (since removed) that called the helper (and the newRayCluster.GetCustomAnnotationswiring) with a RayCluster object as bothjobObjectand targetrayClusterName, confirming the old code always emitted the generation annotation in this case. -
If an error was reported in the issue description, I have confirmed that my fix resolves the error. With the fix, the same reproduction shows
RayClusterGenerationAnnotationis omitted entirely whenjobObjectis the RayCluster identified byrayClusterName(i.e., a standalone RayCluster acting on itself), which breaks the self-update loop while leaving theraycluster-podset-replica-sizesannotation tracking intact. -
I have thought about edge cases and made sure my fix handles them as well.
- RayJob/RayService (different object type and/or different name than the underlying RayCluster) are unaffected — the type assertion
jobObject.(*rayv1.RayCluster)fails for them, so they keep getting the generation annotation as before (verified by existing RayJob tests). - "RayCluster not found" and "other get error" paths remain unchanged for non-standalone callers.
- The name comparison is done against the same namespace used for the
Getcall (jobObject.GetNamespace()), so there's no cross-namespace name collision risk. - The podset-replica-sizes annotation (which does not have this self-referential drift problem, since it reflects actual current pod-set counts, not a "previous fetch" value) is preserved for standalone RayClusters, keeping feature parity with RayJob/RayService.
- RayJob/RayService (different object type and/or different name than the underlying RayCluster) are unaffected — the type assertion
-
I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. Ran
go build ./...(succeeds) andgo test ./pkg/...(entire package tree, all green), plus focused runs ofpkg/controller/jobs/raycluster,pkg/controller/jobs/rayjob,pkg/controller/jobs/rayservice, andpkg/controller/jobframeworkwith verbose output to double check the annotation-related tests specifically.
-
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →