ISSUE DESCRIPTION Resolve OpenAPI $ref response objects during DSL v4 import Problem DSL…
- User
ISSUE DESCRIPTION
Resolve OpenAPI $ref response objects during DSL v4 import
Problem
DSL v4 OpenAPI import currently misses valid response objects that are expressed as
$refs.import_responsecallsselect_json_response, andselect_json_responselooks forcontentdirectly on each response object without first resolving$ref.Code references:
crates/coral-spec/src/v4/mod.rs:972crates/coral-spec/src/v4/mod.rs:1290
A valid OpenAPI shape like this is treated as if the operation has no JSON response:
responses: '200': $ref: '#/components/responses/Foo' components: responses: Foo: content: application/json: schema: type: array items: type: objectImpact
The importer falls through to
OutputCardinality::None, which causes otherwise valid read operations to be hidden/dropped from the generated projection catalog. This can make major portions of a real OpenAPI descriptor disappear from DSL v4 sources.Acceptance criteria
- Response
$refs under operation responses are resolved before selecting JSON responses. - Missing or external response refs produce diagnostics consistent with existing schema/parameter ref diagnostics.
- A regression test covers a
200response that references#/components/responses/...and verifies the projection is published.
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /coral, current file: none) bash-$
Assistant
Now let's look at resolve_ref and how components/parameters or schema refs are resolved to understand patterns for diagnostics.
Assistant
Now let's edit responses.rs to resolve response refs before selecting JSON response.
Assistant
Now let's add the
resolve_responseshelper method that resolves each response object's$refusingresolve_ref, and emit a diagnostic for unresolved response refs.Assistant
Now let's check that
resolve_refis accessible (pub(super)) from this file - it's inimport.rsmoduleimport, and responses.rs usessuper::import::OpenApiImporter. Since resolve_ref ispub(super)in import.rs (withinopenapimodule), it should be visible to responses.rs which is a sibling module. Let's build.Assistant
Builds fine. Now let's check existing tests in openapi_tests.rs for pattern to write a regression test.
Assistant
Now let's add a regression test similar in style, for
$refresponse.Assistant
Now let's append the regression test for
$refresponse.Assistant
Good - diagnostics per operation confirmed. Also note operation_id normalization uses
normalize_identifier, meaning "foos/list" gets normalized differently potentially. Let's check what operation.id would actually be, and adjust test accordingly (usedoperation_id == "foos/list"for projection lookup).Assistant
Now let's run tests.
Assistant
All new tests pass. Now let's run full test suite for coral-spec crate to ensure nothing broke.
Assistant
All 206 tests pass. Let's also check the whole workspace compiles/tests fine, and check for clippy warnings maybe used in CI.
Assistant
No clippy warnings. Let's view the final diff.
Assistant
This looks good. Let's also run the full workspace test suite quickly to be safe.
Assistant
Confirmed these failures are pre-existing on the base branch, unrelated to my change (likely filesystem permission-based tests failing in this sandboxed environment). Let's restore my changes.
Assistant
Good, changes restored. These pre-existing failures are unrelated (likely running as root, so permission-denied simulations don't fail as expected). My changes to coral-spec are unaffected.
Assistant
Now let's go through the checklist explicitly.
Assistant
All 206 tests pass, including the two new regression tests I added.
Checklist review:
Assistant
The fix is complete and verified. Let me do a final review of the diff before submitting.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →