Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-sonnet-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION [BUG][auto] duplicate-overlapping-clone-groups: same duplication…

  1. User

    ISSUE DESCRIPTION

    [BUG][auto] duplicate-overlapping-clone-groups: same duplication emitted as two separate near-identical clone groups

    Bug

    pyscn's clone detector emits two separate clone groups that describe the same duplication relationship between the same two code fragments, with member windows shifted by exactly one line (the enclosing with/header line). The result is a redundant clone group that inflates clone_groups count and the duplication percentage.

    This is related to but distinct from the (closed) #416 clone-overlapping-window-self-clone: #416 was about strict-subset members within a single group; here the redundancy is across two whole groups that are near-duplicates of each other.

    Reproducer

    Repo: Instagram/Fixit @ bf8e1f55f8a606eae0f0c64bab575e84a2a608b3 pyscn: v1.22.9

    curl -fsSL "https://codeload.github.com/Instagram/Fixit/tar.gz/HEAD" | tar -xz
    pyscn analyze --json --no-open Fixit-*/
    

    In the resulting analyze.json, clone.clone_groups contains two groups that cover the same pair of fragments in src/fixit/tests/smoke.py:

    {
      "id": 6,  "type": 2, "similarity": 0.9692,
      "clones": [
        {"location": {"file_path": ".../smoke.py", "start_line": 299, "end_line": 315}},
        {"location": {"file_path": ".../smoke.py", "start_line": 318, "end_line": 334}}
      ]
    },
    {
      "id": 14, "type": 2, "similarity": 0.9613,
      "clones": [
        {"location": {"file_path": ".../smoke.py", "start_line": 298, "end_line": 315}},
        {"location": {"file_path": ".../smoke.py", "start_line": 317, "end_line": 334}}
      ]
    }
    

    Both groups describe the duplication between the subTest("lint") block and the subTest("fix") block. Group 14's members each start exactly one line earlier than group 6's — that line is the with self.subTest("lint"): / with self.subTest("fix"): header:

            with self.subTest("lint"):          # line 298  (grp14 member start)
                with TemporaryDirectory() as td: # line 299  (grp6 member start)
                    ...
            with self.subTest("fix"):           # line 317  (grp14 member start)
                with TemporaryDirectory() as td: # line 318  (grp6 member start)
    

    Both groups end on the same lines (315 / 334). The two groups are the same logical clone reported twice at slightly different window boundaries.

    Expected behavior

    The clone-grouping/dedup stage should merge (or suppress) clone groups whose members are overlapping windows of the same underlying fragments, so each duplication relationship is reported once. As-is, the clone_groups count (10 here) and the duplication score over-count by one redundant group.

    Actual behavior

    Two distinct groups (id: 6 and id: 14) are emitted for the same duplication, differing only by whether the with self.subTest(...) header line is included in each member window.

    Priority rationale

    P2 (visible but bounded inaccuracy): the cited line ranges are themselves valid, and the duplication is real — but the same finding is double-counted, inflating the group count and duplication percentage by a bounded amount.

    Found via the FP-audit skill in repo Instagram/Fixit@bf8e1f55f8a606eae0f0c64bab575e84a2a608b3.

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /pyscn, current file: none) bash-$

  2. Claude Assistant

    Now let's implement the changes.

  3. Claude Assistant

    Build succeeds. Now let's run the existing group_dedup tests plus related clone tests.

  4. Claude Assistant

    All existing tests pass. Now let's write a reproduction test that mirrors the issue scenario (two groups with shifted windows) to confirm the fix works.

  5. Claude Assistant

    The reproduction test passes. Let's remove the temp test file and run the full analyzer test suite.

  6. Claude Assistant

    All analyzer package tests pass. Let's also run the broader test suite to be safe (service, domain, app layers dealing with clones).

  7. Claude Assistant

    This confirms my change broke this test. Let's restore my change and investigate.

  8. Claude Assistant

    Now add debug print inside mergeOverlappingGroups for what it decides, then run debug main.go.

  9. Claude Assistant

    Good, we're back to the original file. Now let's write the improved patch with the additional gating criteria.

  10. Claude Assistant

    Now let's re-test the debug reproducer and the false-positive regression case.

  11. Claude Assistant

    Good, the false positive is fixed (matches baseline). Now let's re-run the original reproduction test for the actual issue scenario.

  12. Claude Assistant

    Both scenarios pass now. Let's clean up the temp test file and run the full test suite.

  13. Claude Assistant

    All tests pass now, including the previously failing service package test. Let's also try to more directly reproduce the original Fixit issue scenario to make sure our fix handles the actual reported case with real Python source (with/with nesting).

  14. Claude Assistant

    Now let's run our built binary directly against this repo file to reproduce the actual bug from the issue, first checking with the original (unmodified) code, then with our fix.

  15. Claude Assistant

    Matches the reported line numbers exactly (298/299/317/318). Let's run both binaries against this exact commit.

  16. Claude Assistant

    All edge cases pass. Let's clean up the temp test file and run the full suite one more time.

  17. Claude Assistant

    All packages pass. Let's review the final diff and clean up temp files/binaries.

  18. Claude Assistant

    Good, the repo is clean except for our intended change. Let's view the final diff for review.

  19. Claude Assistant

    The diff is clean and self-contained. Let's do one final full test run to confirm everything is good before submission.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.