Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-opus-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION Fatal crash in (*Program).SingleThreaded on snapshot update [code]…

  1. User

    ISSUE DESCRIPTION

    Fatal crash in (*Program).SingleThreaded on snapshot update

    internal/compiler.(*Program).SingleThreaded()
    	internal/compiler/program.go:416
    internal/compiler.NewProgram()
    	internal/compiler/program.go:274
    internal/project.(*Project).CreateProgram()
    	internal/project/project.go:376
    internal/project.(*ProjectCollectionBuilder).updateProgram.func2.1()
    	internal/project/projectcollectionbuilder.go:1055
    internal/project/dirty.(*Box[...]).Change()
    	internal/project/dirty/box.go:41
    internal/project.(*ProjectCollectionBuilder).updateProgram.func2()
    	internal/project/projectcollectionbuilder.go:1052
    internal/project/dirty.(*Box[...]).Locked()
    	internal/project/dirty/box.go:57
    internal/project.(*ProjectCollectionBuilder).updateProgram()
    	internal/project/projectcollectionbuilder.go:1051
    internal/project.(*ProjectCollectionBuilder).DidRequestFile()
    	internal/project/projectcollectionbuilder.go:397
    internal/project.(*Snapshot).Clone()
    	internal/project/snapshot.go:353
    internal/project.(*Session).updateSnapshot()
    	internal/project/session.go:1101
    internal/project.(*Session).getSnapshot()
    	internal/project/session.go:819
    internal/project.(*Session).getSnapshotAndDefaultProject()
    	internal/project/session.go:877
    internal/project.(*Session).GetLanguageService()
    	internal/project/session.go:890
    internal/lsp.init.func1.registerLanguageServiceDocumentRequestHandler[...].13()
    	internal/lsp/server.go:826
    internal/lsp.(*Server).handleRequestOrNotification()
    	internal/lsp/server.go:669
    

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /typescript-go, current file: none) bash-$

  2. Claude Assistant

    Now let me write a temporary reproduction test.

  3. Claude Assistant

    Now update Clone and the getter.

  4. Claude Assistant

    Summary

    Root cause. Project.getCommandLineWithTypingsFiles() lazily computed the "command line augmented with ATA typings files" behind a sync.Once, while two places in ProjectCollectionBuilder invalidate that cache by setting the field to nil (updateInferredProjectRoots and updateProgram on config change).

    Since dirty.Box.Change/SyncMapEntry.changeLocked only clone the Project the first time it becomes dirty, a single snapshot update can:

    1. create a program for the (already dirty) project → the Once fires and the augmented command line is cached,
    2. later invalidate it in the same pass (p.commandLineWithTypingsFiles = nil) on the very same instance,
    3. create a program again → Once.Do no longer runs, so getCommandLineWithTypingsFiles() returns nil → compiler.NewProgram gets Config == nil → p.Options() is nil → nil-pointer deref in (*Program).SingleThreaded — exactly the reported crash stack.

    (The same Once also made ATA typing updates silently stale, since DidUpdateATAState changes typingsFiles without touching the cache.)

    Fix (internal/project/project.go): replaced the one-shot sync.Once with a mutex-protected cache that is keyed on its inputs (CommandLine identity and typingsFiles), so it recomputes as many times as needed and can never return a stale/nil value. Cache keys are carried through Clone.

    Verified with a temporary reproduction (open a JS file whose package.json triggers ATA typings, edit it, then request the open file plus a closed file in one snapshot update): it panicked with the exact stack from the issue before the change and passes afterwards, with the program correctly containing both the typings file and the newly added root.

    Checklist

    • If an error was reported in the issue description, I have successfully reproduced it. Yes — I built a temporary test in internal/project driving the real Session API which produced the identical panic (SingleThreaded → NewProgram → CreateProgram → dirty.(*Box).Change → updateProgram → DidRequestFile).
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error. Yes — the same scenario passes after the change, and the resulting program contains the expected files (typings + new root), so the fix is correct, not just crash-suppressing.
    • I have thought about edge cases and made sure my fix handles them as well. The cache is now keyed on both inputs, so it also handles: CommandLine replacement (configured-project config reload, inferred-root changes), typingsFiles changes from ATA (previously silently stale), repeated invalidation within one snapshot pass, and cloned projects inheriting the cache. Access is mutex-protected so concurrent program creation cannot produce two different command-line pointers (which would defeat program reuse); go vet (copylocks) and -race runs are clean. The existing explicit = nil invalidations remain valid and harmless.
    • I have run existing tests in the repository that might have been affected and confirmed that they pass. Yes — go test ./internal/project/... (also with -race), ./internal/lsp/..., ./internal/ls/..., ./internal/fourslash/... all pass; go build ./... and gofmt are clean. No existing tests were modified and my temporary test file was removed.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.