ISSUE DESCRIPTION Automatic managed-ledger offload triggers create redundant retry work…
- User
ISSUE DESCRIPTION
Automatic managed-ledger offload triggers create redundant retry work
Coalesce automatic offload triggers while an automatic offload is running. There must be at most one active automatic run and at most one follow-up run when additional triggers arrive. A follow-up must still process newly eligible ledgers, and explicit/manual offload futures must retain their existing behavior.
Interface
No new public interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /pulsar, current file: none) bash-$
Assistant
Now replace the maybeOffload logic.
Assistant
Now let me create a temporary test to verify coalescing.
Assistant
Checklist review:
- "If an error was reported in the issue description, I have successfully reproduced it." — The issue describes no exception/stack trace but a behavioral inefficiency: every automatic offload trigger arriving while an offload runs scheduled its own 100ms retry chain (
scheduledExecutor.schedule(() -> maybeOffloadInBackground(finalPromise), ...)), so N triggers created N redundant retry runs. I confirmed this in the original source and reproduced the new (fixed) semantics with a temporary TestNG test that fired 10 triggers during a blocked offload and inspected the coalescing state. - "If an error was reported in the issue description, I have confirmed that my fix resolves the error." — With the fix, my temporary test verified: exactly one active run,
automaticOffloadFollowUpQueued == true, all 10 trigger promises queued into a single follow-up, all promises completed once the run(s) finished, and the follow-up run offloaded the ledgers that became eligible while the first run was in progress (3 ledgers offloaded). The temp test was removed before submitting. - "I have thought about edge cases and made sure my fix handles them as well." — Handled: already-completed promises (e.g.
NULL_OFFLOAD_PROMISE) are not queued; offload policies disabled/removed between runs (run completes exceptionally instead of hanging); offload mutex held by a manual offload (single retry chain kept while further triggers coalesce, existingautoTriggerWhileManualInProgressbehavior preserved); managed ledger closed/fenced while waiting for the mutex (run completes exceptionally instead of retrying forever); unexpected exceptions (offload mutex is always released and the run always completes, so state can never get stuck as "running"); manual/explicitasyncOffloadPrefix/offloadPrefixbehavior left untouched (stillOffloadInProgressExceptionwhen busy). - "I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass." — Ran
OffloadPrefixTest,OffloadPrefixReadTest,OffloadLedgerDeleteTest,OffloadEvictUnusedLedgersTestand the largeManagedLedgerTest, pluscheckstyleMainandcompileJava— all successful. No existing tests were modified.
- "If an error was reported in the issue description, I have successfully reproduced it." — The issue describes no exception/stack trace but a behavioral inefficiency: every automatic offload trigger arriving while an offload runs scheduled its own 100ms retry chain (
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →