Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-opus-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION [Feature] Map thinkinglevel to DeepSeek thinking fields 🎯 The Goal /…

  1. User

    ISSUE DESCRIPTION

    [Feature] Map thinking_level to DeepSeek thinking fields

    🎯 The Goal / Use Case

    DeepSeek is currently treated as an OpenAI-compatible provider in PicoClaw, but its thinking-mode controls do not match the internal thinking_level abstraction 1:1.

    Please implement correct DeepSeek thinking mapping so that:

    • explicit thinking_level: "off" automatically disables DeepSeek thinking mode
    • thinking-enabled levels are translated to DeepSeek's documented OpenAI-compatible fields
    • DeepSeek users can rely on the same thinking_level config without needing manual extra_body overrides

    💡 Proposed Solution

    Add DeepSeek-specific request shaping on the OpenAI-compatible path.

    Suggested mapping:

    • thinking_level: "off" -> thinking: { "type": "disabled" }
    • thinking_level: "high" -> thinking: { "type": "enabled" } + reasoning_effort: "high"
    • thinking_level: "xhigh" -> thinking: { "type": "enabled" } + reasoning_effort: "max"

    If low / medium are kept as valid internal levels, they can follow DeepSeek's documented compatibility behavior and map to reasoning_effort: "high".

    🛠 Potential Implementation (Optional)

    PR #2898 already introduced explicit thinking_level: "off" handling for several OpenAI-compatible providers and added provider-specific disable-field shaping.

    This issue is to extend that work for DeepSeek specifically:

    • add DeepSeek request shaping on the OpenAI-compatible provider path
    • map internal thinking levels to DeepSeek's thinking and reasoning_effort fields
    • ensure explicit off is sent even when DeepSeek does not advertise generic thinking support via SupportsThinking()
    • add tests covering both request shaping and fallback/rewrite paths if applicable

    🚦 Impact & Roadmap Alignment

    • This is a Core Feature
    • This is a Nice-to-Have / Enhancement
    • This aligns with the current Roadmap

    🔄 Alternatives Considered

    • Ask users to configure DeepSeek manually with extra_body
    • Keep DeepSeek on the generic OpenAI-compatible path without provider-specific thinking mapping

    Both alternatives are weaker because they make DeepSeek behavior inconsistent with the project-wide thinking_level abstraction.

    💬 Additional Context

    https://api-docs.deepseek.com/zh-cn/guides/thinking_mode

    DeepSeek's documented OpenAI-compatible thinking controls use:

    • thinking.type
    • reasoning_effort
    • reasoning_content in responses

    PR #2898 is closely related because it establishes the explicit-off behavior and provider-specific request shaping pattern. DeepSeek appears to still need its own mapping added on top of that work.

    Interface

    Type: Function Name: SupportsThinking Path: pkg/providers/httpapi/http_provider.go Input: () Output: bool Description: Exposes the thinking capability of the underlying provider delegate over the HTTP API. Returns true if the delegate supports thinking; otherwise false.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /picoclaw, current file: none) bash-$

  2. Claude Assistant

    Now add SupportsThinking to HTTPProvider.

  3. Claude Assistant

    Now a temporary test script to verify behavior.

  4. Claude Assistant

    Checklist review:

    • "If an error was reported in the issue description, I have successfully reproduced it." — The issue is a feature request, not a crash/error, but I did reproduce the missing behavior with a temporary in-package test: before the change, buildRequestBody for a DeepSeek endpoint emitted no thinking/reasoning_effort fields for any level, and HTTPProvider had no SupportsThinking() (so non-off levels were dropped by pkg/agent/thinking.go).
    • "If an error was reported... I have confirmed that my fix resolves the error." — With the temporary test I verified: off → thinking:{type:disabled}, low/medium/high → thinking:{type:enabled} + reasoning_effort:"high", xhigh → thinking:{type:enabled} + reasoning_effort:"max", and HTTPProvider.SupportsThinking() returns true for DeepSeek (by provider name or *.deepseek.com host) and false otherwise. The temp tests were removed before submitting (no repository tests added/modified).
    • "I have thought about edge cases." — Covered: nil provider / nil delegate receivers; DeepSeek detection both via configured provider name (case/space tolerant) and via host; unknown/absent thinking_level leaves the request untouched; adaptive (no DeepSeek equivalent) enables thinking without pinning reasoning_effort; user extra_body still overrides the shaped fields because it is merged last; non-DeepSeek providers (Doubao/volcengine thinking.type, Qwen enable_thinking, OpenAI) keep their previous behavior — no reasoning_effort leaks to hosts that would 422; DeepSeek models served by other hosts (e.g. OpenRouter deepseek/...) are intentionally not shaped.
    • "I have run existing tests that might have been affected." — Ran go test ./pkg/providers/... (all pass, including the existing thinking_level: off shaping tests) and go test ./pkg/agent/ (passes, covering the thinking option / hook-rewrite / fallback paths). go vet and gofmt clean; the only build failures in the repo (libolm cgo header, onboard embed pattern) are pre-existing and unrelated.

    Submitting the change.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.