ISSUE DESCRIPTION Fail on HTTP Status 204 (No Content) Hello, I'm using Synadia Cloud…
- User
ISSUE DESCRIPTION
Fail on HTTP Status 204 (No Content) Hello,
I'm using Synadia Cloud which has a
DELETEAPI that returns a response with no body.$ restish synadia delete-nats-user --help Deletes a NATS user from an account ## Argument Schema: { user-id: (string) } ## Responses 204/400/401/403/404 Response has no bodyIn this case, it's expected to have an empty body. Nevertheless,
restishfails with the error:ERROR: Parse response error ERROR: Caught error: EOFHere is the full log:
DEBUG: API loading took 6.245709ms DEBUG: Configuration: [REDACTED] DEBUG: Adding TLS configuration DEBUG: Making request: DELETE /api/core/beta/nats-users/[REDACTED] HTTP/1.1 Host: cloud.synadia.com Accept: application/msgpack;q=0.8,application/cbor;q=0.9,application/ion;q=0.6,application/json;q=0.5,application/yaml;q=0.5,text/*;q=0.2,*/* Accept-Encoding: deflate, gzip, br Authorization: [REDACTED] User-Agent: restish-0.20.0 DEBUG: Got response from server in 426.428041ms: HTTP/2.0 204 No Content Content-Encoding: gzip Date: Mon, 26 May 2025 19:48:15 GMT Set-Cookie: [REDACTED] Strict-Transport-Security: max-age=15768000 ; includeSubDomains Vary: Accept-Encoding X-Content-Type-Options: nosniff X-Frame-Options: SAMEORIGIN DEBUG: Decoding response from gzip ERROR: Parse response error ERROR: Caught error: EOF DEBUG: goroutine 1 [running]: runtime/debug.Stack() /opt/hostedtoolcache/go/1.18.10/x64/src/runtime/debug/stack.go:24 +0x68 github.com/danielgtaylor/restish/cli.Run.func1() /home/runner/work/restish/restish/cli/cli.go:849 +0x68 panic({0x1051c4f40, 0x140001900f0}) /opt/hostedtoolcache/go/1.18.10/x64/src/runtime/panic.go:838 +0x204 github.com/danielgtaylor/restish/cli.MakeRequestAndFormat(0x1052d4830?) /home/runner/work/restish/restish/cli/request.go:568 +0x118 github.com/danielgtaylor/restish/cli.Operation.command.func1(0x14000693800?, {0x1400061e8a0, 0x1, 0x2}) /home/runner/work/restish/restish/cli/operation.go:142 +0x814 github.com/spf13/cobra.(*Command).execute(0x14000693800, {0x1400061e880, 0x2, 0x2}) /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x5dc github.com/spf13/cobra.(*Command).ExecuteC(0x1400034e600) /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x35c github.com/spf13/cobra.(*Command).Execute(...) /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968 github.com/danielgtaylor/restish/cli.Run() /home/runner/work/restish/restish/cli/cli.go:857 +0x9a8 main.main() /home/runner/work/restish/restish/main.go:40 +0x370Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /restish, current file: none) bash-$
Assistant
Now write a temporary end-to-end test in the cli package dir to verify.
Assistant
I've completed the fix. Final diff:
Assistant
Root cause
Servers may send a
Content-Encodingheader (e.g.gzip) on responses that legitimately have no body (HTTP 204 No Content, 304, HEAD).Registry.Decompresseagerly built the decompressor (gzip.NewReader), which immediately tried to read the gzip header from an empty stream and returnedio.EOF, surfacing asParse response error / EOF.Fix
internal/content/registry.go:Decompressnow returns alazyDecompressorthat defers constructing the real decompressing reader until the firstRead. At that point it peeks one byte: if the stream is completely empty it reportsio.EOF(empty body) instead of handing nothing to the decompressor. This fixes all callers at once (output.Normalize, raw body output, streaming/SSE/NDJSON paths) and also avoids blocking on stream construction for streaming responses.internal/output/response.go: defensive handling of anil/http.NoBodyresponse body (no panic onClose, treated as empty body).
Downstream code already treats a zero-length raw body as "no body", so a 204 now prints only status/headers and exits 0.
Checklist
- If an error was reported in the issue description, I have successfully reproduced it. Yes — I wrote a temporary test that calls
output.Normalizewith a 204 +Content-Encoding: gzip+ empty body and gotdecompressing response: EOF, and an end-to-end CLI test (delete ... -v) that failed with the same error, matching the issue. - If an error was reported in the issue description, I have confirmed that my fix resolves the error. Yes — after the change both the unit-level repro and the end-to-end CLI test pass; I also built the real binary and ran
restish deleteagainst a local server returning204withContent-Encoding: gzip, which now prints status/headers and exits 0 (verified failing before the fix viagit stash). Temp test files/servers were removed. - I have thought about edge cases and made sure my fix handles them as well. Yes: empty-but-valid gzip payloads still decode normally; genuinely corrupt compressed bodies still error (now during body read, which the CLI already maps to a friendly "reading response body" error); unsupported
Content-Encodingstill errors immediately;identity/empty encoding path unchanged; brotli/deflate/gzip all covered by the shared lazy wrapper; streaming (SSE/NDJSON) responses are not blocked earlier than before since construction is deferred to first read;Closeonly closes the inner reader if it was created (callers still close the original body); nil/http.NoBodybodies handled. - I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. Yes —
go build ./...,go veton changed packages, and the fullgo test ./...suite all pass.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →