ISSUE DESCRIPTION Cap eval table page size for non-export requests Summary GET…
- User
ISSUE DESCRIPTION
Cap eval table page size for non-export requests
Summary
GET /api/eval/:id/tableaccepts any positive integer forlimiton normal table requests. The route already intentionally treats export requests differently by usingNumber.MAX_SAFE_INTEGERwhenformatis set, but non-export page requests currently do not have an upper bound.Why this matters
A very large
limitcan make a normal table request ask the server to load and serialize a large amount of eval result data in one response. Other list-style APIs in the server already bound their page sizes, so the eval table endpoint should follow the same resource-control pattern.Proposed change
- Add a maximum
limitfor non-exportGET /api/eval/:id/tablerequests. - Keep
format=csv/format=jsonexports unchanged so full-table exports still work as intended. - Return validation errors for excessive non-export limits, consistent with nearby API schema validation.
A cap of
500or1000would likely cover normal UI usage while preventing accidental oversized page requests.Validation
Suggested tests:
- schema test rejects
EvalSchemas.Table.Query.safeParse({ limit: '<cap + 1>' }) - route validation test returns
400for excessive non-exportlimit - export route tests continue to use
Number.MAX_SAFE_INTEGERwhenformatis present
Interface
Type: Constant Name: EVAL_TABLE_MAX_PAGE_SIZE Path: src/types/api/eval.ts Value/Type: constant literal value 1000 (number) Description: Server-enforced upper bound for the
limitparameter on non-export eval table page requests. Exports usingformat(csv/json) are exempt from this cap; UI pagination controls derive their available page-size options from this value.ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /promptfoo, current file: none) bash-$
- Add a maximum
Assistant
Now update the UI to derive page-size options from the constant.
Assistant
Now update the select items to render from the constant.
Assistant
Now write a temporary script to verify behavior.
Assistant
All changes are complete. Let me go through the checklist:
1. If an error was reported in the issue description, I have successfully reproduced it. The issue is a missing resource control rather than a runtime crash. I verified the original behavior:
EvalTableQuerySchemaonly enforcedint().positive(), solimit=5000(or any huge value) parsed successfully for non-export requests and would be passed straight togetTablePage. Confirmed by inspecting the schema and by a temporary tsx script exercisingEvalSchemas.Table.Query.safeParse.2. If an error was reported in the issue description, I have confirmed that my fix resolves the error. Yes. After the change:
EvalSchemas.Table.Query.safeParse({ limit: '1001' })→ fails withtoo_bigon pathlimit, prettified as “Too big: expected limit to be <=1000 → at limit”.GET /api/eval/:id/table?limit=1001→ HTTP 400 with an error mentioninglimit, andEval.findByIdis never called (verified with a temporary supertest test that I removed afterwards).format=csv&limit=100000still parses and the route still usesNumber.MAX_SAFE_INTEGER.
3. I have thought about edge cases and made sure my fix handles them as well.
- Exports (
format=csv/format=json) are exempt from the cap, so full-table exports are unchanged. limitexactly at the cap (1000) is accepted; 0/negative/non-integer are still rejected as before; the default of 50 is preserved.- The cap is applied at the object level via
.check()(zod v4), which preserves theZodObjecttype so the OpenAPI registry (query('EvalTableQuery', ...)) and.shapeaccess keep working (verified, and OpenAPI generation still succeeds). - UI: the results-per-page selector now derives its options from
EVAL_TABLE_MAX_PAGE_SIZE, so the UI can never request a page size the API would reject.
4. I have run existing tests in the repository that might have been affected. Ran
test/types,test/openapi,test/server/routesand the app’sResultsTable*/storetests — all pass, excepteval.filteredMetrics,modelAudit, andconfigs, which fail identically on a clean checkout (pre-existing DB-migration issue in this environment, confirmed withgit stash). I did not add or modify any repository tests; temporary scripts/tests were deleted, and the generatedsite/static/openapi.jsonwas removed.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →