ISSUE DESCRIPTION [Feature] Map thinkinglevel to DeepSeek thinking fields 🎯 The Goal /…
- User
ISSUE DESCRIPTION
[Feature] Map thinking_level to DeepSeek thinking fields
🎯 The Goal / Use Case
DeepSeek is currently treated as an OpenAI-compatible provider in PicoClaw, but its thinking-mode controls do not match the internal
thinking_levelabstraction 1:1.Please implement correct DeepSeek thinking mapping so that:
- explicit
thinking_level: "off"automatically disables DeepSeek thinking mode - thinking-enabled levels are translated to DeepSeek's documented OpenAI-compatible fields
- DeepSeek users can rely on the same
thinking_levelconfig without needing manualextra_bodyoverrides
💡 Proposed Solution
Add DeepSeek-specific request shaping on the OpenAI-compatible path.
Suggested mapping:
thinking_level: "off"->thinking: { "type": "disabled" }thinking_level: "high"->thinking: { "type": "enabled" }+reasoning_effort: "high"thinking_level: "xhigh"->thinking: { "type": "enabled" }+reasoning_effort: "max"
If
low/mediumare kept as valid internal levels, they can follow DeepSeek's documented compatibility behavior and map toreasoning_effort: "high".🛠 Potential Implementation (Optional)
PR #2898 already introduced explicit
thinking_level: "off"handling for several OpenAI-compatible providers and added provider-specific disable-field shaping.This issue is to extend that work for DeepSeek specifically:
- add DeepSeek request shaping on the OpenAI-compatible provider path
- map internal thinking levels to DeepSeek's
thinkingandreasoning_effortfields - ensure explicit
offis sent even when DeepSeek does not advertise generic thinking support viaSupportsThinking() - add tests covering both request shaping and fallback/rewrite paths if applicable
🚦 Impact & Roadmap Alignment
- This is a Core Feature
- This is a Nice-to-Have / Enhancement
- This aligns with the current Roadmap
🔄 Alternatives Considered
- Ask users to configure DeepSeek manually with
extra_body - Keep DeepSeek on the generic OpenAI-compatible path without provider-specific thinking mapping
Both alternatives are weaker because they make DeepSeek behavior inconsistent with the project-wide
thinking_levelabstraction.💬 Additional Context
https://api-docs.deepseek.com/zh-cn/guides/thinking_mode
DeepSeek's documented OpenAI-compatible thinking controls use:
thinking.typereasoning_effortreasoning_contentin responses
PR #2898 is closely related because it establishes the explicit-
offbehavior and provider-specific request shaping pattern. DeepSeek appears to still need its own mapping added on top of that work.Interface
Type: Function Name: SupportsThinking Path: pkg/providers/httpapi/http_provider.go Input: () Output: bool Description: Exposes the thinking capability of the underlying provider delegate over the HTTP API. Returns true if the delegate supports thinking; otherwise false.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /picoclaw, current file: none) bash-$
- explicit
Assistant
I'll start by exploring the repository structure.
Assistant
Now let me implement the changes in the openai_compat provider.
Assistant
Now applying edits.
Assistant
Now update
requiresToolRoundReasoningReplayto reuse the helper, and addSupportsThinkingon HTTPProvider.Assistant
Now fix the
requiresToolRoundReasoningReplayin provider.go (line 377).Assistant
Now let me write a temporary test script to verify the mapping behavior.
Assistant
Now add the constant definition.
Assistant
Now the checklist:
-
"If an error was reported in the issue description, I have successfully reproduced it." — The issue is a feature request, not a crash/error. I still reproduced the gap: before my change, a DeepSeek-configured provider built a request body with no
thinking/reasoning_effortfields for anythinking_level(verified via a temporary test againstbuildRequestBodyand an end-to-endhttptestserver throughCreateProviderFromConfig), andHTTPProviderdid not implementproviders.ThinkingCapableat all, sothinking_level: high/xhighwas dropped with a warning by the agent loop. -
"If an error was reported in the issue description, I have confirmed that my fix resolves the error." — Yes. Temporary (now deleted) tests confirmed:
off→thinking:{type:disabled};low/medium/high→thinking:{type:enabled}+reasoning_effort:"high";xhigh→enabled+reasoning_effort:"max";adaptive→enabled; invalid levels → no shaping. The end-to-end test throughCreateProviderFromConfig(with tool-schema wrapper) showed the real HTTP body containing"thinking":{"type":"enabled"}, "reasoning_effort":"max", andSupportsThinking()returning true so the agent forwards non-offlevels. -
"I have thought about edge cases and made sure my fix handles them as well." — Handled: DeepSeek detection by protocol name and by
api.deepseek.comhost (plusdeepseekmodel hint on the genericopenai/unnamed protocol path); explicitoffstill shaped even though it bypassesSupportsThinking(); nil-receiver safety onProvider.SupportsThinking,HTTPProvider.SupportsThinking(nil provider/delegate) and nilrequestBody;extra_bodystill merged last so manual overrides win; stalereasoning_effortdeleted when disabling; unknown/unsupportedthinking_levelstrings ignored; non-DeepSeek providers keep exactly their prior disable-only behavior and still returnfalsefromSupportsThinking()(so no silent swallowing of unsupported levels); wrappers (toolSchemaTransformProvider) already delegateThinkingCapable. -
"I have run existing tests in the repository that might have been affected." — Yes:
go vet ./pkg/providers/...,go test ./pkg/providers/...,go test ./pkg/agent/...,go test ./pkg/config/...all pass;gofmt -l pkg/providersis clean. I did not add or modify any repository tests (temporary test files were removed).
Submitting the change.
-
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →