Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-opus-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION [Bug] Broker may accept duplicate messages after dedup recovery race…

  1. User

    ISSUE DESCRIPTION

    [Bug] Broker may accept duplicate messages after dedup recovery race

    Issue Description

    Message deduplication recovery can be started more than once for the same topic before the first recovery replay completes.

    MessageDeduplication defines a Recovering status to prevent overlapping transitions, but the enable path starts dedup cursor replay without first changing the status to Recovering.

    Because of that, another checkStatus() call can still observe Initialized or Disabled and start a second replay for the same dedup cursor.

    One practical trigger path is topic load with existing topic-level policies:

    TimeFlow A: existing topic-level policy during loadFlow B: normal topic load chainDedup status / effect
    T1initTopicPolicy() loads existing topic policiesdedup status is Initialized or Disabled
    T2onUpdate() applies topic policies and calls checkDeduplicationStatus()first dedup recovery replay starts
    T3first replay is still running asynchronouslystatus is still Initialized or Disabled
    T4topic load continues and BrokerService explicitly calls checkDeduplicationStatus()
    T5second check also enters the enable pathsecond replay starts for the same dedup cursor
    T6first replay rebuilds producer sequence statesecond replay also rebuilds producer sequence stateoverlapping replay can advance shared replay/cursor state

    Dedup recovery rebuilds producer sequence information from the dedup cursor. If overlapping replay leaves the recovered sequence state incomplete or inconsistent, the broker may fail to identify already-published messages as duplicates.

    The impact is that duplicate messages can be accepted after topic load or policy refresh even though message deduplication is enabled.

    There is also a retry gap after recovery failure. If enabling deduplication fails transiently, the status moves to Failed, but later checks do not retry enabling even when the topic policy still requires deduplication.

    Error messages

    There may be no error message. This is a race in the dedup recovery state machine.

    Reproducing the issue

    A deterministic unit-level reproduction can be built by delaying the first dedup recovery replay and invoking checkStatus() again before the first replay completes:

    1. Keep MessageDeduplication in Initialized or Disabled.
    2. Call checkStatus() once and delay async cursor open or replay completion.
    3. Call checkStatus() again before the first recovery finishes.
    4. Observe that the second call enters the enable path again and starts another replay.

    A production-like trigger path is:

    1. Enable message deduplication.
    2. Use a topic with existing topic-level policies.
    3. Load or reload the topic.
    4. During topic load, initTopicPolicy() can invoke onUpdate(), which applies topic policies and calls checkDeduplicationStatus().
    5. The normal topic load chain later calls checkDeduplicationStatus() again.
    6. If the first recovery replay is still in progress, both checks can start overlapping dedup replay.

    Expected behavior

    • Deduplication should enter Recovering before starting recovery replay.
    • Concurrent status checks should not start another recovery while replay is in progress.
    • If enable fails transiently, a later check should retry enabling when deduplication is still required by policy.

    Actual behavior

    • Enable starts replay while status remains Initialized or Disabled.
    • Another checkStatus() can start a second replay before the first completes.
    • Failed status does not retry enable even when deduplication should still be enabled.

    Additional information

    A fix has been proposed in #25953.

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /pulsar, current file: none) bash-$

  2. Claude Assistant

    Now verify the temp test fails on the original code.

  3. Claude Assistant

    Now remove the temporary test file and review the final diff.

  4. Claude Assistant

    Checklist review:

    • Reproduced the reported error: Yes. The issue describes a race (no exception). I wrote a temporary TestNG test (TmpDedupRaceTest) that delays the async dedup cursor open and calls checkStatus() a second time. On the unmodified code it failed: the status remained Initialized (not Recovering) and the second call entered the enable path again, issuing a second asyncOpenCursor/replay. I also reproduced the missing retry after a Failed recovery.
    • Confirmed my fix resolves the error: Yes. With the change, the first checkStatus() immediately transitions to Recovering before starting recovery, the second concurrent call performs no new asyncOpenCursor (verified with Mockito times(1)) and instead waits on the in-flight recovery future; both futures complete when the single replay finishes and the status becomes Enabled. The retry test shows a Failed status is retried and reaches Enabled.
    • Edge cases: (a) Concurrent callers now get the in-flight recovery future rather than an immediately-completed one, so topic load doesn't proceed as if dedup were ready while replay is still running (which would itself allow duplicates). (b) Failed is retried only when the policy still requires dedup (shouldBeEnabled). (c) If asyncOpenCursor throws synchronously, the status no longer gets stuck in Recovering — it is set to Failed and the failure is returned asynchronously (no synchronous throw from a CompletableFuture method). (d) recoveryFuture is only read/written inside the existing synchronized (this) block, and a defensive thenAccept copy is returned so callers can't complete/cancel the internal future. (e) Disable/Removing paths are untouched.
    • Ran existing affected tests: Yes — BrokerMessageDeduplicationTest, MessageDuplicationTest, TopicDuplicationTest, DeduplicationDisabledBrokerLevelTest, ClientDeduplicationTest, MessageChunkingDeduplicationTest all pass (0 failures), plus :pulsar-broker:checkstyleMain and spotlessCheck. No existing tests were modified; my temporary test file was deleted, so the diff contains only the production fix.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.