ISSUE DESCRIPTION New isolatedDeclarations error with generic this parameter inference…
- User
ISSUE DESCRIPTION
New isolatedDeclarations error with generic
thisparameter inferenceSteps to reproduce
export function fromProviders<T>() { return { tearDown(this: {state: T}): void {} }; }Behavior with
typescript@6.0no error, .d.ts emitted is:
export declare function fromProviders<T>(): { tearDown(this: { state: T; }): void; };Behavior with
tsgoerror TS9008: Method must have an explicit return type annotation with --isolatedDeclarations.Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /typescript-go, current file: none) bash-$
Assistant
Reproduced. Now let's look at the diagnostics code.
Assistant
Now let's implement the fix in the pseudo type comparison.
Assistant
Now let's edit the comparison logic.
Assistant
Checklist review:
- Reproduced the reported error: Yes. I built and ran
tsgo --isolatedDeclarations --declarationon the exact snippet from the issue and goterror TS9008: Method must have an explicit return type annotation with --isolatedDeclarations. - Confirmed my fix resolves the error: Yes. After the change, the same input compiles with no errors and emits exactly the expected
.d.ts(tearDown(this: { state: T; }): void;). Root cause: the ID pseudo-type/checker-type equivalence check comparedlen(targetSig.parameters)against the pseudo signature's parameter list, but the checker keepsthisparameters out ofSignature.parameters(they live inSignature.thisParameter), so any method/function with athisparameter always looked mismatched and triggered an inference-fallback diagnostic. I now split off a leadingthispseudo parameter and compare it againsttargetSig.thisParameterseparately, in both the object-literal-method and single-call-signature branches. - Edge cases: I tested non-generic and generic
thistypes, object literal methods, function expressions (single call signature pseudo type),this: void, optional/rest params combined withthis,as constobject literals (property-signature form), class property function expressions, class methods, nested object literals withthis,thistypes referencing imported type aliases (import preserved), accessors declaringthis(already a syntax error, unaffected), untypedthis(still errors, unchanged), and pseudo-without-thisvs. target-with-contextual-this(behavior deliberately unchanged, verified identical before/after). For every valid case, the--isolatedDeclarationsoutput is byte-identical to the non-ID declaration emit. - Ran existing tests: Yes.
go test ./...(includinginternal/testrunnerTestLocal compiler baselines andinternal/checker) passes with no failures and no baseline changes;gofmt/go vetare clean.TestSubmodulecases aren't available in this checkout (no_submodules/TypeScript), so they couldn't run. I did not modify or add any tests.
- Reproduced the reported error: Yes. I built and ran
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →