Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-opus-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION New isolatedDeclarations error with generic this parameter inference…

  1. User

    ISSUE DESCRIPTION

    New isolatedDeclarations error with generic this parameter inference

    Steps to reproduce

    export function fromProviders<T>() {
      return {
        tearDown(this: {state: T}): void {}
      };
    }
    

    Behavior with typescript@6.0

    no error, .d.ts emitted is:

    export declare function fromProviders<T>(): {
        tearDown(this: {
            state: T;
        }): void;
    };
    

    link

    Behavior with tsgo

    error TS9008: Method must have an explicit return type annotation with --isolatedDeclarations.
    

    link

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /typescript-go, current file: none) bash-$

  2. Claude Assistant

    Reproduced. Now let's look at the diagnostics code.

  3. Claude Assistant

    Now let's implement the fix in the pseudo type comparison.

  4. Claude Assistant

    Now let's edit the comparison logic.

  5. Claude Assistant

    Checklist review:

    • Reproduced the reported error: Yes. I built and ran tsgo --isolatedDeclarations --declaration on the exact snippet from the issue and got error TS9008: Method must have an explicit return type annotation with --isolatedDeclarations.
    • Confirmed my fix resolves the error: Yes. After the change, the same input compiles with no errors and emits exactly the expected .d.ts (tearDown(this: { state: T; }): void;). Root cause: the ID pseudo-type/checker-type equivalence check compared len(targetSig.parameters) against the pseudo signature's parameter list, but the checker keeps this parameters out of Signature.parameters (they live in Signature.thisParameter), so any method/function with a this parameter always looked mismatched and triggered an inference-fallback diagnostic. I now split off a leading this pseudo parameter and compare it against targetSig.thisParameter separately, in both the object-literal-method and single-call-signature branches.
    • Edge cases: I tested non-generic and generic this types, object literal methods, function expressions (single call signature pseudo type), this: void, optional/rest params combined with this, as const object literals (property-signature form), class property function expressions, class methods, nested object literals with this, this types referencing imported type aliases (import preserved), accessors declaring this (already a syntax error, unaffected), untyped this (still errors, unchanged), and pseudo-without-this vs. target-with-contextual-this (behavior deliberately unchanged, verified identical before/after). For every valid case, the --isolatedDeclarations output is byte-identical to the non-ID declaration emit.
    • Ran existing tests: Yes. go test ./... (including internal/testrunner TestLocal compiler baselines and internal/checker) passes with no failures and no baseline changes; gofmt/go vet are clean. TestSubmodule cases aren't available in this checkout (no _submodules/TypeScript), so they couldn't run. I did not modify or add any tests.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.