Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-opus-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION auth: spurious REFRESHGENERATIONS bump on early-cancel in…

  1. User

    ISSUE DESCRIPTION

    auth: spurious _REFRESH_GENERATIONS bump on early-cancel in _coalesced_run_refresh_cmd

    Summary

    _coalesced_run_refresh_cmd in src/notebooklm/_auth/refresh.py (moved from src/notebooklm/auth.py in tier-10 PR-B-high #814, but the code is byte-identical to origin/main since tier-9 E #803) can bump _REFRESH_GENERATIONS[refresh_key] even when no real refresh happened, in a narrow cancel-before-await race.

    Reproducer (race condition)

    1. Caller invokes await _coalesced_run_refresh_cmd(refresh_key, path, profile) from the cancel-recovery loop in _fetch_tokens_with_refresh.
    2. Task is cancelled in the window between try: and the first with _REFRESH_STATE_LOCK: block inside _coalesced_run_refresh_cmd — so NO future is registered in _REFRESH_INFLIGHT_BY_LOOP[loop][refresh_key].
    3. Control jumps to except asyncio.CancelledError: in the caller.
    4. registry.get(refresh_key) returns None.
    5. The inner if inflight is None or inflight.done(): is taken; the if inflight is not None: block is skipped; subprocess_exc stays None; break.
    6. Outer if subprocess_exc is not None: is False, so no raise.
    7. Generation is bumped at the with _REFRESH_STATE_LOCK: ... max(existing, refresh_generation + 1) line, even though no subprocess ran.
    8. Then if caller_cancelled: raise asyncio.CancelledError().

    Impact

    A concurrent waiter on a different event loop sharing the same refresh_key would observe the phantom generation bump on its lock-re-acquire path, treat the storage as freshly-refreshed, and skip its own _run_refresh_cmd — proceeding to build_httpx_cookies_from_storage against STALE on-disk state.

    Bounded blast radius: the stale-storage caller will fail again on the next token fetch and trigger its own real refresh. No data corruption. But it's a wasted round-trip.

    Suggested fix (from CodeRabbit on PR #814)

    Track whether inflight was ever non-None during the cancel-recovery loop. Only bump generation if subprocess_exc is None AND observed_inflight is True. Or per the alternative suggestion: raise immediately when inflight is None at the top of the cancel handler (the subprocess never registered, so we can't be the leader-cancel-before-await case for an actually-running refresh).

    Why not fixed in PR #814

    That PR's scope was "extract verbatim from auth.py into _auth/refresh.py + facade-forward". Changing async semantics was explicitly out of scope (must_not_do). Filing here for a dedicated follow-up.

    References

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /notebooklm-py, current file: none) bash-$

  2. Claude Assistant

    Now let me implement the fix.

  3. Claude Assistant

    Good, only one copy. Now apply the fix:

  4. Claude Assistant

    Now update the bump block to be gated on refresh_succeeded.

  5. Claude Assistant

    I've completed the fix. Checklist review:

    • Reproduced the reported error: Yes. I wrote a temporary script (/tmp/repro.py) that patches _coalesced_run_refresh_cmd to raise CancelledError before registering an in-flight future (exactly the race window described), drives _fetch_tokens_with_refresh, and inspects _REFRESH_GENERATIONS. On the unmodified code it printed generation: 1 → phantom bump confirmed.
    • Confirmed the fix resolves it: Yes. With the patch the same script prints generation: 0 and still propagates CancelledError. I verified before/after by stashing/unstashing the change. The temp script was deleted afterward.
    • Edge cases: The cancel-recovery loop now distinguishes three cases: (a) inflight is None → no subprocess ever registered → break with refresh_succeeded=False, no bump, CancelledError still propagates; (b) inflight.done() and cancelled/failed → subprocess_exc set, no bump, existing failure semantics preserved; (c) inflight.done() with no exception → refresh_succeeded=True, bump preserved so other loops still short-circuit (the PR #621 behavior). The normal non-cancelled success path sets refresh_succeeded=True right after the await, so the bump is unchanged there. The bump itself remains under _REFRESH_STATE_LOCK with max(...) cross-loop protection. Non-cancel exceptions still raise unchanged.
    • Existing tests: Ran the concurrency/lock/save-race suites (64 passed), the full auth/refresh-related selection (794 passed, 3 skipped), and the entire test suite. The full suite has 11 pre-existing failures + 21 errors in unrelated CLI tests; I diffed the FAILED/ERROR lists before and after my change and they are byte-identical, so nothing was broken by this fix. ruff check, ruff format --check, and mypy all pass on the modified file. I also added a CHANGELOG entry and made no modifications to any test.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.