ISSUE DESCRIPTION Admitted workloads are requeued too early when a worker disconnects An…
- User
ISSUE DESCRIPTION
Admitted workloads are requeued too early when a worker disconnects
An admitted workload must remain ready during a temporary worker disconnect and be retried only after the configured worker-loss timeout. Reconnection with the same configuration must restore processing without affecting other connected workers.
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /kueue, current file: none) bash-$
Assistant
Now let me implement the fix.
Assistant
Now let me add the helper function after
reconcileGroup.Assistant
Now update the
Reconcilepath for when no worker cluster is connected at all:Assistant
I've completed my analysis and fix. Let me do a final review of the change:
Assistant
The fix is complete. Here's my checklist review:
1. If an error was reported in the issue description, I have successfully reproduced it. Yes. The issue is behavioral (no stack trace). I traced the root cause in
pkg/controller/admissionchecks/multikueue/workload.go: the "keep the workload Ready while the reserving worker is lost" window was measured fromacs.LastTransitionTime, which is the time the MultiKueue admission check transitioned toReady(admission time) —workload.SetAdmissionCheckStateonly refreshes that timestamp on a state change, so for any workload admitted longer thanworkerLostTimeoutthe window is already expired. I wrote a temporary unit test (built on the existing fake-client harness) that admits a workload onworker2, then disconnectsworker2(client reconnecting / client removed +MultiKueueClusterActive=Falseone minute ago) and asserts the check staysReady. Against the unmodified code it failed withwant "Ready" got "Retry" (message "Reserving remote lost")for every temporary-disconnect case — i.e., the workload was requeued immediately.2. If an error was reported in the issue description, I have confirmed that my fix resolves the error. Yes. With the fix, the same temporary test showed: disconnect 1 min ago → stays
Ready, requeued after 4m (5m timeout); reconnecting worker with cluster stillActive→ staysReady, requeue after 5m; disconnected longer than the timeout →Retry; all workers disconnected (previously a permanent reconcile error) →Readywhile recent,Retryafter the timeout; deletedMultiKueueCluster→Retry. I also verified with a temporary test that reconnecting a worker with the same configuration recreates its client, setsActive=Trueagain, and leaves the other connected worker untouched. Both temporary test files were removed before submitting.3. I have thought about edge cases and made sure my fix handles them as well. Yes: unknown reserving cluster (
status.clusterNameempty) and connected-but-missing-remote-workload keep the previousLastTransitionTimesemantics (so a genuinely lost remote workload is still retried); the disconnect instant is taken from the persistedMultiKueueClusterActive=Falsetransition time so it survives a manager restart and repeated failed reconnects (the timestamp is not reset by identical condition updates); the short race window between detecting a disconnect and the cluster status update is treated as "just lost" so no premature requeue; a deletedMultiKueueCluster(no client, no object) falls back to the old behavior so quota is eventually released; the new "no connected clusters" path is guarded by!isDeleted,Readystate, quota reservation and not-finished so deletion/cleanup paths keep their error-retry behavior; the clock is now taken fromw.clockfor testability.4. I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. Yes:
go test ./pkg/...(includingpkg/controller/admissionchecks/multikueueandpkg/workload) andgo test ./apis/...all pass;go build ./...,go vet ./pkg/controller/admissionchecks/...andgo vet ./test/integration/multikueue/...are clean;gofmtreports no issues and no added line exceeds the repo's 200-char golines limit. Integration/e2e suites cannot run here (no envtest/kind assets), but they compile. I did not modify or add any test files.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →