Skip to content
TheChatArchiveThe Chat Archive
Claudeclaude-opus-5· anthropicHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION "Extract function" incorrectly returns Nil when extracting from…

  1. User

    ISSUE DESCRIPTION

    "Extract function" incorrectly returns Nil when extracting from anonymous function

    When trying to extract a function from within an anonymous function, the extracted function always returns Nil, even when incorrect.

    For example:

    fn wibble() {
      let wobble = fn() {
        echo "wibble"
        echo "wobble" // extracting this line
      }
    }
    

    is turned into

    fn wibble() {
      let wobble = fn() {
        echo "wibble"
        function()
      }
    }
    
    fn function() -> Nil {
      echo "wobble"
      Nil // this is incorrect!
    }
    

    I have a fix for it.

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /gleam, current file: none) bash-$

  2. Claude Assistant

    Now let me add the visitor method in the ExtractFunction Visit impl, near visit_typed_expr_block.

  3. Claude Assistant

    Now let's run the temp test and the full extract function test suite.

  4. Claude Assistant

    All checks are done. Let me go through the checklist:

    • Reproduced the reported error: Yes. I added a temporary snapshot test in language-server/src/tests/action.rs selecting the last statement of an anonymous function's body. Before the fix, the code action produced fn function() -> Nil { echo "wobble" \n Nil } / fn function(a: Int) -> Nil { a + 1 \n Nil }, exactly matching the issue.
    • Confirmed the fix resolves the error: Yes. After adding a visit_typed_expr_fn implementation to ExtractFunction's visitor (which tracks the anonymous function body's last statement as being in tail position, saving/restoring the previous value like the block visitor does), the same selections now produce fn function() -> String { echo "wobble" } and fn function(a: Int) -> Int { a + 1 }.
    • Edge cases: I verified with temporary tests: extracting the tail of a use callback body (now correctly returns the value's type), extracting a statement that is not in tail position inside an anonymous fn (still correctly returns the bound variable), extracting inside a block inside a case inside an anonymous fn (unchanged, correct), and function captures (wobble(_, 1) — still extracted correctly as an expression). The saved/restored last_statement_location ensures statements following an anonymous function in an outer scope aren't misclassified.
    • Existing tests pass: Yes — the full gleam-language-server suite runs with 1514 passed / 0 failed, no snapshots changed, cargo fmt --check and cargo clippy are clean. All temporary tests and generated .snap.new files were removed; only code_action.rs and a CHANGELOG.md entry remain modified.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.