ISSUE DESCRIPTION "Extract function" incorrectly returns Nil when extracting from…
- User
ISSUE DESCRIPTION
"Extract function" incorrectly returns
Nilwhen extracting from anonymous functionWhen trying to extract a function from within an anonymous function, the extracted function always returns
Nil, even when incorrect.For example:
fn wibble() { let wobble = fn() { echo "wibble" echo "wobble" // extracting this line } }is turned into
fn wibble() { let wobble = fn() { echo "wibble" function() } } fn function() -> Nil { echo "wobble" Nil // this is incorrect! }I have a fix for it.
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /gleam, current file: none) bash-$
Assistant
Now let me add the visitor method in the
ExtractFunctionVisit impl, nearvisit_typed_expr_block.Assistant
Now let's run the temp test and the full extract function test suite.
Assistant
All checks are done. Let me go through the checklist:
- Reproduced the reported error: Yes. I added a temporary snapshot test in
language-server/src/tests/action.rsselecting the last statement of an anonymous function's body. Before the fix, the code action producedfn function() -> Nil { echo "wobble" \n Nil }/fn function(a: Int) -> Nil { a + 1 \n Nil }, exactly matching the issue. - Confirmed the fix resolves the error: Yes. After adding a
visit_typed_expr_fnimplementation toExtractFunction's visitor (which tracks the anonymous function body's last statement as being in tail position, saving/restoring the previous value like the block visitor does), the same selections now producefn function() -> String { echo "wobble" }andfn function(a: Int) -> Int { a + 1 }. - Edge cases: I verified with temporary tests: extracting the tail of a
usecallback body (now correctly returns the value's type), extracting a statement that is not in tail position inside an anonymous fn (still correctly returns the bound variable), extracting inside a block inside acaseinside an anonymous fn (unchanged, correct), and function captures (wobble(_, 1)— still extracted correctly as an expression). The saved/restoredlast_statement_locationensures statements following an anonymous function in an outer scope aren't misclassified. - Existing tests pass: Yes — the full
gleam-language-serversuite runs with 1514 passed / 0 failed, no snapshots changed,cargo fmt --checkandcargo clippyare clean. All temporary tests and generated.snap.newfiles were removed; onlycode_action.rsand aCHANGELOG.mdentry remain modified.
- Reproduced the reported error: Yes. I added a temporary snapshot test in
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →