ISSUE DESCRIPTION Removing a registered or subscribed service leaves stale local…
- User
ISSUE DESCRIPTION
Removing a registered or subscribed service leaves stale local metadata
After a successful unregister or unsubscribe operation, the corresponding provider or consumer URL must no longer participate in local metadata, service matching, or revision calculation. Removing one URL must preserve unrelated registrations. If the remote operation fails, local metadata must not be removed as though the operation succeeded.
Interface
Type: Function Name: RemoveService Path: metadata/metadata.go Input: registryId string, url *common.URL Output: (no return value) Description: Removes a provider service URL from the local metadata for the given registry. Use this during unregister flows to keep the in-memory application-level metadata consistent with the actual exported services.
Type: Function Name: RemoveSubscribeURL Path: metadata/metadata.go Input: registryId string, url *common.URL Output: (no return value) Description: Removes a subscribed service URL from the local metadata for the given registry. Use this during unsubscribe flows to ensure stale subscribed URLs are cleaned from the application-level metadata.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /dubbo-go, current file: none) bash-$
Assistant
Now let me implement the changes.
Assistant
Build passes. Now run relevant tests.
Assistant
All checks pass. Let me review the checklist:
- Reproduced reported error: The issue is a missing-behavior report rather than a crash. I confirmed the gap:
metadata/metadata.goonly hadAddService/AddSubscribeURL(no removal API), andserviceDiscoveryRegistry.UnRegister/UnSubscribenever cleaned local application-level metadata. I wrote a temporary test (tmp_remove_test.go) that showed exported/subscribed URLs andServicesentries remained after unregister/unsubscribe. - Confirmed the fix resolves it: With the new
metadata.RemoveService/metadata.RemoveSubscribeURLand the wiring intoUnRegister/UnSubscribe, the temp test passed: unrelated registration (url2) was preserved, the removed URL disappeared fromGetExportedServiceURLs()/Services(so revision recalculation no longer includes it), the subscribed URL was cleaned, and when the remote unregister failed the metadata was left untouched. Temp test file was deleted afterwards. - Edge cases: nil URL guards in
RemoveService/RemoveSubscribeURL; no-op when the registry id has no metadata yet (no map entry created); removal by URL content (not just pointer identity) since callers may passurl.Clone()(e.g.RegistryDirectory); theServicesentry is only deleted when no remaining exported URL matches the same match key, so multiple URLs of the same service are handled; service-key bucket is deleted when it becomes empty; metadata removal only happens after the remote unregister/unsubscribe succeeds (errors returned early). - Ran existing tests:
go test ./metadata/... ./registry/...all pass, plusgo build ./...andgo veton changed packages are clean. No existing tests were modified or added.
- Reproduced reported error: The issue is a missing-behavior report rather than a crash. I confirmed the gap:
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →