Skip to content
TheChatArchiveThe Chat Archive
xiaomi/mimo-v2.5-pro· unknownHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION [Bug] WebSocket ReaderHandler returns 500 for invalid messageId query…

  1. User

    ISSUE DESCRIPTION

    [Bug] WebSocket ReaderHandler returns 500 for invalid messageId query parameter

    Search before reporting

    • I searched in the issues and found nothing similar.

    Read release policy

    • I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

    User environment

    Broker Version 4.0.7 Any broker OS Any broker Java version Any WebSocket client

    Issue Description

    Minimal reproduction steps

    Connect to the WebSocket reader endpoint with an invalid messageId query parameter.

    Two examples that both trigger the bug:

    1. An improperly URL-encoded base64 message ID that includes a + which the server interprets as a space (e.g. CJCj6QEQ+UQwAA== becomes CJCj6QEQ UQwAA==).

    2. An arbitrary non-base64 string: ?messageId=invalidMessageId

    What did you expect to see?

    HTTP 400 Bad Request.

    What did you see instead?

    HTTP 500 Internal Server Error in both cases.

    Case 1 — IllegalArgumentException from Base64.getDecoder().decode():

    WARN  org.apache.pulsar.websocket.ReaderHandler - [REDACTED] Failed in creating reader on topic persistent://REDACTED/REDACTED/REDACTED
    java.lang.IllegalArgumentException: Illegal base64 character 20
    	at java.base/java.util.Base64$Decoder.decode0(Unknown Source) ~[?:?]
    	at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[?:?]
    	at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[?:?]
    	at org.apache.pulsar.websocket.ReaderHandler.getMessageId(ReaderHandler.java:348) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.<init>(ReaderHandler.java:95) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.WebSocketReaderServlet.lambda$configure$0(WebSocketReaderServlet.java:44) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    

    Case 2 — IOException wrapping IndexOutOfBoundsException from MessageIdImpl.fromByteArray():

    WARN  org.apache.pulsar.websocket.ReaderHandler - [REDACTED] Failed in creating reader on topic persistent://REDACTED/REDACTED/REDACTED
    java.io.IOException: java.lang.IndexOutOfBoundsException: readerIndex(5) + length(641882) exceeds writerIndex(12): UnpooledHeapByteBuf(ridx: 5, widx: 12, cap: 12/12)
    	at org.apache.pulsar.client.impl.MessageIdImpl.fromByteArray(MessageIdImpl.java:93) ~[org.apache.pulsar-pulsar-client-original-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.getMessageId(ReaderHandler.java:348) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.<init>(ReaderHandler.java:95) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.WebSocketReaderServlet.lambda$configure$0(WebSocketReaderServlet.java:44) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    Caused by: java.lang.IndexOutOfBoundsException: readerIndex(5) + length(641882) exceeds writerIndex(12): UnpooledHeapByteBuf(ridx: 5, widx: 12, cap: 12/12)
    	at io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1442) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at io.netty.buffer.AbstractByteBuf.checkReadableBytes(AbstractByteBuf.java:1428) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at io.netty.buffer.AbstractByteBuf.skipBytes(AbstractByteBuf.java:971) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at org.apache.pulsar.common.api.proto.LightProtoCodec.skipUnknownField(LightProtoCodec.java:264) ~[org.apache.pulsar-pulsar-common-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.common.api.proto.MessageIdData.parseFrom(MessageIdData.java:304) ~[org.apache.pulsar-pulsar-common-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.client.impl.MessageIdImpl.fromByteArray(MessageIdImpl.java:91) ~[org.apache.pulsar-pulsar-client-original-4.0.7.jar:4.0.7]
    

    Details

    ReaderHandler.getMessageId() performs no validation on the messageId query parameter before passing it to Base64.getDecoder().decode() and MessageIdImpl.fromByteArray().

    ReaderHandler's constructor catches Exception during setup but hardcodes HttpServletResponse.SC_INTERNAL_SERVER_ERROR in the error response. ConsumerHandler and ProducerHandler both call AbstractWebSocketHandler.getErrorCode(e) instead, which maps IllegalArgumentException to SC_BAD_REQUEST (400).

    Error messages

    **Case 1** — `IllegalArgumentException` from `Base64.getDecoder().decode()`:
    
    WARN  org.apache.pulsar.websocket.ReaderHandler - [REDACTED] Failed in creating reader on topic persistent://REDACTED/REDACTED/REDACTED
    java.lang.IllegalArgumentException: Illegal base64 character 20
    	at java.base/java.util.Base64$Decoder.decode0(Unknown Source) ~[?:?]
    	at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[?:?]
    	at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[?:?]
    	at org.apache.pulsar.websocket.ReaderHandler.getMessageId(ReaderHandler.java:348) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.<init>(ReaderHandler.java:95) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.WebSocketReaderServlet.lambda$configure$0(WebSocketReaderServlet.java:44) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    
    
    **Case 2** — `IOException` wrapping `IndexOutOfBoundsException` from `MessageIdImpl.fromByteArray()`:
    
    WARN  org.apache.pulsar.websocket.ReaderHandler - [REDACTED] Failed in creating reader on topic persistent://REDACTED/REDACTED/REDACTED
    java.io.IOException: java.lang.IndexOutOfBoundsException: readerIndex(5) + length(641882) exceeds writerIndex(12): UnpooledHeapByteBuf(ridx: 5, widx: 12, cap: 12/12)
    	at org.apache.pulsar.client.impl.MessageIdImpl.fromByteArray(MessageIdImpl.java:93) ~[org.apache.pulsar-pulsar-client-original-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.getMessageId(ReaderHandler.java:348) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.ReaderHandler.<init>(ReaderHandler.java:95) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.websocket.WebSocketReaderServlet.lambda$configure$0(WebSocketReaderServlet.java:44) ~[org.apache.pulsar-pulsar-websocket-4.0.7.jar:4.0.7]
    Caused by: java.lang.IndexOutOfBoundsException: readerIndex(5) + length(641882) exceeds writerIndex(12): UnpooledHeapByteBuf(ridx: 5, widx: 12, cap: 12/12)
    	at io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1442) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at io.netty.buffer.AbstractByteBuf.checkReadableBytes(AbstractByteBuf.java:1428) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at io.netty.buffer.AbstractByteBuf.skipBytes(AbstractByteBuf.java:971) ~[io.netty-netty-buffer-4.1.127.Final.jar:4.1.127.Final]
    	at org.apache.pulsar.common.api.proto.LightProtoCodec.skipUnknownField(LightProtoCodec.java:264) ~[org.apache.pulsar-pulsar-common-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.common.api.proto.MessageIdData.parseFrom(MessageIdData.java:304) ~[org.apache.pulsar-pulsar-common-4.0.7.jar:4.0.7]
    	at org.apache.pulsar.client.impl.MessageIdImpl.fromByteArray(MessageIdImpl.java:91) ~[org.apache.pulsar-pulsar-client-original-4.0.7.jar:4.0.7]
    

    Reproducing the issue

    Connect to the WebSocket reader endpoint with an invalid messageId query parameter.

    Two examples that both trigger the bug:

    1. An improperly URL-encoded base64 message ID that includes a + which the server interprets as a space (e.g. CJCj6QEQ+UQwAA== becomes CJCj6QEQ UQwAA==).

    2. An arbitrary non-base64 string: ?messageId=invalidMessageId

    Additional information

    ReaderHandler.getMessageId() performs no validation on the messageId query parameter before passing it to Base64.getDecoder().decode() and MessageIdImpl.fromByteArray().

    ReaderHandler's constructor catches Exception during setup but hardcodes HttpServletResponse.SC_INTERNAL_SERVER_ERROR in the error response. ConsumerHandler and ProducerHandler both call AbstractWebSocketHandler.getErrorCode(e) instead, which maps IllegalArgumentException to SC_BAD_REQUEST (400).

    Are you willing to submit a PR?

    • I'm willing to submit a PR!

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /pulsar, current file: none) bash-$

  2. Assistant

    I'll start by exploring the repository structure to understand the codebase and locate the relevant files mentioned in the issue. First, let's check the current directory and find the websocket module.

  3. Assistant

    Let me find the actual websocket source files in the repository, not the test files.

  4. Assistant

    Let me look at the ReaderHandler.java file to understand the issue and then look at ConsumerHandler and ProducerHandler to see how they handle errors.

  5. Assistant

    Let me scroll down to see the getMessageId method and the error handling in the constructor.

  6. Assistant

    Let me scroll to find the getMessageId method and the constructor's error handling.

  7. Assistant

    Now let me see the constructor error handling (around line 88-180):

  8. Assistant

    Let me look at AbstractWebSocketHandler to see the getErrorCode method:

  9. Assistant

    Let me find the getErrorCode method in AbstractWebSocketHandler.

  10. Assistant

    Let me look at the getErrorCode method.

  11. Assistant

    Now let me check how ConsumerHandler and ProducerHandler handle their exceptions:

  12. Assistant

    I can see the issue now. Let me look at the relevant lines in the constructor of ReaderHandler. At line 138, it hardcodes HttpServletResponse.SC_INTERNAL_SERVER_ERROR instead of using getErrorCode(e) like ConsumerHandler does.

    Let me now check if there's an existing test for ReaderHandler that I can look at:

  13. Assistant

    Now I have a clear understanding of the issue. Let me implement the fix by changing the hardcoded HttpServletResponse.SC_INTERNAL_SERVER_ERROR to use getErrorCode(e) in the ReaderHandler's catch block.

    Now I have a clear understanding of the issue. Let me implement the fix by changing the hardcoded HttpServletResponse.SC_INTERNAL_SERVER_ERROR to use getErrorCode(e) in the ReaderHandler's catch block.

  14. Assistant

    Let me verify the change is correct:

  15. Assistant

    The change looks correct. Now let me verify the diff and check if there are any existing tests that might be affected:

  16. Assistant

    Let me check if there are tests related to the ReaderHandler:

  17. Assistant

    Let me look at the existing test to understand what's already being tested:

  18. Assistant

    Let me run the existing test to make sure it still passes:

  19. Assistant

    Let me find the correct module name for the websocket module.

  20. Assistant

    Let me check the pom.xml in the websocket directory.

  21. Assistant

    This is a Gradle project. Let me check the build configuration and try to run the test using Gradle:

  22. Assistant

    Let me try running the test using Gradle.

  23. Assistant

    The existing tests pass. Let me also verify the ConsumerHandler and ProducerHandler patterns to confirm my change is consistent:

  24. Assistant

    The ConsumerHandler uses getErrorCode(e) and getErrorMessage(e), while the ProducerHandler uses just getErrorCode(e) but with its own error message format. Let me check what ProducerHandler uses.

  25. Assistant

    Looking at getErrorCode, I notice that IOException (Case 2) would still fall through to the default 500. Let me also fix the getMessageId method to wrap exceptions from invalid input as IllegalArgumentException so that both cases correctly return 400:

  26. Assistant

    Now let me update the getMessageId method to wrap exceptions as IllegalArgumentException:

  27. Assistant

    Let me verify the full diff and run the tests again to make sure everything is correct:

  28. Assistant

    The diff looks good. Now let me run the tests again to make sure everything passes:

  29. Assistant

    Let me also check if there are any other websocket tests that might be relevant:

  30. Assistant

    Let me check which test failed and whether it's related to our changes:

  31. Assistant

    The failing test PingPongSupportTest is unrelated to our changes (it's about websocket ping/pong). Let me verify by checking if this test was already failing before my changes:

  32. Assistant

    Good, the PingPongSupportTest was already failing before my changes. Let me restore my changes:

  33. Assistant

    Let me run only the ReaderHandlerTest to confirm our changes don't break it:

  34. Assistant

    Let me also check the compilation of the project to make sure there are no compilation errors:

  35. Assistant

    Let me verify the final state of the changed file:

  36. Assistant

    Let me also verify the getMessageId method:

  37. Assistant

    Now let me run the ReaderHandlerTest one more time to confirm everything is working:

  38. Assistant

    All tests pass. Let me now review the changes one final time and provide a summary:

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.