ISSUE DESCRIPTION Removing a registered or subscribed service leaves stale local…
- User
ISSUE DESCRIPTION
Removing a registered or subscribed service leaves stale local metadata
After a successful unregister or unsubscribe operation, the corresponding provider or consumer URL must no longer participate in local metadata, service matching, or revision calculation. Removing one URL must preserve unrelated registrations. If the remote operation fails, local metadata must not be removed as though the operation succeeded.
Interface
Type: Function Name: RemoveService Path: metadata/metadata.go Input: registryId string, url *common.URL Output: (no return value) Description: Removes a provider service URL from the local metadata for the given registry. Use this during unregister flows to keep the in-memory application-level metadata consistent with the actual exported services.
Type: Function Name: RemoveSubscribeURL Path: metadata/metadata.go Input: registryId string, url *common.URL Output: (no return value) Description: Removes a subscribed service URL from the local metadata for the given registry. Use this during unsubscribe flows to ensure stale subscribed URLs are cleaned from the application-level metadata.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /dubbo-go, current file: none) bash-$
- Assistant
I'll start by exploring the repository structure to understand the codebase and locate the relevant files.
- Assistant
Let me look at the specific file mentioned in the issue: metadata/metadata.go
- Assistant
Let me explore the info package to understand the MetadataInfo structure.
- Assistant
Let me find the info package.
- Assistant
Let me check the metadata_info.go file to understand the structure.
- Assistant
Now let me check the test file for metadata.go to understand the expected behavior:
- Assistant
Let me also check the metadata_info_test.go to understand how RemoveService and RemoveSubscribeURL are tested at the info level:
- Assistant
Now I understand the issue. The
MetadataInfotype inmetadata/info/metadata_info.goalready hasRemoveServiceandRemoveSubscribeURLmethods, but the package-levelmetadata.gofile is missing the correspondingRemoveServiceandRemoveSubscribeURLfunctions. Let me check if there are existing tests that expect these functions: - Assistant
Let me check if there are tests expecting these functions:
- Assistant
Let me check if there are tests for the package-level RemoveService and RemoveSubscribeURL in metadata_test.go:
- Assistant
Now I have a clear picture of the issue. The
MetadataInfotype already hasRemoveServiceandRemoveSubscribeURLmethods, but the package-level functionsRemoveServiceandRemoveSubscribeURLinmetadata/metadata.goare missing. I need to add them following the same pattern asAddServiceandAddSubscribeURL. - Assistant
Now I need to add the
RemoveServiceandRemoveSubscribeURLfunctions tometadata/metadata.go. I'll add them after the existingAddSubscribeURLfunction. - Assistant
Good. Now let me verify the code compiles and run the existing tests:
- Assistant
Let me set the environment and try again.
- Assistant
Let me set HOME and other env vars.
- Assistant
Good, it compiles. Now let me run the existing tests:
- Assistant
All tests pass. Let me now verify my implementation is correct by creating a quick test script to confirm the behavior:
- Assistant
All tests pass. Let me verify the final state of the file and clean up:
- Assistant
Let me review the final diff to make sure everything looks correct.
- Assistant
Let me run the full test suite one more time to make sure everything passes:
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →