ISSUE DESCRIPTION [BUG] Glue BatchDeleteTable is unsupported Service AWS Glue AWS API…
- User
ISSUE DESCRIPTION
[BUG] Glue BatchDeleteTable is unsupported
Service
AWS API Action
Expected behavior
AWS behavior supports
BatchDeleteTable. When the request contains one existing table and one missing table, AWS deletes the existing table and returns anErrorsentry for the missing table.AWS behavior verified with AWS CLI:
{ "Errors": [ { "TableName": "missing_table", "ErrorDetail": { "ErrorCode": "EntityNotFoundException", "ErrorMessage": "Table missing_table not found" } } ] }A subsequent
GetTablefor the existing table returnsEntityNotFoundException.Actual behavior
Floci
floci/floci:1.5.22rejectsBatchDeleteTableas an unsupported action.aws: [ERROR]: An error occurred (InvalidAction) when calling the BatchDeleteTable operation: Action BatchDeleteTable is not supportedReproduction
endpoint=http://localhost:4566 export AWS_ACCESS_KEY_ID=<redacted-secret> AWS_SECRET_ACCESS_KEY=<redacted-secret> AWS_DEFAULT_REGION=us-east-1 db=test_floci_batch_delete aws --endpoint-url "$endpoint" glue create-database --database-input "Name=$db" aws --endpoint-url "$endpoint" glue create-table \ --database-name "$db" \ --table-input 'Name=existing_table,StorageDescriptor={Columns=[{Name=id,Type=int}]}' aws --endpoint-url "$endpoint" glue batch-delete-table \ --database-name "$db" \ --tables-to-delete existing_table missing_tableEnvironment
- Floci version / image tag:
floci/floci:1.5.22 - Java SDK version (if applicable): AWS CLI
- How you're running Floci (Docker / native /
mvn quarkus:dev): Docker
Interface
Type: Function Name: batchDeleteTables Path: src/main/java/io/github/hectorvent/floci/services/glue/GlueService.java Input: String databaseName, List tableNames Output: List<GlueService.BatchDeleteTableError> Description: Deletes multiple tables by name within a database, skipping and reporting errors for any tables that are not found. Use this to process the
BatchDeleteTableAWS Glue API action.ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /floci, current file: none) bash-$
- Floci version / image tag:
- Assistant
I'll start by exploring the repository to understand its structure and locate the Glue service implementation. Let's first list the root directory.
- Assistant
Let me look at the directory structure more specifically for the Glue service.
- Assistant
Let me look at the GlueService.java file to understand the current implementation and where batchDeleteTable should be added.
- Assistant
Let me look at the GlueService.java file to understand its structure.
- Assistant
Now let me find the API handler/controller for Glue that dispatches API actions:
- Assistant
Let me look at how the Glue API actions are dispatched:
- Assistant
Let me look at the GlueJsonHandler.java to understand how actions are dispatched.
- Assistant
Now I understand the structure. I need to:
- Add a
BatchDeleteTablecase to theGlueJsonHandler.javaswitch statement - Add a
batchDeleteTablesmethod toGlueService.javawith aBatchDeleteTableErrorinner record
Let me also check how existing tests are structured and look at the GlueServiceTest:
- Add a
- Assistant
Now I understand the structure. I need to:
- Add a
batchDeleteTablesmethod toGlueService.javawith aBatchDeleteTableErrorrecord - Add a
BatchDeleteTablecase toGlueJsonHandler.java
Let me first add the
BatchDeleteTableErrorrecord andbatchDeleteTablesmethod to GlueService: - Add a
- Assistant
Let me go to the end of the file:
- Assistant
Now let me look at the existing
deleteTablemethod more closely and understand the behavior: - Assistant
I see the existing
deleteTablemethod doesn't throw an error if the table doesn't exist (it just deletes the key and partitions). This is fine for the regularDeleteTableaction, but forBatchDeleteTable, we need to report errors for missing tables.Now I need to:
-
Add a
batchDeleteTablesmethod toGlueServicethat:- Takes database name and list of table names
- For each table, check if it exists
- If it exists, delete it (including partitions)
- If it doesn't exist, add an error to the result
- Return a list of
BatchDeleteTableError(empty if all succeed)
-
Add a
BatchDeleteTablecase toGlueJsonHandlerthat calls this method and formats the response.
Let me also need to add a
BatchDeleteTableErrorrecord toGlueService.Let me implement this step by step. First, I'll add the
batchDeleteTablesmethod and theBatchDeleteTableErrorrecord toGlueService.Now let me look at the AwsJson11Controller to understand how actions are dispatched:
-
- Assistant
Now I have a good understanding of the codebase. Let me implement the
BatchDeleteTablefeature. I need to:- Add a
batchDeleteTablesmethod andBatchDeleteTableErrorrecord toGlueService.java - Add a
BatchDeleteTablecase toGlueJsonHandler.java
Let me start with GlueService.java:
- Add a
- Assistant
Good, now let me add the
BatchDeleteTablecase toGlueJsonHandler.java: - Assistant
Now I need to add the
BatchDeleteTablecase to the switch statement. Let me add it after theDeleteTablecase: - Assistant
Now let me verify the changes compile and the existing tests pass. First, let me build the project:
- Assistant
Let me find the pom.xml to understand the build structure.
- Assistant
Let me try to compile the project using Maven.
- Assistant
Build succeeds. Now let me run the existing Glue tests:
- Assistant
All 24 existing tests pass. Now let me also check the compatibility test for Glue to make sure it still works:
- Assistant
Now let me create a quick test to verify the BatchDeleteTable functionality works correctly. I'll write a simple test that verifies:
- Deleting existing tables works
- Deleting missing tables returns errors
- The combination of existing and missing tables works correctly
Let me create a temporary test script.
- Assistant
Let me verify the implementation by examining the logic more carefully. Let me look at the code I wrote:
- Assistant
Let me verify the GlueJsonHandler changes:
- Assistant
Now let me check if the AWS Glue action mapping in the service catalog recognizes
BatchDeleteTable. Let me look at how actions are registered: - Assistant
Let me check how the service catalog works to see if it might need registration:
- Assistant
Let me check the service catalog to understand how actions are routed.
- Assistant
Let me check the service descriptor for Glue to understand the target prefix:
- Assistant
Good. I can see that for Glue, the target prefix is
"AWSGlue.". So the target header would be"AWSGlue.BatchDeleteTable", and the action extracted would be"BatchDeleteTable". The switch statement in GlueJsonHandler handles this action correctly.Now let me run all the Glue tests to make sure everything passes:
- Assistant
All 34 tests pass. Let me verify my changes look correct by reviewing the diff:
- Assistant
The implementation looks good. Let me also run a broader set of tests to make sure nothing is broken:
- Assistant
All 152 Glue-related tests pass. Let me now verify the changes one more time by looking at the final state of both files:
- Assistant
Let me clean up the temporary test file and then submit:
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →