ISSUE DESCRIPTION [BUG] Duplicate activate_skill tool definition error when using…
- User
ISSUE DESCRIPTION
[BUG] Duplicate
activate_skilltool definition error when usingAgenticServices.createAgenticSystem()Describe the bug When creating an agentic system withAgenticServices.createAgenticSystem(), even with a single agent, the application throws anIllegalConfigurationException: Duplicated definition for tool: activate_skillduring execution, caused by multiple registrations of non-dynamicToolProviderinstances.Log and Stack trace
Caused by: dev.langchain4j.service.IllegalConfigurationException: Duplicated definition for tool: activate_skill at dev.langchain4j.service.tool.ToolService.addTools(ToolService.java:398) at dev.langchain4j.service.tool.ToolService.lambda$createContextFromStaticToolsAndProviders$0(ToolService.java:378) at java.base/java.lang.Iterable.forEach(Iterable.java:75) at dev.langchain4j.service.tool.ToolService.createContextFromStaticToolsAndProviders(ToolService.java:371) at dev.langchain4j.service.tool.ToolService.createContext(ToolService.java:338) at dev.langchain4j.service.DefaultAiServices$1.invoke(DefaultAiServices.java:260) at dev.langchain4j.service.DefaultAiServices$1.invoke(DefaultAiServices.java:154) at jdk.proxy2/jdk.proxy2.$Proxy5.test(Unknown Source) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) ... 5 moreTo Reproduce
public class Main { public static void main(String[] args) { var result=AgenticServices.createAgenticSystem(FooAgent.class).test(); // var result=AgenticServices.agentBuilder(FooAgent.class).build().test(); System.out.println(result); } public interface FooAgent { @Agent @UserMessage("Hello") String test(); @ToolProviderSupplier static ToolProvider testTool() { return Skills.builder() .skills(Skill.builder().name("test").description("test").content("test").build()) .build().toolProvider(); } @ChatModelSupplier static ChatModel chatModel() { return OpenAiChatModel.builder() .baseUrl("http://192.168.31.32:8000/v1") .apiKey("none") .modelName("qwen3.6") .logRequests(true) .logResponses(true) .build(); } } }Expected behavior The agentic system should run successfully, properly deduplicating tools (including the built-in
activate_skilltool) when registering non-dynamicToolProviderinstances.Please complete the following information:
- LangChain4j version: latest agentic snapshot
- LLM(s) used: Qwen 3.6 (via OpenAiChatModel)
- Java version: 25
- Spring Boot version (if applicable): N/A
Additional context The bug is caused by
createAgenticSystemregistering non-dynamicToolProviderinstances multiple times. Theactivate_skilltool is automatically added for everySkillProviderinstance, leading to duplicate registration even with a single agent.Interface
Type: Function Name: createAgenticSystem Path: langchain4j-agentic/src/main/java/dev/langchain4j/agentic/AgenticServices.java Input: Class agentServiceClass, AgentConfigurator agentConfigurator Output: T (the created agentic system instance of the requested type) Description: Creates an agentic system from a declarative agent service class, applying the provided configurator to each agent. This overload resolves the default chat model from the agent class and deduplicates tool registrations across the system.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /langchain4j, current file: none) bash-$
- Assistant
I'll start by exploring the repository structure and the relevant
AgenticServicescode to understand howcreateAgenticSystemregisters tools. - Assistant
Next I'll inspect
createAgenticSystemand how skills/activate_skillget registered as tools. - Assistant
rg is not available, let me use grep instead.
- Assistant
Let me open the file around createAgenticSystem methods.
- Assistant
Let me search for ToolProviderSupplier and how tools are configured.
- Assistant
Looking at AgentBuilder constructor - it calls configureAgent, and createAgenticSystem may call it again.
- Assistant
I've confirmed double
configureAgentregistration. Checking recent changes and related skill/activate_skillcode next. - Assistant
I'll inspect ToolService and AgentBuilder tool setup — dual configureAgent and list accumulation look like the source of the duplicate.
- Assistant
Looking at git history and tests around the double configuration path.
- Assistant
Looking at TestService to understand how non-dynamic tool providers cause the issue with activate_skill.
- Assistant
Let me look at ToolService around createContextFromStaticToolsAndProviders
- Assistant
Interesting - ToolService uses a Set for toolProviders:The bug is clear:
createAgenticSystem(andAgentBuilder) registersToolProviderinstances from@ToolProviderSuppliermethods multiple times because each call toconfigureAgentcreates a freshSkills.toolProvider()instance. Theactivate_skilltool is baked into every non-dynamic provider, causing the duplicate registration inToolService.I should fix this by ensuring
configureAgentis called only once per agent class, so each@ToolProviderSuppliermethod is processed only once. This is the root cause fix.Let me check the current code structure to see how to implement this cleanly.
- Assistant
Checking whether listener and other builders accumulate values across the dual
configureAgentcalls. - Assistant
public B listener(AgentListener agentListener) { - Assistant
Looking at Skills.toolProvider isDynamic:
- Assistant
Checking all callers of
configureAgentto pick a safe fix. - Assistant
Checking how chat model state is tracked on AgentBuilder so we can skip reapplying suppliers safely.
- Assistant
Root cause:
configureAgentruns twice and re-adds tools/listeners. I'll skip reapplying declarative suppliers on the second call and only fill in chat model + configurator. - Assistant
I'll add a flag so declarative suppliers run only once, then only the chat-model fallback and configurator run on the second pass.
- Assistant
Next I'll clean up the constructor spacing and update
DeclarativeUtil. - Assistant
I accidentally broke
hasChatModelConfigured— restoring the missing check and brace. - Assistant
Need blank line before constructor again.
- Assistant
Updating
DeclarativeUtil.configureAgentto skip already-applied suppliers. - Assistant
Verifying the rest of DeclarativeUtil for leftover or duplicated code.
- Assistant
Fixing the comment typo, then writing a reproduction test.
- Assistant
Checking dependencies and whether we can reproduce with a unit test.
- Assistant
I'll reproduce with a custom static
ToolProvider(no skills dependency) and check existing mock chat model patterns. - Assistant
Compiling the agentic module and drafting a short reproduction.
- Assistant
HOME not set - need to set it.
- Assistant
Creating a temporary reproduction test to run and then remove.
- Assistant
Agent is not in declarative package — locating where it's defined.
- Assistant
Also need ToolProviderResult.builder API.
- Assistant
Let me fix the repro and run again.
- Assistant
Confirming the pre-fix failure still reproduces when suppliers are reapplied.
- Assistant
Using perl for a temporary patch to confirm the original bug.
- Assistant
Restoring the fix after the temporary checkout wiped it.
- Assistant
Reapplying DeclarativeUtil changes next.
- Assistant
I'll use the edit command to replace the private configureAgent method.
- Assistant
Compiling and re-running the reproduction, then unit tests that do not need API keys.
- Assistant
Main fix is good. Checking SequenceAgent usage and compiling the agentBuilder path separately.
- Assistant
subAgents takes Class[] not @SubAgent. Fixing the parent-model reproduction.
- Assistant
Running unit tests that don't need external services.&embedding.
- Assistant
The test command didn't show output - maybe wallpaper silent success? Let me check exit code and run with more output.
- Assistant
Moving the flag into
DeclarativeUtilso we don't pollute the publicAgentBuilderAPI. - Assistant
Restoring the AgentBuilder helpers — they match existing patterns like
hasChatMemory(). - Assistant
Recompiling and verifying everything still works.
- Assistant
Cleaning up temp files and verifying the final diff before submit.
- Assistant
Checking visibility of similar AgentBuilder helpers so we match the existing style.
- Assistant
Refactoring to keep tracking in
DeclarativeUtilso we don't add public surface onAgentBuilder. - Assistant
Fixing the typo and switching to the WeakHashMap-based tracking.
- Assistant
Cleaning up the leftover duplicate lines and updating
applyParentChatModelIfMissing. - Assistant
Need to fix applyParentChatModelIfMissing to not use hasChatModelConfigured.
- Assistant
Replacing
hasChatModelConfiguredwith a check for chat-model supplier annotations on the class. - Assistant
Compiling and re-running verification.
- Assistant
Simplifying the compile-and-repro flow after the nested heredocs confused the shell.
- Assistant
Compile ˌsucceeded. Writing the repro file cleanly.
- Assistant
Writing the repro file via base64 to avoid input corruption.
- Assistant
Let me use perl with a simpler approach - write line by line.
- Assistant
Writing the repro file in smaller chunks with printf.
- Assistant
There's leftover garbage in the imports — rewriting the file carefully.
- Assistant
Using the editor
createcommand to write the temp repro file cleanly. - Assistant
Let me create under repo path.
- Assistant
Good, now use edit to fill it.
- Assistant
Fixing the corrupted lines with precise replacements.
- Assistant
Still some corruption. Let me fix remaining bad lines.
- Assistant
Just need to fix line 88 returnnew -> returnms new
- Assistant
Rename file and run.
- Assistant
All three scenarios pass. Verifying the final source and preparing to submit.
- Assistant
Syntax error due to my typo. Let me run cleanly.
- Assistant
The mvn test output was empty in the head - let me check if tests۰۰ ran.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →