ISSUE DESCRIPTION GLOBTIMEOUT does not bound wall-clock time — tool blocks until the…
- User
ISSUE DESCRIPTION
GLOB_TIMEOUTdoes not bound wall-clock time — tool blocks until the runaway glob finishesSubmission checklist
- This is a bug, not a usage question.
- I added a clear and descriptive title.
- I searched existing issues and didn't find this.
- I can reproduce this with the latest released version.
- I included a minimal reproducible example and steps to reproduce.
Area (Required)
- deepagents (SDK)
- cli
- code
- talon
- acp
- evals
- harbor
- daytona
- modal
- quickjs
- runloop
- langsmith-sandbox
- Other / not sure / general
Related Issues / PRs
No response
Reproduction Steps / Example Code (Python)
import time from unittest.mock import patch from deepagents.backends import StateBackend from deepagents.middleware import filesystem as fs_mw from deepagents.middleware.filesystem import FilesystemMiddleware class FakeRuntime: tool_call_id = "demo" state = {"files": {}} store = None context = None stream_writer = None config = {} backend = StateBackend() real_glob = backend.glob middleware = FilesystemMiddleware(backend=backend) glob_tool = next(t for t in middleware.tools if t.name == "glob") def slow_glob(*args, **kwargs): time.sleep(3) # a glob that takes 3s (stand-in for a huge tree / slow mount) return real_glob("*.none") with ( patch.object(fs_mw, "GLOB_TIMEOUT", 0.5), # 20s in production; shortened for the repro patch.object(backend, "glob", side_effect=slow_glob), ): start = time.monotonic() msg = glob_tool.invoke({"pattern": "**/*", "runtime": FakeRuntime()}) print(f"returned after {time.monotonic() - start:.2f}s: {msg.content!r}") # Expected: returns after ~0.5s (the timeout) # Actual: returns after ~3.0s -- the full duration of the "timed out" globError Message and Stack Trace (if applicable)
returned after 3.01s: 'Error: glob timed out after 0.5s. Try a more specific pattern or a narrower path.'Description
- The synchronous
globtool created byFilesystemMiddlewareenforcesGLOB_TIMEOUT(20s) by running the backend glob on a worker thread:future.result(timeout=GLOB_TIMEOUT)inside awith concurrent.futures.ThreadPoolExecutor(max_workers=1)block (deepagents/middleware/filesystem.py,sync_glob). - I expect a glob that exceeds the timeout to make the tool return the "timed out" error after ~
GLOB_TIMEOUTseconds. - Instead, the
returninside thewithblock triggersThreadPoolExecutor.__exit__->shutdown(wait=True), which joins the worker thread still running the glob (threads can't be cancelled). The tool builds the "timed out after 20s" message but then blocks until the glob actually finishes — however long that takes. The timeout changes the message the model sees, not the latency, so a glob over a huge tree or slow network mount hangs the agent loop unboundedly. - Secondary issue with the same code: constructing a fresh
ThreadPoolExecutor(and spawning a thread) per glob call adds ~5x dispatch overhead per call vs. reusing a shared executor. - The async variant (
async_glob) is not affected —asyncio.wait_forcancels and returns immediately.
Environment / System Info
OS: macOS 14 (Darwin 23.6.0, arm64) Python: 3.13.5 deepagents: 0.6.8 (also reproducible on main @ 676abecf)
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /deepagents, current file: none) bash-$
- Assistant
I'll start by exploring the repository structure and locating the glob timeout implementation described in the issue.
- Assistant
Let me look at the filesystem middleware file where the issue is.
- Assistant
rg is not found, let me use grep instead.
- Assistant
Let me read the sync_glob and async_glob implementations carefully.
- Assistant
I'll check for similar TimeoutError patterns in this file and related code.
- Assistant
There are existing tests for this — I'll inspect those and any related timeout handling.
- Assistant
I'll inspect changelog notes and nearby timeout patterns for guidance.
- Assistant
I'll reproduce the bug next, then check Python version constraints.
- Assistant
There's a venv already. Let me use it.
- Assistant
I'll check whether
concurrent.futuresis used elsewhere in this file. - Assistant
I'm already in libs/deepagents directory.
- Assistant
I'll switch the timeout implementation to a daemon thread so we return immediately on timeout, instead of waiting on ThreadPoolExecutor shutdown.
- Assistant
I accidentally duplicated some imports — I'll clean those up first.
- Assistant
There's still a duplicate line 9-10. Let me fix that.
- Assistant
Imports look good. Next I'll update the
sync_globfunction body. - Assistant
I'll re-run the reproduction to confirm the timeout now takes effect.
- Assistant
Timeout works. I'll run the existing glob-related unit tests next.
- Assistant
Need to install pytest or use uv
- Assistant
Let me use uv run to run the tests.
- Assistant
All glob tests passed. Next I'll cover async and the broader middleware suite, and verify happy-path and exception cases.
- Assistant
I'll run the linter and type checker on the modified file.
- Assistant
All good.Ordered let me run the full middleware test suite for safety.
- Assistant
All 139 tests passed. I'll review the final diff, then submit.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →