ISSUE DESCRIPTION Schrödinger's comment: it is both commented-out code and a comment…
- User
ISSUE DESCRIPTION
Schrödinger's comment: it is both commented-out code and a comment that is not code (ERA001 vs RUF100)
Summary
First, I'm impressed by the recent reduction of ERA001 false positives. I suspect that ERA001 is an exceptionally difficult rule to implement.
This is the only time I've seen this situation.
# ) # ) # noqa: ERA001Found commented-out code (ERA001) [Ln 1, Col 4] Unused
noqadirective (unused:ERA001) (RUF100) [Ln 2, Col 10]preview = false builtins = [] target-version = "py310" line-length = 88 indent-width = 4 [lint] allowed-confusables = [] dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$" extend-select = [] extend-fixable = [] external = [] ignore = [] select = [ "F", "E4", "E7", "E9", "ERA", "RUF" ] [format] indent-style = "space" quote-style = "double"Version
ruff 0.15.14 (9ad2da301 2026-05-21)
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /ruff, current file: none) bash-$
- Assistant
I'll start by exploring the repository structure and understanding how ERA001 and noqa directives interact.
- Assistant
Let me search for ERA001 and how commented-out code detection works with noqa.
- Assistant
rg is not found, let me use grep instead.
- Assistant
Let me look at the eradicate rule implementation.
- Assistant
Let me examine the code detection logic and how noqa directives are handled.
- Assistant
I need to check whether noqa is stripped before code detection.
- Assistant
This looks like a noqa-stripping issue. Let me verify the hypothesis and check for related code.
- Assistant
There's an interesting comment in pycodestyle/overlong.rs about stripping pragma comments. Let me look at that and also how ERA tests work.
- Assistant
There's
find_trailing_pragma_offsetandis_pragma_comment— let me inspect those. - Assistant
Perfect. So the fix for ERA001 should strip trailing pragma comments before checking if the comment contains code.
- Assistant
Let me check recent related changes and whether there's already discussion of this bug.
- Assistant
Let me check the exports and existing tests, then implement the fix.
- Assistant
I'll implement stripping trailing pragma comments before code detection.
- Assistant
Let me implement the fix.
- Assistant
Now update the
comment_contains_codefunction to strip trailing pragmas. - Assistant
Now I'll add unit tests covering the Schrödinger's comment cases.
- Assistant
Let me find the end of the tests module to add a new test.
- Assistant
I'll add a test after the allowlist test for trailing noqa.
- Assistant
Let me also add a fixture case and run the related tests.
- Assistant
The instructions say not to add or modify tests. I'll revert those changes and only keep the fix.
- Assistant
I'll remove the unit tests I added; I can use a temporary script to verify instead.
- Assistant
Let me verify the diff is clean and create a temporary reproduction script.
- Assistant
Let me reproduce the bug first with an unmodified build, then verify the fix.
- Assistant
Let me check the available tools and build ruff.
- Assistant
I'll build the original code first to reproduce the bug.
- Assistant
Good, now let's reproduce the bug with the original code.
- Assistant
Reproduced the bug. Now I'll apply the fix and rebuild.
- Assistant
Now verify the fix.
- Assistant
The fix works. Let me run existing eradicate and related unit tests.
- Assistant
All eradicate tests pass. Let me tighten the comment to match the surrounding style.
- Assistant
Let me run a few more edge-case checks and confirm the final diff.
- Assistant
Everything looks correct. Cleaning up and submitting.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →