Skip to content
TheChatArchiveThe Chat Archive
x-ai/grok-4.5· unknownHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION Admitted workloads are requeued too early when a worker disconnects An…

  1. User

    ISSUE DESCRIPTION

    Admitted workloads are requeued too early when a worker disconnects

    An admitted workload must remain ready during a temporary worker disconnect and be retried only after the configured worker-loss timeout. Reconnection with the same configuration must restore processing without affecting other connected workers.

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /kueue, current file: none) bash-$

  2. Assistant

    I'll start by exploring the repository structure and searching for code related to worker disconnects and workload requeuing.

  3. Assistant

    Searching for worker-loss timeout and requeue logic related to MultiKueue.

  4. Assistant

    rg is not available, I'll use grep instead.

  5. Assistant

    Inspecting the workload reconciler and worker-disconnect handling next.

  6. Assistant

    Reading the full reconcile path and related unit tests for the worker-lost behavior.

  7. Assistant

    Let me look at how remote clients are obtained and what happens when a client is disconnected. Also look at git history for related issues, and the tests in more detail.

  8. Assistant

    I'll inspect syncReservingRemoteState and the worker-lost unit tests to confirm how the timeout is measured.

  9. Assistant

    Examining connection handling and recent related changes.

  10. Assistant

    There's a recent commit "MultiKueue: prevent a hung remote watch from stopping all-cluster admission (#11207)" which might be related. Also "Don't use reconnecting clients in WL reconnecting". Let me ...

  11. Assistant

    Checking for uncommitted changes and reading the worker-lost paths and related tests.

  12. Assistant

    Let me look at setup_test and jobs_test for the connection lost scenarios in integration tests.

  13. Assistant

    Let me read those test cases carefully, especially "Should requeue the workload with a delay when the connection to the admitting worker is lost"

  14. Assistant

    Checking how ErrNoActiveClusters and failed SyncJob affect the worker-lost timeout path.

  15. Assistant

    I'll check SetAdmissionCheckState next, and look for recent regressions related to the worker lost timeout.

  16. Assistant

    Found a likely bug with LastTransitionTime — verifying how FindAdmissionCheck works.

  17. Assistant

    Checking how PatchAdmissionStatus applies mutations — acs may point at the wrong workload object.

  18. Assistant

    Looking more carefully at PatchAdmissionStatus and how the callback works with the acs pointer:

  19. Assistant

    Continuing to inspect the update callback path in patchStatus.

  20. Assistant

    LastTransitionTime isn't refreshed once ACS is Ready — that matches early requeue. Checking when that behavior was introduced.

  21. Assistant

    Checking how the original keep-ready heartbeat was implemented and how it evolved.

  22. Assistant

    Tracing how the PatchAdmissionStatus API changed and whether that broke LTT refresh.

  23. Assistant

    Checking unit tests for expected LTT heartbeat behavior and reviewing KeepAdmissionCheckPending.

  24. Assistant

    Looking for reconnect issues that could affect other workers — review of setConfig and connecting.

  25. Assistant

    Inspecting the reconnect backoff commit for issues around "same configuration" reconnection.

  26. Assistant

    Checking locking around remote client reconnect and any related open issues in the KEPs/docs.

  27. Assistant

    Checking when KeepAdmissionCheckPending was removed and whether it's still needed.

  28. Assistant

    Checking BaseSSAWorkload and verifying feature gate defaults.

  29. Assistant

    Identified the bug: syncReservingRemoteState never persists LastTransitionTime refreshes while ACS stays Ready, so disconnects after the timeout yield immediate requeue. Fixing that path.

  30. Assistant

    Also notice that even if we set LTT correctly on the wl copy, SetAdmissionCheckState itself won't update LTT because state is same. So the fix must either:

  31. Assistant

    Applying the fix so the ACS heartbeat updates LastTransitionTime on the patched workload object.

  32. Assistant

    The edit landed in the wrong file — reverting that and applying the fix to the MultiKueue workload controller.

  33. Assistant

    Good, now the correct file is open. Let me apply thefil edit.

  34. Assistant

    Cleaning up the comment and verifying the imports.

  35. Assistant

    Writing a temporary test to verify the LastTransitionTime heartbeat is persisted.

  36. Assistant

    I'll add a temporary test case that asserts LTT is refreshed, then run the unit tests.

  37. Assistant

    I'll write a temporary Go test file that specifically checks the LTT heartbeat.

  38. Assistant

    I'll create a temporary test file in the multikueue package to verify the LTT heartbeat.

  39. Assistant

    I need to put the test in the package directory. Let me create tmp file there and remove it later. The instruction says I can create temporary scripts but should not modi...

  40. Assistant

    Let me write the temporary test carefully, modeled after TestWlReconcile setup.

  41. Assistant

    Checking which condition marks a remote as reserving.

  42. Assistant

    There's a bug in remainingWaitTime calculation!

  43. Assistant

    Also remainingWaitTime uses time.Since not clock - and after heartbeat acs is from freh GET. Good.

  44. Assistant

    Need to set GOCACHE and maybe HOME.

  45. Assistant

    Confirming the test fails without the fix:

  46. Assistant

    Confirmed the regression; restoring the fix and running the full MultiKueue unit tests.

  47. Assistant

    All multiKueue unit tests pass. Checking whether remainingWaitTime should use the clock, and verifying the final diff.

  48. Assistant

    Fixing remainingWaitTime to use the injected clock for consistency.

  49. Assistant

    Re-running unit tests and checking for other similar ACS mutation bugs.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.