Skip to content
TheChatArchiveThe Chat Archive
x-ai/grok-4.5· unknownHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION Floating terminal auto-creates tab after user closes the last one…

  1. User

    ISSUE DESCRIPTION

    Floating terminal auto-creates tab after user closes the last one

    Floating terminal auto-creates tab after user closes the last one

    Symptom

    When the floating terminal has a single tab open and the user clicks the X button to close it, the panel auto-creates a new terminal tab instead of closing the panel. The user has to close the panel manually via the minimize button or by closing the newly created tab again.

    Steps to reproduce

    1. Open the floating terminal (Cmd+Alt+T on Mac / Ctrl+Alt+T on Windows/Linux)
    2. The panel opens with one auto-created terminal tab
    3. Click the X button on that tab to close it
    4. Expected: Panel closes cleanly
    5. Actual: Panel stays open with a fresh auto-created tab

    Root cause

    The closeTab callback used for the X button triggers the auto-create effect (lines 102-108 in FloatingTerminalPanel.tsx) that spawns a tab whenever the panel is open with zero tabs. The panel never closes because a replacement tab is created before the close check can run.

    Additionally, closeOthers and closeToRight context menu actions had stale closure bugs—they read tabs.length from the captured array in useCallback dependencies instead of pulling fresh state via useAppStore.getState(), causing these callbacks to operate on outdated tab lists.

    Expected behavior

    • Clicking X on the last terminal tab should close the floating panel (symmetric with the auto-create on open)
    • The panel should remain open if a PTY exits so the user can see exit status
    • Multi-tab operations (closeOthers, closeToRight) should operate on current state, not stale captures

    Why it matters

    The asymmetry breaks user expectations: the panel auto-creates a tab on open (hotkey press), but closing that tab doesn't reverse the action. Users expect the X button on the last tab to dismiss the panel, not spawn an orphaned replacement.

    Environment

    • All platforms (macOS, Linux, Windows)
    • Floating terminal feature introduced in recent releases

    Evaluation contract

    Bootstrap a terminal tab only when the panel transitions open. An explicit close action that removes the last tab closes the panel; a PTY exit removes its tab but must neither close the panel nor create a replacement tab. Bulk close operations must read the current store state rather than a stale render-time tab list, and closeToRight must follow the reconciled visible tab-bar order rather than raw backing-array order.

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /orca, current file: none) bash-$

  2. Assistant

    I'll start by exploring the repository structure and locating the floating terminal panel code mentioned in the issue.

  3. Assistant

    Let me read the FloatingTerminalPanel.tsx file which is mentioned in the issue.

  4. Assistant

    Let me read the rest of the file, especially around lines 97-150 where the auto-create effect and closeTab callbacks are.

  5. Assistant

    Let me check related tests and how closeTab works in the store, plus how PTY exit is handled.

  6. Assistant

    Let me search more carefully.

  7. Assistant

    rg is not found in that second part after semicolon perhaps failed because of something. Let me try grep.

  8. Assistant

    Let me inspect closeTab, how analogous components handle closeOthers/closeToRight, and any related docs or AGents guidance.

  9. Assistant

    I'll inspect the tab-group close helpers and how PTY exit removes floating tabs.

  10. Assistant

    Looking at FloatingTerminalPanel more carefully around TerminalPane usage and the auto-create effect:

  11. Assistant

    Checking how tab bar order is reconciled and whether any existing tests cover this panel logic.

  12. Assistant

    Let me look at reconcileTabOrder to understand how closeToRight should work. Also check git log for any related recent changes.

  13. Assistant

    Let me read reconcile-order.ts and also check git history for FloatingTerminalPanel to see if there was a previous attempt or design.

  14. Assistant

    Checking whether tabs are cleared when the floating terminal is closed/minimized.

  15. Assistant

    Let me find where FloatingTerminalPanel is used.

  16. Assistant

    Checking when TerminalPane's onCloseTab is invoked.

  17. Assistant

    Looking at TerminalPane.tsx around line 439 for when onCloseTab is called.

  18. Assistant

    Implementing the full fix now: transition-only bootstrap, close last tab → panel closes, fix bulk close stale state/order.

  19. Assistant

    Now I'll update the bootstrap effect and close-related callbacks.

  20. Assistant

    Now replace the bootstrap effect and close callbacks.

  21. Assistant

    Let me check the close callbacks and onCloseTab wiring, and look for any accidental duplication.

  22. Assistant

    Updating onCloseTab so it uses closeFloatingTab for explicit closes.

  23. Assistant

    Need to goto that line first

  24. Assistant

    Now I can replace.

  25. Assistant

    Initializing wasOpenRef to false so a first-mount open state still bootstraps correctly.

  26. Assistant

    Need to goto line 67

  27. Assistant

    Let me update the wasOpenRef init.

  28. Assistant

    Checking main workspace PTY-exit handling for consistency with the "see exit status" requirement.

  29. Assistant

    There's handlePtyExit - maybe it doesn't always close tabs?

  30. Assistant

    Let me look at useTerminalTabs handlePtyExit

  31. Assistant

    Verifying the full diff and running related tests/typecheck.

  32. Assistant

    Running typecheck and related unit tests.

  33. Assistant

    Timed out. Let me try with a longer approach or npx vitest.

  34. Assistant

    Vitest seems to hang. Let me check the vitest config and try running differently.

  35. Assistant

    Vitest works with timeout. The pipe to tail was the issue maybe with buffering. Let me typecheck the web config briefly.

  36. Assistant

    Typecheck timed out. Let me try tsgo directly with a longer timeout or just validate syntax another way.

  37. Assistant

    Typecheck is too slow. Let me just review the file is complete and correct, and run floating terminal bounds tests.

  38. Assistant

    The fix looks complete. Verifying the final file once more, then submitting.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.