ISSUE DESCRIPTION Formatter rewrites Lisette f-strings to multiline interpolation that…
- User
ISSUE DESCRIPTION
Formatter rewrites Lisette f-strings to multiline interpolation that the compiler rejects
lis buildrejects multiline interpolation expressions insidef"...{...}"strings, but Zed’s Lisette formatter appears to rewrite single-line calls across lines automatically.Example:
f"You cannot use another ender pearl for {shared.format_duration( remaining, )}."The compiler reports:
[error] Multi-line f-string interpolation ... error: f-string interpolations must be single-lineImpact:
lis buildfails after formatting in touched spots.- This forces manual one-line edits to pass build.
Expected:
- Either Lisette formatter should preserve single-line interpolation in compatible cases, or
- Formatter rules should be configured to avoid splitting interpolation argument expressions across lines.
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /lisette, current file: none) bash-$
- Assistant
I'll start by exploring the repository structure to understand how the Lisette formatter works and where f-string formatting is handled.
- Assistant
The formatter lives in
crates/format. I'll inspect how f-strings and interpolations are formatted. - Assistant
rg is not found, I'll use grep.
- Assistant
I'll open the expression formatter and inspect
format_stringplus how call arguments are laid out. - Assistant
I'll inspect the Lindig document printer and how nested groups/breaks work for arguments.
- Assistant
I'll inspect call formatting and whether there's already a force-unbroken construct.
- Assistant
Let me search for the compiler error about multi-line f-string interpolation.
- Assistant
I'll review existing format tests for f-strings and the full call formatting logic.
- Assistant
I'll read how Mode::ForcedUnbroken is applied during document formatting.
- Assistant
I'll look for prior art of force-unbroken and scan CHANGELOG/format history for f-string notes.
- Assistant
I'll reproduce the formatter breaking an f-string interpolation across lines.
- Assistant
Let me try to run a quick test with cargo.
- Assistant
Let me find the assert_format_snapshot macro and write a quick reproduce binary.
- Assistant
I'll write a small program that formats the issue's example and shows the broken output.
- Assistant
The project pins a toolchain; I'll use that instead of a default rustup install.
- Assistant
Toolchain installed — I'll rerun the reproduction from the repo root.
- Assistant
Need to copy toolchain file or use +1.94
- Assistant
I'll compare this pretty-printer with Gleam’s for ForceUnbroken handling.
- Assistant
I'll switch back to the repository root and implement force_unbroken.
- Assistant
I'll inspect how call argument joining chooses broken vs unbroken separators.
- Assistant
I'll add
ForceUnbrokento the pretty printer and apply it to f-string interpolations. - Assistant
I dropped the
match document {line — restoring it. - Assistant
Next I'll update the format() function for ForcedUnbroken.
- Assistant
Continue reading Group and ForceBroken parts.
- Assistant
Updating Group/FlexBreak handling and adding the ForceUnbroken variant.
- Assistant
Continue with Group and ForceUnbroken.
- Assistant
The NestIfBroken/Group section got corrupted — fixing it now.
- Assistant
Removing the extra brace and adding the ForceUnbroken variant.
- Assistant
I'll add the
force_unbrokenhelper method next. - Assistant
I'll force f-string interpolations to stay single-line in the expression formatter.
- Assistant
Update format_string.
- Assistant
I'll recompile and re-run the reproduction to confirm the fix.
- Assistant
I'll exercise a few more edge cases and ensure normal (non–f-string) call wrapping still works.
- Assistant
I'll run the existing format tests to check for regressions.
- Assistant
All format tests passed. I'll review the diff and clean up temporary files.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →