ISSUE DESCRIPTION service member referenced in an Angular external template is reported…
- User
ISSUE DESCRIPTION
service member referenced in an Angular external template is reported as unused when the component property is initialized with
inject()(no explicit type annotation)What happened?
With the
angularplugin active,fallow dead-codereports a service method as an unused class member when its only reference is in an Angular HTML template (prop.method()), and the component propertypropis initialized with the moderninject()pattern without an explicit type annotation:readonly exampleService = inject(ExampleService);Fallow already credits template references through component properties for the other three DI/instance patterns — it is specifically the untyped
inject()initializer that is missed. The following all resolve correctly (no false positive); only the last one fails:Component property pattern Template prop.method()resolved?constructor(public svc: ExampleService) {}✅ yes svc: ExampleService = inject(ExampleService);(typed)✅ yes svc = new ExampleService();✅ yes svc = inject(ExampleService);(untyped)❌ no — false positive Because untyped
inject()is the idiomatic Angular style, this misfires on a very common real-world pattern.Reproduction
Minimal standalone repro.
@angular/coreonly needs to be listed inpackage.jsonso theangularplugin auto-activates — runningnpm installis optional (without it, fallow prints a "node_modules directory not found" warning but the finding still reproduces).-
Create
package.json:{ "name": "fallow-angular-template-repro", "version": "1.0.0", "private": true, "dependencies": { "@angular/core": "^20.0.0" } } -
Create
.fallowrc.json:{ "entry": ["src/main.ts"] } -
Create
src/main.ts:import { ExampleComponent } from './example.component'; console.log(ExampleComponent); -
Create
src/example.service.ts:import { Injectable } from '@angular/core'; @Injectable({ providedIn: 'root' }) export class ExampleService { // Only referenced from example.component.html via an event binding. onValueChange(value: string): void { console.log(value); } } -
Create
src/example.component.ts:import { Component, inject } from '@angular/core'; import { ExampleService } from './example.service'; @Component({ selector: 'app-example', templateUrl: './example.component.html', }) export class ExampleComponent { // Exposed to the template so the binding can call exampleService.onValueChange(...) readonly exampleService = inject(ExampleService); } -
Create
src/example.component.html:<input (input)="exampleService.onValueChange($event.target.value)" /> -
Run:
npx fallow dead-code --config .fallowrc.json
Actual output
── Unused Code ───────────────────────────────────── ● Unused class members (1) src/example.service.ts :6 ExampleService.onValueChange Class methods or properties never referenced outside their class ✗ 1 class memberonValueChangeis reported as unused even though it is referenced inexample.component.html.Controls that isolate the root cause
Keeping the template
(input)="exampleService.onValueChange(...)"unchanged and only varying howexampleServiceis declared on the component:- Control A — constructor injection: replace the
inject()field withconstructor(public exampleService: ExampleService) {}. Result:✓ No issues found. - Control B —
inject()with an explicit type annotation:readonly exampleService: ExampleService = inject(ExampleService);. Result:✓ No issues found. - Control C —
newinitializer:readonly exampleService = new ExampleService();. Result:✓ No issues found.
Only the untyped
inject()initializer (the repro above) produces the false positive. This points at the component-property → service-type binding step: it resolves type annotations, constructor parameters, andnewexpressions, but not an untypedinject()initializer, so the template referenceexampleService.onValueChangeis never credited toExampleService.Expected behavior
A service member referenced from an Angular template via a component property should be credited as used when that property is initialized with
inject()— the same way it already is for typedinject(), constructor injection, andnewinitializers. Nounused-class-memberfinding should be reported in the repro above.Fallow version
fallow 2.83.0
Operating system
macOS
Configuration
defaultInterface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /fallow, current file: none) bash-$
-
- Assistant
I'll start by exploring the repository structure and locating the Angular plugin logic that resolves template references to component properties.
- Assistant
There's already an
angular-inject-class-membersfixture — I'll inspect it and the Angular plugin source next. - Assistant
rg is not found, let me use grep instead.
- Assistant
Let me look at the angular plugin and the related tests, as well as template_usage.rs.
- Assistant
Let me read the angular plugin and template usage code more carefully, and also the integration tests.
- Assistant
I'll dig into template usage handling and how DI injection types get resolved.
- Assistant
I found
extract_angular_inject_target— reading that and how type bindings get produced. - Assistant
Now let me look at how extract_angular_inject_target is used around line 1886.
- Assistant
Looking at how template usage credits members and how type bindings tie in.
- Assistant
Let me look at how HTML templates are analyzed and how binding targets get from component to template analysis.
- Assistant
Let me look at how angular template member access is credited - probably in the analyze phase for unused class members.
- Assistant
The key is
build_typed_instance_binding_targetsin unused_members.rs — reading that next. - Assistant
Next I'll find where
instance_bindingsgets populated. - Assistant
The key function is
extract_class_instance_bindingsin helpers.rs. - Assistant
Root cause:
extract_class_instance_bindingshandlesnewbut not untypedinject(). Checking related tests and how inject is detected elsewhere. - Assistant
Let me look at other tests related to inject and instance bindings.
- Assistant
There are tests around line 3245-3315 for instance bindings, and angular inject tests at 1568. Let me read those.
- Assistant
Let me also read the angular inject tests and the fixture for angular-template-inherited-members to understand the pattern.
- Assistant
I'll review how typed instance bindings are used when processing template member accesses.
- Assistant
There's also special handling for ANGULAR_TPL_SENTINEL. Let me find that.
- Assistant
Let me read the section around 1439 where ANGULAR_TPL_SENTINEL is used.
- Assistant
Continue reading about angular_tpl_chain_accesses
- Assistant
Reading how
resolve_typed_instance_chain_targetsworks with dotted access paths. - Assistant
I'll check helpers imports and whether
type_name_rootis available for handling inject type arguments. - Assistant
There's already Angular-related code in helpers.rs. Let me also check CallExpression is imported - it's not in the current imports! I need to add CallExpression or use Expression::CallExpression fully...
- Assistant
There's type_name_root nested somewhere - it's in visit_impl. Let me check helpers for something similar.
- Assistant
I'll look at
extract_angular_signal_queryfor a similar pattern to follow. - Assistant
Let me also look for an existing issue fixture for this, and check fixtures structure.
- Assistant
I understand the issue:
extract_class_instance_bindingsmisses untypedinject(). Implementing the fix next. - Assistant
Checking how inline templates credit chained service members so we don't miss a path.
- Assistant
Implementing the fix in
extract_class_instance_bindings. - Assistant
Adding the helper function next to
extract_class_instance_bindings. - Assistant
Adding a blank line for style, then building and reproducing.
- Assistant
Fixing the botched edit.
- Assistant
Creating a temporary reproduction and building the project.
- Assistant
Let me build fallow with cargo.
- Assistant
Build succeeded. Running the repro next.
- Assistant
I need to check how to specify the working directory.
- Assistant
Just cd to the directory and run with the config.
- Assistant
The fix works. Verifying unused members still flag correctly and running related tests.
- Assistant
Controls and integration tests next.
- Assistant
Checking that the existing angular-inject fixture still works.
- Assistant
Cleaning up diffs and verifying the final change.
- Assistant
Confirming the bug reproduces without the fix:
- Assistant
Recreating the repro to demonstrate the bug.
- Assistant
Bug reproduced. Rebuilding with the fix and confirming resolution.
- Assistant
Still failing after restoring the fix — checking whether the changes applied correctly.
- Assistant
The source has the fix. Checking whether instance bindings extract correctly.
- Assistant
Writing a temporary unit check for instance bindings.
- Assistant
I'll add a temporary test, run it, then remove it.
- Assistant
Extract is fine; tracing how
templateUrllinks the HTML into analysis. - Assistant
grep withdirectories keeps failing. Let me use find.
- Assistant
Looking at how templateUrl becomes an import, then how angular_tpl_chain_accesses finds HTML via imports. Looking at the HTML parsing for member accesses:
- Assistant
Checking how `
- Assistant
Let me continue debugging.
- Assistant
Checking when component class heritage and instance_bindings get recorded for exported classes.
- Assistant
Looking at declarations for named exports path - declarations.rs.
- Assistant
Removing the temporary test and carefully re-running the repro.
- Assistant
Confirming remaining edge cases, then cleaning up.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →