Skip to content
TheChatArchiveThe Chat Archive
x-ai/grok-4.5· unknownHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION magic-link verify deadlocks: runWithTransaction nests…

  1. User

    ISSUE DESCRIPTION

    magic-link verify deadlocks: runWithTransaction nests adapter.transaction (1.6.11 consumeVerificationValue) instead of reusing the active transaction

    Is this suited for github?

    • Yes, this is suited for github

    Reproduction

    1. better-auth 1.6.11 with the magicLink plugin.
    2. A database adapter whose transaction is a real interactive DB transaction that holds a dedicated connection for its duration (e.g. the Kysely adapter, or @zenstackhq/better-auth, backed by pg).
    3. Limit the client connection pool to one connection: new Pool({ max: 1 }) -- standard when using Cloudflare Hyperdrive, which pools server-side so the worker keeps a tiny client pool.
    4. await auth.api.signInMagicLink({ body: { email } }) -> works (single insert).
    5. await auth.api.magicLinkVerify({ query: { token } }) (or GET /api/auth/magic-link/verify?token=...).

    Minimal trigger: any setup where adapter.transaction acquires a connection and the pool cannot hand out two connections at once.

    Current vs. Expected behavior

    Current: the verify call hangs forever and never returns. Postgres shows the backend stuck idle in transaction (wait_event = ClientRead) right after the verification SELECT; the connection is never released, so every attempt leaks one idle-in-transaction connection.

    Trace of the cause:

    • internalAdapter.consumeVerificationValue (added in 1.6.11) runs inside runWithTransaction -> opens transaction tx1 (BEGIN, takes the only pooled connection).
    • Consuming the row (consumeOne) triggers another runWithTransaction -> calls adapter.transaction again -> transaction tx2, which tries to acquire a second connection.
    • runWithTransaction in @better-auth/core (context/transaction.mjs) always opens a fresh adapter.transaction; it does NOT check adapterAsyncStorage.getStore() to see whether a transaction is already active in the current async context. So tx2 is nested inside tx1 and blocks forever waiting for the connection tx1 holds -> deadlock.

    Note the CRUD path already reuses the active transaction: getCurrentAdapter(adapter) returns the trx adapter from the ALS store. runWithTransaction is inconsistent with this -- it doesn't reuse.

    Expected: runWithTransaction should be reentrant -- when an adapter/transaction is already active in the async-context store, run fn within it instead of opening a nested adapter.transaction (mirroring getCurrentAdapter). Then verify needs only one connection and works on any pool size. (Alternatively/additionally, document that adapters MUST support reentrant nested transactions -- currently adapters like @zenstackhq/better-auth open a brand-new transaction on the base client for each adapter.transaction call, which is a reasonable contract but incompatible with the current nesting.)

    This is security-relevant: the 1.6.11 change that introduced this nesting was the magic-link "mint multiple sessions from one token" race fix, so the fix effectively breaks magic-link verification on connection-limited adapters/pools.

    What version of Better Auth are you using?

    1.6.11

    System info

    > The `auth info` CLI can't introspect this project headlessly because the auth instance is built dynamically via a factory (no static `auth.ts` export), so the values below are assembled manually
    
    {
      "better-auth": { "version": "1.6.11", "@better-auth/core": "1.6.11" },
      "adapter": { "name": "@zenstackhq/better-auth", "version": "3.6.4", "orm": "@zenstackhq/orm 3.6.4 (Kysely 0.28.17)" },
      "database": { "driver": "pg 8.20.0", "pool": { "max": 1 }, "fronted_by": "Cloudflare Hyperdrive" },
      "runtime": { "platform": "Cloudflare Workers (workerd)", "wrangler": "4.95.0", "node_for_tooling": "v22.22.1" },
      "plugins": ["magicLink"],
      "os": "macOS (Darwin 25.5.0)"
    }
    

    Which area(s) are affected? (Select all that apply)

    Backend

    Auth config (if applicable)

    import { betterAuth } from "better-auth"
    export const auth = betterAuth({
      emailAndPassword: {  
        enabled: true
      },
    });
    

    Additional context

    • Bisected away unrelated suspects: the hang reproduces on older framework code and is independent of DI scope changes -- it's purely 1.6.10 -> 1.6.11.
    • Reproduced deterministically in a real workerd integration test (request magic link -> capture token -> verify) that times out before the change.
    • Relevant code: @better-auth/core context/transaction.mjs runWithTransaction (opens adapter.transaction unconditionally) vs getCurrentAdapter (reuses the active trx); internalAdapter.consumeVerificationValue -> consumeOneWithHooks -> adapter consumeOne.
    • Worked around downstream by making the adapter's transaction reentrant (reuse the in-flight transaction via AsyncLocalStorage), which is also the correct semantics (nested transaction = one atomic unit) -- but it seems like runWithTransaction itself should reuse the active transaction.

    Interface

    No new interfaces are introduced.

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /better-auth, current file: none) bash-$

  2. Assistant

    I'll start by exploring the repository structure and locating the runWithTransaction implementation that's causing the nested-transaction deadlock.

  3. Assistant

    Let me look at the transaction.ts file and related code.

  4. Assistant

    I've confirmed runWithTransaction always opens a new transaction. Next I'll inspect call sites and related tests so the fix reuses an active ALS transaction.

  5. Assistant

    rg is not available, let me use grep.

  6. Assistant

    Inspecting consumeVerificationValue and magic-link nesting to pinpoint where the extra transaction is opened.

  7. Assistant

    Checking whether consumeOne/consumeOneWithHooks also opens transactions and reviewing the transaction test suite.

  8. Assistant

    There's already a nested-transaction test for consumeOne; I'll inspect its expectations and the adapter transaction implementations next.

  9. Assistant

    Let me look at the factory fallback for consumeOne - it mentions nesting transactions:

  10. Assistant

    Let me look more carefully at the factory transaction handling and how adapters that mark transaction:false work within a transaction. Also look at how kysely implements its transaction adapter.

  11. Assistant

    I'll check for transaction-context tests and inspect createAsIsTransaction so we can make runWithTransaction reentrant correctly.

  12. Assistant

    Checking how runWithAdapter is used and whether we can distinguish a real transaction from a plain adapter context.

  13. Assistant

    Important: requests already wrap handlers in runWithAdapter, so I need a way to tell a real transaction context from a plain adapter context.

  14. Assistant

    I'll add an inTransaction flag to the ALS store so nested runWithTransaction can reuse the active transaction without treating plain runWithAdapter as one.

  15. Assistant

    Implementing reentrant runWithTransaction with an inTransaction flag so plain runWithAdapter contexts still open real transactions.

  16. Assistant

    Checking how queueAfterTransactionHook is used so I don't break deferred-hook behavior.

  17. Assistant

    I'll simplify: only make runWithTransaction reentrant, and leave queueAfterTransactionHook / runWithAdapter behavior otherwise unchanged.

  18. Assistant

    Cleaning up corrupted characters in comments.

  19. Assistant

    Checking whether the factory's consumeOne fallback should also reusean active ALS transaction.

  20. Assistant

    Writing a temporary script to verify reentrancy, then reading the rest of the file for correctness.

  21. Assistant

    Building core and running a temporary verification script.

  22. Assistant

    Build timed out. Let me try a different approach - maybe run vitest with were ts directly, or лица a simpler transpile.

  23. Assistant

    I'll run a temporary vitest against the source directly, since the full package build is slow.

  24. Assistant

    Checking what went wrong with the test file and vitest run.

  25. Assistant

    The create command failed somehow - only 1 line. Let me write the file properly.

  26. Assistant

    Vitest keeps timing out—trying a simpler direct Node/tsx approach next.

  27. Assistant

    Corepack is prompting for pnpm download and hanging the session — switching to local binaries instead.

  28. Assistant

    Good. Let me run vitest with the full path.

  29. Assistant

    I need to put the testinside the package so vitest can find it.

  30. Assistant

    Need to check how other tests import things and if package exports are set up. Maybe need to build first briefly.

  31. Assistant

    The package needs to be built first for the exports本来 to work. The dist folder is missing. Let me try building with a longer timeout or check vitest alias config.

  32. Assistant

    Build completed. Now run tests from root with vitest config that has;of /dev-source.

  33. Assistant

    All 4 tests passed. Removing the temporary test file next, since repository tests shouldn't be modified.

  34. Assistant

    Simulating the single-connection pool deadlock pattern to confirm the fix.

  35. Assistant

    Verifying the simulation deadlocks without the fix,tomeet the reproduction checklist.

  36. Assistant

    No python3. Let me use node/sed.

  37. Assistant

    Confirming the working tree is clean aside from the intended fix, then submitting.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.