ISSUE DESCRIPTION Removing a registered or subscribed service leaves stale local…
- User
ISSUE DESCRIPTION
Removing a registered or subscribed service leaves stale local metadata
After a successful unregister or unsubscribe operation, the corresponding provider or consumer URL must no longer participate in local metadata, service matching, or revision calculation. Removing one URL must preserve unrelated registrations. If the remote operation fails, local metadata must not be removed as though the operation succeeded.
Interface
Type: Function Name: RemoveService Path: metadata/metadata.go Input: registryId string, url *common.URL Output: (no return value) Description: Removes a provider service URL from the local metadata for the given registry. Use this during unregister flows to keep the in-memory application-level metadata consistent with the actual exported services.
Type: Function Name: RemoveSubscribeURL Path: metadata/metadata.go Input: registryId string, url *common.URL Output: (no return value) Description: Removes a subscribed service URL from the local metadata for the given registry. Use this during unsubscribe flows to ensure stale subscribed URLs are cleaned from the application-level metadata.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /dubbo-go, current file: none) bash-$
- Assistant
I'll start by exploring the repository structure and the metadata package to understand how services are currently registered and tracked.
- Assistant
Let me examine
metadata/metadata.goand how services are currently added and tracked. - Assistant
So I need to add RemoveService and RemoveSubscribeURL functions. Let me look at the MetadataInfo structure to see if there are already remove methods.
- Assistant
Let me continue reading the file to see Remove methods and AddSubscribeURL.
- Assistant
MetadataInfo already has the remove methods. Next I'll check unregister/unsubscribe callers and related tests so the package-level wrappers are wired correctly.
- Assistant
I'll inspect the service discovery registry unregister/unsubscribe paths next.
- Assistant
Reading UnRegister and UnSubscribe to see where metadata should be cleaned up.
- Assistant
Checking tests and git history for expected behavior around remove APIs.
- Assistant
I'll compare with dual register/unregister flows and inspect service discovery registry more carefully.
- Assistant
I'll also check MetadataService and how revision is derived from services.
- Assistant
I'll check for any hidden tests or TODO comments referencing these APIs.
- Assistant
I'll look at how UnRegister is invoked from the protocol layer.
- Assistant
Checking URL equality/comparison helpers — pointer equality may leave stale entries when clones are used.
- Assistant
Implementing package-level remove helpers, then wiring them into successful unregister/unsubscribe paths.
- Assistant
The edit hit the wrong file — I'll restore
metadata_service.goand apply the changes tometadata/metadata.go. - Assistant
Good, restored. Now edit metadata.go correctly.
- Assistant
Wiring the remove helpers into successful UnRegister/UnSubscribe paths.
- Assistant
Updating UnRegister and UnSubscribe to call the new remove helpers only after a successful remote operation.
- Assistant
Improving
removeUrlso cloned URLs still match and remove correctly for revision/metadata consistency. - Assistant
Updating
removeUrlto match by value identity so removals work when callers pass URL clones. - Assistant
I'll improve removeUrl to use Key() comparison as fallback. Also carefully when after remove if hospitality empty - if pointer didn't match and key didn't either, the empty check on `m[url.ServiceKey(...
- Assistant
Running a quick verification script and the metadata package tests.
- Assistant
Need to set GOPATH or GOMODCACHE
- Assistant
Writing a temporary verification script for the package-level remove APIs and edge cases.
- Assistant
Removing the temporary test file and checking compilation of the registry package.
- Assistant
Verifying the final diff before submit.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →