Skip to content
TheChatArchiveThe Chat Archive
gpt-5.6-sol· openaiHugging Face ibragim-bad/swe_rebench_07_2026_trajectories

ISSUE DESCRIPTION fix(atelierssr): v-show on a non-root element with an existing style…

  1. User

    ISSUE DESCRIPTION

    fix(atelier_ssr): v-show on a non-root element with an existing style attr/:style binding emits a duplicate style attribute, breaking display:none hiding

    Location

    • crates/vize_atelier_ssr/src/codegen/element/plain.rs:490 (process_v_show_on_element unconditionally appends a standalone style="display: none;" chunk; its element param is unused)
    • crates/vize_atelier_ssr/src/codegen/element/plain.rs:245-254 (collect_element_directive_attr — the single-root/inherit_attrs path that correctly merges into one style binding via _mergeProps; reference for the fix)

    Problem

    process_v_show_on_element (used on every non-fallthrough-root element) emits a standalone style="display: none;" chunk instead of merging v-show into the element's existing style. When the element already has a static style attribute or a :style binding, the generated HTML contains TWO style attributes. The HTML parser keeps the FIRST, so display:none is dropped and v-show fails to hide the element (or, in the :style case, the display:none chunk renders first and the bound style is silently dropped). The sibling single-root path already merges correctly via _mergeProps, proving the element-level path is the buggy one.

    Reproduction

    <template>
      <div class="wrapper">
        <span style="color:red" v-show="ok">x</span>
      </div>
    </template>
    

    Actual

    <span style="color:red"${((_ctx.ok) ? "" : " style=\"display: none;\"")}>
    // when ok===false -> <span style="color:red" style="display: none;">x</span> ; browser keeps the first, display:none ignored
    

    <span v-show="ok" :style="{ color }"> likewise emits two style attributes.

    Expected

    Vue's SSR ssrTransformShow rewrites v-show into the single style binding (style=[existing, expr ? null : {display:'none'}]) so there is exactly one style attribute.

    Suggested direction

    In process_v_show_on_element (plain.rs:479-493), inspect the element for an existing static style attr or :style binding and merge (expr ? null : { display: 'none' }) into a single style binding, reusing the merge logic already present in the single-root path (collect_element_directive_attr, plain.rs:245-254).

    ADDITIONAL ADVICE

    Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use git checkout <file> to restore the file to its original state. You can also reset all changes in the repository using git reset --hard command. Additionally, you can use git stash and git stash pop to temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you call submit) using git status or git diff commands. However you don't need to use git add or git commit before submitting your changes. In fact, submit only submits currently unstaged changes because it uses git diff to get the changes that need to be submitted.

    CHECKLIST

    Before submitting your solution, please go over the following checklist and make sure you've done everything:

    • If an error was reported in the issue description, I have successfully reproduced it.
    • If an error was reported in the issue description, I have confirmed that my fix resolves the error.
    • I have thought about edge cases and made sure my fix handles them as well.
    • I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.

    Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!

    (Current directory: /vize, current file: none) bash-$

  2. Assistant

    I’ll inspect the SSR element code and nearby tests, then reproduce the generated output before changing the merge behavior.

  3. Assistant

    The direct path independently emits static style, bound style, and v-show in property order, so fixing only the v-show chunk could still leave duplication from the existing style processor. I’ll inspect the full opening-tag flow and test harness to determine the safest way to make style ownership singular.

  4. Assistant

    A localized approach is viable: when direct emission sees v-show, skip the normal static-style emission, let the existing :style directive be skipped, and have v-show emit exactly one _ssrRenderStyle([...]) attribute containing static style, bound style, and the conditional display object. I’ll verify AST/property assumptions and Vue-style expected syntax with current snapshots and compiler output.

  5. Assistant

    The existing merged-props path normalizes duplicate style entries into an array. I’ll mirror that representation only when v-show has an authored style, preserving current output for v-show alone while ensuring static and bound styles are emitted once regardless of source order.

  6. Assistant

    The code now centralizes style emission under v-show and includes all authored static/static-argument bound style values. Next I’ll compile the crate, run its existing tests, and use an existing CLI/example if available (or a temporary external harness) to inspect both reported reproductions.

  7. Assistant

    All 108 crate and snapshot tests pass. I’ll now run a temporary harness outside the repository against the two exact non-root cases, plus reversed directive order and combined static/dynamic styles, checking that each generated opening tag has only one style attribute.

  8. Assistant

    The harness confirms each reported and order-variant case now generates one _ssrRenderStyle attribute with the existing values followed by conditional display: "none". I’ll perform linting and review the final diff/status for unintended files or edge-case regressions before submission.

Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.