ISSUE DESCRIPTION Floating terminal auto-creates tab after user closes the last one…
- User
ISSUE DESCRIPTION
Floating terminal auto-creates tab after user closes the last one
Floating terminal auto-creates tab after user closes the last one
Symptom
When the floating terminal has a single tab open and the user clicks the X button to close it, the panel auto-creates a new terminal tab instead of closing the panel. The user has to close the panel manually via the minimize button or by closing the newly created tab again.
Steps to reproduce
- Open the floating terminal (Cmd+Alt+T on Mac / Ctrl+Alt+T on Windows/Linux)
- The panel opens with one auto-created terminal tab
- Click the X button on that tab to close it
- Expected: Panel closes cleanly
- Actual: Panel stays open with a fresh auto-created tab
Root cause
The
closeTabcallback used for the X button triggers the auto-create effect (lines 102-108 inFloatingTerminalPanel.tsx) that spawns a tab whenever the panel is open with zero tabs. The panel never closes because a replacement tab is created before the close check can run.Additionally,
closeOthersandcloseToRightcontext menu actions had stale closure bugs—they readtabs.lengthfrom the captured array inuseCallbackdependencies instead of pulling fresh state viauseAppStore.getState(), causing these callbacks to operate on outdated tab lists.Expected behavior
- Clicking X on the last terminal tab should close the floating panel (symmetric with the auto-create on open)
- The panel should remain open if a PTY exits so the user can see exit status
- Multi-tab operations (
closeOthers,closeToRight) should operate on current state, not stale captures
Why it matters
The asymmetry breaks user expectations: the panel auto-creates a tab on open (hotkey press), but closing that tab doesn't reverse the action. Users expect the X button on the last tab to dismiss the panel, not spawn an orphaned replacement.
Environment
- All platforms (macOS, Linux, Windows)
- Floating terminal feature introduced in recent releases
Evaluation contract
Bootstrap a terminal tab only when the panel transitions open. An explicit close action that removes the last tab closes the panel; a PTY exit removes its tab but must neither close the panel nor create a replacement tab. Bulk close operations must read the current store state rather than a stale render-time tab list, and
closeToRightmust follow the reconciled visible tab-bar order rather than raw backing-array order.Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /orca, current file: none) bash-$
- Assistant
I’ll first inspect the repository structure and locate
FloatingTerminalPanel.tsx, related store APIs, and tests. Then I’ll reproduce the state-transition behavior at the most focused test level available before implementing the lifecycle and fresh-state fixes. - Assistant
The target component is isolated under the renderer. I’ll now read its callbacks/effects and trace the terminal and panel store actions so the fix preserves the distinction between explicit user closure and PTY-driven removal.
- Assistant
The existing effect is level-triggered (
open && tabs.length === 0), confirming the reported loop. The explicit close callback also does not close the panel, and both bulk callbacks capture render-time tabs. I’ll inspectTabBarordering semantics and PTY exit handling to implement visible-order reconciliation consistently with existing conventions. - Assistant
The component has two explicit-close paths: the tab X/context route and
TerminalPane.onCloseTab; PTY exit is separately wired and must remain a plain store removal. I’ll use the samereconcileTabOrderhelper asTabBarforcloseToRight, reading both tabs and stored order atomically fromuseAppStore.getState(). I’ll also verify store removal is synchronous, which determines whether the last-tab check should occur before or after calling it. - Assistant
The store update is synchronous. The robust lifecycle is therefore: remember prior
open, bootstrap only on a false→true transition using fresh store state, and omit tab count from effect dependencies. Explicit close checks fresh membership/count, removes the tab, and closes the panel only when that removal empties it. PTY exit remains directly connected tocloseTab, whileonCloseTabwill use the explicit wrapper. Before editing, I’ll inspectTerminalPanecallback semantics and repository formatting/import conventions. - Assistant
I’m applying the focused component change now: transition-gated bootstrapping, explicit-last-close panel dismissal, fresh-state bulk operations, reconciled visible ordering, and preserving the direct PTY-exit removal path. No interface changes are needed.
- Assistant
The edit did not apply because this environment lacks
python3; formatting consequently made no source change. I’ll reapply the same patch using the repository’s available Node runtime, then inspect the exact diff. - Assistant
The diff now matches the intended behavior. One key edge case is handled explicitly: callbacks for stale/nonexistent tab IDs return without dismissing the panel. Opening an already-populated panel also does not create another tab, while reopening an empty panel does. I’ll run renderer type checking, lint on the changed file, and the existing floating-terminal test first.
- Assistant
pnpmcould not run because Corepack attempted an interactive package-manager download, which this environment forbids. Dependencies are already installed, so I’ll invoke the local project binaries directly with the same configs instead. - Assistant
Type checking and the focused test passed, but lint reports the component one effective line over its 400-line limit.
reconcileTabOrderalready guarantees every returned ID belongs to the current tab set, so the extra map/guard incloseToRightis redundant; simplifying that loop will satisfy lint without changing behavior. - Assistant
Lint is now clean and only the intended source file is modified. I’ll inspect the final diff for accidental changes and run the relevant tab-order reconciliation tests, since
closeToRightnow depends on that helper’s guarantees. Then I’ll attempt the complete unit suite if runtime permits. - Assistant
The final diff is focused and the reconciliation suite passes all seven cases, including stale IDs, deduplication, and interleaved order. I’ll now run the complete configured unit suite to detect unrelated integration regressions; if the terminal command limit interrupts it, I’ll report that transparently and rely on the successful focused checks plus renderer type checking.
- Assistant
The complete suite ran: 6,711 tests passed, while failures are environment/pre-existing issues (missing Electron,
node-pty, andbetter-sqlite3native binaries, plus unrelated platform-sensitive tests). None reference the changed floating-terminal component. I’ll perform one final renderer typecheck/lint/diff check after the loop simplification and confirm the working tree contains no generated artifacts before submission.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →