ISSUE DESCRIPTION [BUG] S3 GetObject suffix range fails for empty objects Service S3 AWS…
- User
ISSUE DESCRIPTION
[BUG] S3 GetObject suffix range fails for empty objects
Service
S3
AWS API Action
GetObject with the
Rangeheader set to a suffix byte range, for examplebytes=-1.Expected behavior
A suffix range request against an existing empty object should not fail the read. This is exercised by Trino's S3 filesystem compatibility test for empty files, where
TrinoInput.readTail(...)reads an existing zero-byte S3 object and expects an empty successful read.Actual behavior
Floci returns
416 InvalidRangefor the same request becauseS3Controller.handleRangeRequestcomputesstart = 0andend = -1for an empty object, then rejects the range.In Trino's Floci-backed S3 filesystem test this surfaces as:
software.amazon.awssdk.services.s3.model.S3Exception: The requested range is not satisfiable. (Service: S3, Status Code: 416)Reproduction
# Start Floci on localhost:4566 first. aws --endpoint-url http://localhost:4566 s3 mb s3://range-empty-repro printf '' > /tmp/empty-object aws --endpoint-url http://localhost:4566 s3 cp /tmp/empty-object s3://range-empty-repro/empty aws --endpoint-url http://localhost:4566 s3api get-object \ --bucket range-empty-repro \ --key empty \ --range 'bytes=-1' \ /tmp/range-empty-outputEnvironment
- Floci version / image tag:
floci/floci:1.5.21 - Java SDK version (if applicable): observed with Trino's AWS SDK v2 S3 client tests
- How you're running Floci (Docker / native /
mvn quarkus:dev): Docker via Testcontainers
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /floci, current file: none) bash-$
- Floci version / image tag:
- Assistant
I’ll first locate the S3 range handling code and its existing tests, then reproduce the empty-object suffix calculation at the most focused test level available. After implementing a narrowly scoped fix, I’ll run the relevant tests and inspect the final diff.
- Assistant
The implementation is in
S3Controller; I’ll inspect the full method, nearby normal GetObject behavior, and all S3 test coverage mentioning ranges or empty objects so the fix preserves existing response conventions. - Assistant
The bug is confirmed directly in the code path: for
bytes=-1and zero bytes, parsing yields(start, end) = (0, -1), which necessarily reaches the 416 check. Since a zero-length representation has no validContent-Rangeinterval for a 206 response, the compatible successful behavior should be a normal 200 response with an empty body and whole-object headers. I’ll inspect test fixtures and header helpers before extracting/reusing response construction rather than duplicating subtly different metadata behavior. - Assistant
The normal GET path already provides exactly the desired response, including checksums and metadata. I’ll introduce a small helper for that response and call it both for ordinary GETs and for a valid suffix range on an empty object. Importantly, parsing and validating the suffix must happen first, so malformed (
bytes=-) and non-positive (bytes=-0) ranges remain 416; explicit/open-ended ranges on an empty object also retain their existing unsatisfiable behavior because the issue is specifically suffix semantics. - Assistant
python3is unavailable in the environment, so no file was changed. I’ll apply the same edit using the repository editor commands, starting with the exact line numbers shown bynl. - Assistant
I’ll now replace the duplicated normal response, add the empty-suffix branch after suffix validation, and insert the shared whole-object response helper.
- Assistant
The insertion point shifted after the earlier edit and placed the helper inside
handleRangeRequest; the displayed review caught this before compilation. I’ll replace that entire response tail atomically so method boundaries are correct. - Assistant
The corrected structure is now clean and
git diff --checkpasses. I’ll run the focused S3 integration test class first; this validates compilation plus existing full, open-ended, suffix, malformed, and unsatisfiable range behavior, as well as unchanged ordinary GET metadata. - Assistant
The Maven wrapper did not start because this minimal shell has no
HOMEvariable; that is an environment issue rather than a test failure. I’ll rerun withHOME=/rootexplicitly set. - Assistant
Compilation succeeded and 97/98 S3 integration tests passed, including all range tests. The sole failure is an unrelated pre-existing non-ASCII key expectation (
InvalidKeybefore this changed code path). To verify the reported case end-to-end without altering tests, I’ll package with tests skipped, launch Floci temporarily, usecurlto create a bucket and zero-byte object, then compare valid empty suffix, malformed suffix, and ordinary non-empty suffix responses. - Assistant
The end-to-end reproduction now succeeds:
bytes=-1on the empty object returns HTTP 200 withContent-Length: 0; malformedbytes=-still returns 416; andbytes=-1on a non-empty object still returns 206 with the correct last byte. I’ll perform final static checks, inspect the complete diff/status, and confirm no accidental files or response behavior changes were introduced.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →
Qwen/Qwen3.5-35B-A3BCompare side by side →