ISSUE DESCRIPTION Streaming drops XML tool-call output that non-streaming parses…
- User
ISSUE DESCRIPTION
Streaming drops XML tool-call output that non-streaming parses correctly
Streaming must emit the same recovered XML tool calls as non-streaming, including calls split across chunks and multiple calls, and finish with
tool_calls. Reasoning mode and request tool selection must not alter recovery. Plain text or malformed markup must not create calls or abort the stream.Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /Rapid-MLX, current file: none) bash-$
- Assistant
I’ll trace the non-streaming and streaming XML tool-call parsing paths, reproduce the discrepancy with the existing test structure, then make the smallest shared/streaming-side fix. I’ll run focused tests plus relevant broader tests and inspect the final diff before submission.
- Assistant
The relevant recovery path is
HermesToolParser, which handles the Nemotron/Qwen-Coder XML form used by the existing tests. Its streaming code uses raw closing-tag counts as the slice offset, so a malformed closed block increments the offset even though non-streaming correctly rejects it; a later valid call is then dropped. It also suppresses all output when a later call is incomplete, including earlier calls already completed in the same accumulated text. I’ll make streaming deduplication use successfully parsed prior calls and emit newly completed valid calls before suppressing an incomplete remainder. - Assistant
The fix now:
- counts only successfully parsed completed XML/function blocks, avoiding malformed-block index drift;
- emits completed calls even when a later block is unfinished;
- keeps incomplete markup suppressed and leaves plain/malformed content from fabricating calls;
- preserves reasoning stripping and request-driven parameter conversion by routing all recovery through the existing non-streaming parser.
Focused parser/postprocessor tests pass (208 total), the regression scenarios for split chunks, multiple calls, reasoning, request tools, and malformed interleaving were exercised, and
git diff --checkis clean. I’ll submit the single-source change.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →