ISSUE DESCRIPTION Respect additionalProperties false during v4 OpenAPI schema import…
- User
ISSUE DESCRIPTION
Respect additionalProperties false during v4 OpenAPI schema import This tracks unresolved feedback identified by cubic on PR #1149: https://github.com/withcoral/coral/pull/1149#discussion_r3347190658
Context: This appears to be pre-existing DSL v4 behavior surfaced by the refactor review, not a regression from the module split.
Problem: The schema importer treats the presence of
additionalPropertiesas map-like, soadditionalProperties: falsecan be imported as a free-form map instead of a closed object.Acceptance criteria: Handle boolean
additionalProperties: falseas a closed object, preserve schema-valued additionalProperties behavior, and add focused schema import coverage.ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /coral, current file: none) bash-$
- Assistant
I’ll trace the v4 OpenAPI schema importer and its existing tests, identify where
additionalPropertiesis classified as map-like, reproduce the incorrect import if practical, then make the smallest source change and add no repository tests (per the environment constraint; I’ll use temporary checks if needed). I’ll run the relevant test suite and inspect the final diff before submitting. - Assistant
The relevant code is in
crates/coral-spec/src/v4/surfaces/openapi/schemas.rs, with focused importer tests likely inopenapi_tests.rs. I’ll inspect the schema conversion logic and the project’s IR type definitions to determine exactly how “closed object” is represented, then run the existing OpenAPI tests before editing. - Assistant
The bug is confirmed by control flow: any
additionalPropertiesvalue enters the map branch; forfalse, recursive schema import falls back to JSON and producesMap { value_type_ref: "json" }. Schema-valued additional properties must continue to recurse into a map value type. The fix should distinguishfalsefrom an object schema (and likely retain existing behavior fortrueunless the IR has a dedicated unconstrained-map representation); I’ll inspect IR serialization and test conventions before choosing the exact branch. - Assistant
IrTypeShape::Object { fields: Vec<_> }is the closed-object representation, including an empty object. I’ll change only theadditionalPropertiesbranch sofalseyields an emptyObject, while schema values (and existingtruehandling) still produce aMap. This also preserves the current precedence for schemas that declare explicitproperties. I’ll first run the focused crate tests, then apply the change and rerun them. - Assistant
The focused tests passed before the edit, and the diff now explicitly handles
additionalProperties: falseas an empty closed object. I’ll validate formatting, run the fullcoral-spectest suite, and inspect lint/build results. I’ll also verify the diff contains no unintended changes.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
- xiaomi/mimo-v2.5-proCompare side by side →
- xiaomi/mimo-v2.5-proCompare side by side →
- xiaomi/mimo-v2.5-proCompare side by side →
- xiaomi/mimo-v2.5-proCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →
- gpt-5.6-solCompare side by side →