ISSUE DESCRIPTION Removing a registered or subscribed service leaves stale local…
- User
ISSUE DESCRIPTION
Removing a registered or subscribed service leaves stale local metadata
After a successful unregister or unsubscribe operation, the corresponding provider or consumer URL must no longer participate in local metadata, service matching, or revision calculation. Removing one URL must preserve unrelated registrations. If the remote operation fails, local metadata must not be removed as though the operation succeeded.
Interface
Type: Function Name: RemoveService Path: metadata/metadata.go Input: registryId string, url *common.URL Output: (no return value) Description: Removes a provider service URL from the local metadata for the given registry. Use this during unregister flows to keep the in-memory application-level metadata consistent with the actual exported services.
Type: Function Name: RemoveSubscribeURL Path: metadata/metadata.go Input: registryId string, url *common.URL Output: (no return value) Description: Removes a subscribed service URL from the local metadata for the given registry. Use this during unsubscribe flows to ensure stale subscribed URLs are cleaned from the application-level metadata.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /dubbo-go, current file: none) bash-$
- Assistant
I’ll inspect the metadata implementation and unregister/unsubscribe flows, identify where local state is updated relative to remote success, then implement removal APIs and integrate them only after successful remote operations. I’ll run focused tests plus relevant repository tests and review the final diff.
- Assistant
The application-level metadata is populated by the service-discovery registry, not the generic registry. I found that unregister currently removes remote instances but never removes the provider URL, while unsubscribe similarly leaves its URL after successful mapping removal. I’ll add the requested metadata wrappers, make URL removal match the registered URL value rather than pointer identity, preserve another URL with the same service match key, and invoke cleanup only on successful operations.
- Assistant
The implementation is in place. The first focused test command could not start because this environment has neither
GOMODCACHEnorGOPATHconfigured, so I’ll locate or establish a temporary module cache outside the repository and rerun tests. Before that, I’ll inspect the exact diff and compile-sensitive call sites. - Assistant
Focused metadata and service-discovery tests now pass. The final behavior is:
- removal is a no-op for unknown/nil URLs;
- cloned URLs are recognized by full URL key;
- same-service/different-protocol registrations retain their
ServiceInfo; - revision is invalidated when exported services change;
- unsubscribe/unregister cleanup occurs only after the remote/mapping operation succeeds.
Checklist:
- Reproduction: the stale-state path was confirmed by tracing the existing add-only metadata flow and missing cleanup calls; no runtime error was reported to reproduce.
- Fix confirmation: focused tests pass after the changes.
- Edge cases: unknown URLs, cloned URLs, duplicate/same-service registrations, remote failures, and nil metadata entries were considered.
- Existing tests: all affected
metadata/...andregistry/servicediscovery/...tests pass. I’ll do one final diff/status review, then submit.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →