ISSUE DESCRIPTION The TriggerSchedulerMonitor reports realtime triggers as locked…
- User
ISSUE DESCRIPTION
The
TriggerSchedulerMonitorreports realtime triggers as lockedDescribe the issue
The
TriggerSchedulerMonitorreports realtime triggers as locked.[tenant: main] [namespace: company.team] [flow: realtime-kafka] [trigger: kafka] No execution found, schedule is blocked since '2026-04-27T13:38:23.415498Z'
But as those trigger will always be blocked without any executionID they will be reported indefinitly.
Environment
- Kestra Version: develop
Interface
No new interfaces are introduced.
ADDITIONAL ADVICE
Since you are given a git repository, you can use git commands to simplify your work. For example, if you made a mistake and want to revert your changes, you can use
git checkout <file>to restore the file to its original state. You can also reset all changes in the repository usinggit reset --hardcommand. Additionally, you can usegit stashandgit stash popto temporarily save your changes and restore them later. Finally, you can see the changes that you've made (which will be submitted when you callsubmit) usinggit statusorgit diffcommands. However you don't need to usegit addorgit commitbefore submitting your changes. In fact,submitonly submits currently unstaged changes because it usesgit diffto get the changes that need to be submitted.CHECKLIST
Before submitting your solution, please go over the following checklist and make sure you've done everything:
- If an error was reported in the issue description, I have successfully reproduced it.
- If an error was reported in the issue description, I have confirmed that my fix resolves the error.
- I have thought about edge cases and made sure my fix handles them as well.
- I have run existing tests in the repository that might have been affected by the change I made and confirmed that they pass. I want you to list every bullet from this checklist and write your reasoning for why you think you did it or didn't need to.
Repository has been uploaded and your shell is currently at the repository root. Time to solve the issue!
(Current directory: /kestra, current file: none) bash-$
Assistant
Let me start by exploring the repository structure to understand what we're working with.
Assistant
Now let me understand the issue. The
TriggerSchedulerMonitorreports realtime triggers as locked. Let me understand what triggers are involved and how realtime triggers differ from regular ones.Let me look at the
TriggerStatemodel and thefindTriggersEligibleForSchedulingmethod.Assistant
Now I understand the issue. The
TriggerSchedulerMonitorreports locked triggers as blocked. But for realtime triggers, they are always "locked" while running (because they have a workerId assigned), and they don't have an execution ID associated with them in the same way. Realtime triggers like Kafka listeners run continuously and don't create executions that match the trigger in a way thatfindAllByTriggerwould find them.Let me look at the
findTriggersEligibleForSchedulingmethod and thefindAllByTriggermethod.Assistant
Now let me look at the
findAllByTriggermethod and understand how realtime triggers are handled.Assistant
Now I understand the full picture. The
TriggerSchedulerMonitoris designed to monitor triggers that are locked because they're waiting for an execution to complete (this is for SCHEDULE and POLLING triggers). Realtime triggers (REALTIME) are always locked while they're running because a worker is assigned to listen to events continuously. Let me look at the tests for this monitor.Assistant
Now let me modify the
TriggerSchedulerMonitorto skip realtime triggers, since the monitor's purpose (checking for blocked executions) doesn't apply to realtime triggers—they're locked because a worker is listening to events, not because an execution is blocking them.Assistant
Now let me add the import for
TriggerTypeand filter out realtime triggers:Assistant
Now let me add the filter for realtime triggers in the forEach loop:
Assistant
The filter
state.getType() != TriggerType.REALTIMEcorrectly handles null types (null != REALTIME is true, so null-type triggers are still monitored, preserving safe behavior). Let me verify thetypefield exists in the database schema and check migrations.Assistant
The
typefield is part of the JSON value (not a separate column), so it's deserialized. For older triggers it could be null, but my filter handles null safely. Now let me verify the code compiles. Let me check the build setup.Assistant
Compilation succeeded with only warnings. Now let me check for any existing tests that might be affected by this change.
Assistant
Let me check how realtime triggers are handled in the scheduling loop to confirm my understanding of their locking behavior.
Assistant
My fix is correct. Let me view the final version of the file to confirm:
Assistant
Now let me run the scheduler tests to make sure nothing breaks:
Assistant
Tests compile fine (only unchecked warnings). Let me run the scheduler tests to confirm nothing breaks:
Assistant
Tests passed (no errors reported, just JVM warnings). Let me verify the exit code was 0.
Assistant
Build successful and tests pass. Let me review the final diff:
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.
Identical first prompt
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
claude-sonnet-5Compare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-35B-A3BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →
Qwen/Qwen3.6-27BCompare side by side →